From patchwork Mon Sep 25 09:55:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13397604 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B73F7CE7A98 for ; Mon, 25 Sep 2023 09:56:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iBEoYp6hn/42ErbKM71tQeU2OBhFKyN0m8fuTfjXYew=; b=qLOcib5n1/vzWS lrqWQZH1f9PrjfYET4mYz6FTmk/62cEJXWcSnq5UZ17a1hgg/y12FI6l7GQMN0isJ7z+wE5XUOAK8 FCaHF/WpIxl1KiWC+ev64aEShoeexM9qltxTgKWiubTfZkV/9W81LVptWYgwkBNVHvWM7IYsp96dW 4Boqp2FNdSHzQHOw77oICcoTvpKWV3+fDyeady3NBLRUdn0GORRE4+KP5P52ohTOYAa8Iqd/IHzSM uH2pvtGi96fuTBrsUFULGeQXrA26cJgQ7xzmwAI6ZFG0Wz2kl21liZft7c5tvaIz4Zyvgmw83vfGK W99WuRyOHk7Qxyp5l9ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkiKL-00DuKp-0m; Mon, 25 Sep 2023 09:56:29 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkiJi-00DtjA-1I for linux-arm-kernel@lists.infradead.org; Mon, 25 Sep 2023 09:55:52 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkiJc-0008Ar-NY; Mon, 25 Sep 2023 11:55:44 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qkiJc-008q15-Ap; Mon, 25 Sep 2023 11:55:44 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qkiJc-004dms-1k; Mon, 25 Sep 2023 11:55:44 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Nishanth Menon , Santosh Shilimkar Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 39/40] soc/ti: wkup_m3_ipc: Convert to platform remove callback returning void Date: Mon, 25 Sep 2023 11:55:30 +0200 Message-Id: <20230925095532.1984344-40-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1865; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=uKW31zoDaSRnidHyxwgUspOOB3QVRh8Uu/IMjh6/dVw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlEVhreqDzPwrtv2WQm2i+IxS/5UArlWfx0Rx+z c0iw41zTrGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZRFYawAKCRCPgPtYfRL+ Tgj7B/sEJhCf+1WQJSVdnoeJx+FmTbUzIRWuDSgAgygIwuy13zVj7Ku/cIffjU3ntQqe4ybLY+3 oU4/yc7ndjFJ+5zLPHhetU84byJyVn7RArFqSKG9OdOTWP3YXELqmaQYmO7MZMMNo2ttNAoLsox ILAZEc4X/eUWLJ3voeH0ICDFS8xrPh9Kb7EwWZWZ2slwFMxh9DFW4kLF/H4WITAm/ezT8TglhxY IzuSMW1NCA3IRIilWP04/MPRZ/kSWpzzItf9r4jFtqGEAsPsyYG5ct8xPlhIFjBHZ7AcSaGKF1x dQdTNWpzC8dUmqKbNSAB/5qIV2xFv/ouz8ZyzCWyj4N1PWdv X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_025550_438220_C4E1809D X-CRM114-Status: GOOD ( 16.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/soc/ti/wkup_m3_ipc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c index 3aff106fc11a..6a1c6b34c414 100644 --- a/drivers/soc/ti/wkup_m3_ipc.c +++ b/drivers/soc/ti/wkup_m3_ipc.c @@ -713,7 +713,7 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev) return ret; } -static int wkup_m3_ipc_remove(struct platform_device *pdev) +static void wkup_m3_ipc_remove(struct platform_device *pdev) { wkup_m3_ipc_dbg_destroy(m3_ipc_state); @@ -723,8 +723,6 @@ static int wkup_m3_ipc_remove(struct platform_device *pdev) rproc_put(m3_ipc_state->rproc); m3_ipc_state = NULL; - - return 0; } static int __maybe_unused wkup_m3_ipc_suspend(struct device *dev) @@ -760,7 +758,7 @@ MODULE_DEVICE_TABLE(of, wkup_m3_ipc_of_match); static struct platform_driver wkup_m3_ipc_driver = { .probe = wkup_m3_ipc_probe, - .remove = wkup_m3_ipc_remove, + .remove_new = wkup_m3_ipc_remove, .driver = { .name = "wkup_m3_ipc", .of_match_table = wkup_m3_ipc_of_match,