diff mbox series

arm64: dts: imx8mp-verdin: Remove invalid property from eqos

Message ID 20230928023453.370255-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: imx8mp-verdin: Remove invalid property from eqos | expand

Commit Message

Fabio Estevam Sept. 28, 2023, 2:34 a.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Per nxp,dwmac-imx.yaml, it is not valid to pass 'phy-supply'.

The reg_module_eth1phy regulator is marked with 'regulator-always-on',
so it is safe to remove it from the eqos node.

Remove it to fix the following schema warning:

imx8mp-verdin-nonwifi-dahlia.dtb: ethernet@30bf0000: Unevaluated properties are not allowed ('phy-supply' was unexpected)
	from schema $id: http://devicetree.org/schemas/net/nxp,dwmac-imx.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Marcel Ziswiler Sept. 28, 2023, 2:36 p.m. UTC | #1 
Hi Fabio

Thanks!

On Wed, 2023-09-27 at 23:34 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per nxp,dwmac-imx.yaml, it is not valid to pass 'phy-supply'.
> 
> The reg_module_eth1phy regulator is marked with 'regulator-always-on',
> so it is safe to remove it from the eqos node.
> 
> Remove it to fix the following schema warning:
> 
> imx8mp-verdin-nonwifi-dahlia.dtb: ethernet@30bf0000: Unevaluated properties are not allowed ('phy-supply' was
> unexpected)
> 	from schema $id: http://devicetree.org/schemas/net/nxp,dwmac-imx.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

> ---
>  arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-
> verdin.dtsi
> index e9e4fcb562f1..04f2083c4ab2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -184,7 +184,6 @@ &ecspi1 {
>  &eqos {
>  	phy-handle = <&ethphy0>;
>  	phy-mode = "rgmii-id";
> -	phy-supply = <&reg_module_eth1phy>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_eqos>;
>  	snps,force_thresh_dma_mode;

Cheers

Marcel
Shawn Guo Oct. 10, 2023, 1:21 a.m. UTC | #2 
On Wed, Sep 27, 2023 at 11:34:53PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per nxp,dwmac-imx.yaml, it is not valid to pass 'phy-supply'.
> 
> The reg_module_eth1phy regulator is marked with 'regulator-always-on',
> so it is safe to remove it from the eqos node.
> 
> Remove it to fix the following schema warning:
> 
> imx8mp-verdin-nonwifi-dahlia.dtb: ethernet@30bf0000: Unevaluated properties are not allowed ('phy-supply' was unexpected)
> 	from schema $id: http://devicetree.org/schemas/net/nxp,dwmac-imx.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
index e9e4fcb562f1..04f2083c4ab2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
@@ -184,7 +184,6 @@  &ecspi1 {
 &eqos {
 	phy-handle = <&ethphy0>;
 	phy-mode = "rgmii-id";
-	phy-supply = <&reg_module_eth1phy>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_eqos>;
 	snps,force_thresh_dma_mode;