From patchwork Fri Sep 29 15:02:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 13404503 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39102E71D40 for ; Fri, 29 Sep 2023 15:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:In-Reply-To:References:Message-Id: MIME-Version:Subject:Date:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VumgiMSP/cHaOEydya2XgmFGtsmVZkcyHu3EA4Igzpk=; b=x/Y85VpMAkvBti NBXQVoPGAvj2ik2c47EEImWaE9TAQL0lpDqk5BmFNSWV/MNyGACWyHJ9sMAzrVGjG6+z24Rzy/Ag/ 43YE65kSKUoTilY1vPKvhky31VSjxVvw6IyxjM5jVtmTomxUjKOcZngHhNlRhARG6yyNyHO+75T6X 9HkzxTUHHtJHs5vaBebww1EGI/2niDGYPHvznLywNpw1K9gz5ahyybDNci5M2L+bOwWUIsw00UdJj k25IMStggRTjIux71gNhWDha4vL5ZuUc+x4gA+pGmoEL4SJgCGkHaOOaT5afnrI+RCCy8TKxEZdYX yR1N8kTr+cRqYj9Hm84w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qmF1l-0088Mz-0H; Fri, 29 Sep 2023 15:03:37 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qmF1U-0088Df-2J for linux-arm-kernel@lists.infradead.org; Fri, 29 Sep 2023 15:03:22 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 794261007; Fri, 29 Sep 2023 08:03:55 -0700 (PDT) Received: from e103737-lin.cambridge.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 226643F5A1; Fri, 29 Sep 2023 08:03:16 -0700 (PDT) From: Sudeep Holla Date: Fri, 29 Sep 2023 16:02:51 +0100 Subject: [PATCH v3 02/17] firmware: arm_ffa: Implement notification bitmap create and destroy interfaces MIME-Version: 1.0 Message-Id: <20230929-ffa_v1-1_notif-v3-2-c8e4f15190c8@arm.com> References: <20230929-ffa_v1-1_notif-v3-0-c8e4f15190c8@arm.com> In-Reply-To: <20230929-ffa_v1-1_notif-v3-0-c8e4f15190c8@arm.com> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sudeep Holla , Marc Bonnici , Jens Wiklander , Coboy Chen , Lorenzo Pieralisi , Olivier Deprez X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3398; i=sudeep.holla@arm.com; h=from:subject:message-id; bh=E8dkL+QG2QXGEwg80l0faZM6cA032hi2OPI14UW5ukU=; b=owEBbQKS/ZANAwAIAQBBurwxfuKYAcsmYgBlFucuvBBiLwRwI+A6SBHoF7BhodlY60hl2wjwZ SYQKjnfHqqJAjMEAAEIAB0WIQS6ceUSBvMeskPdk+EAQbq8MX7imAUCZRbnLgAKCRAAQbq8MX7i mFOQEAC1qH09c9WVdsH6CsUdBdw3pCM0Gbn2kvv/5BJyJEKhaSlahsvCohQGLVkTiinsRzlQN/G AcbwPbb9tZ6+AvWDnxeUa+YLz+hjT8PgQuLziXUmrqyngPU8IivU3ENKLnHIjjyI68E+q1hEddD Svfmo57KwmzLDn6fbf4BlyL2rF2KDR+VamNUuLOUp2dCgn9nMoQ/1bchDcxwLK2OiYyAiTqI+Fs tSCdY/pzUJXye/nnv5FK+H++Y9Xv2Ji4lmCTPDKTunmMpVRu2xlG5JClEVE5XfLjLwCsvkGiEF5 me4K9Kg3IIoENEpbOV18LLSJN7BcY/LU6DKfhqvH5jhRHx0rbm7lkhikTDwFCR1Gwdy8IJ6VgHn o40WyqaKv6EorKh4e+DFuAGDp6d/XpyS5OTVGE7HDWlucYNIAl61NZrm3KEmrjFekJhyhgRIeo8 q9cX4JCiLvfKxuMCzChS7AuDsBBqxqKxl01wFXBzKAV+xFIySKgSlLRmnLbelzFtlE6b//SigsB jaXxpvQwwDP9iNWBomOpWr6CDOJfb3VfumDdG7+ZWp25wXMhkgNy/gTVs4KlvT6o/EWJIexGdNy 5CeJ3/a3wfsW/0u+goWAFd7k+lebdnG7HsvrJLbCXR3eyzJLSTHfT3QwXPqQRyKuLB4pns2+euD 4XFwj2kKBd17Y+w== X-Developer-Key: i=sudeep.holla@arm.com; a=openpgp; fpr=7360A21742ADF5A11767C1C139CFD4755FE2D5B4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230929_080320_859173_2F906634 X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On systems without a hypervisor the responsibility of requesting the creation of the notification bitmaps in the SPM falls to the FF-A driver. We use FFA features to determine if the ABI is supported, if it is not we can assume there is a hypervisor present and will take care of ensure the relevant notifications bitmaps are created on this partitions behalf. An endpoint’s notification bitmaps needs to be setup before it configures its notifications and before other endpoints and partition managers can start signaling these notifications. Add interface to create and destroy the notification bitmaps and use the same to do the necessary setup during the initialisation and cleanup during the module exit. Signed-off-by: Sudeep Holla --- drivers/firmware/arm_ffa/driver.c | 60 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index 2b24cda2a185..efa4e7fb15e3 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -84,6 +84,7 @@ struct ffa_drv_info { void *rx_buffer; void *tx_buffer; bool mem_ops_native; + bool bitmap_created; }; static struct ffa_drv_info *drv_info; @@ -555,6 +556,37 @@ static int ffa_features(u32 func_feat_id, u32 input_props, return 0; } +static int ffa_notification_bitmap_create(void) +{ + ffa_value_t ret; + u16 vcpu_count = nr_cpu_ids; + + invoke_ffa_fn((ffa_value_t){ + .a0 = FFA_NOTIFICATION_BITMAP_CREATE, + .a1 = drv_info->vm_id, .a2 = vcpu_count, + }, &ret); + + if (ret.a0 == FFA_ERROR) + return ffa_to_linux_errno((int)ret.a2); + + return 0; +} + +static int ffa_notification_bitmap_destroy(void) +{ + ffa_value_t ret; + + invoke_ffa_fn((ffa_value_t){ + .a0 = FFA_NOTIFICATION_BITMAP_DESTROY, + .a1 = drv_info->vm_id, + }, &ret); + + if (ret.a0 == FFA_ERROR) + return ffa_to_linux_errno((int)ret.a2); + + return 0; +} + static void ffa_set_up_mem_ops_native_flag(void) { if (!ffa_features(FFA_FN_NATIVE(MEM_LEND), 0, NULL, NULL) || @@ -712,6 +744,31 @@ static void ffa_setup_partitions(void) kfree(pbuf); } +static int ffa_notifications_setup(void) +{ + int ret; + + ret = ffa_features(FFA_NOTIFICATION_BITMAP_CREATE, 0, NULL, NULL); + if (!ret) { + ret = ffa_notification_bitmap_create(); + if (ret) { + pr_err("notification_bitmap_create error %d\n", ret); + return ret; + } + } + drv_info->bitmap_created = true; + + return 0; +} + +static void ffa_notifications_cleanup(void) +{ + if (drv_info->bitmap_created) { + ffa_notification_bitmap_destroy(); + drv_info->bitmap_created = false; + } +} + static int __init ffa_init(void) { int ret; @@ -767,7 +824,7 @@ static int __init ffa_init(void) ffa_set_up_mem_ops_native_flag(); - return 0; + return ffa_notifications_setup(); free_pages: if (drv_info->tx_buffer) free_pages_exact(drv_info->tx_buffer, RXTX_BUFFER_SIZE); @@ -782,6 +839,7 @@ subsys_initcall(ffa_init); static void __exit ffa_exit(void) { + ffa_notifications_cleanup(); ffa_rxtx_unmap(drv_info->vm_id); free_pages_exact(drv_info->tx_buffer, RXTX_BUFFER_SIZE); free_pages_exact(drv_info->rx_buffer, RXTX_BUFFER_SIZE);