| Message ID | 20230929185510.707475-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: ls1012a: Remove big-endian from thermal | expand |
On Fri, Sep 29, 2023 at 03:55:10PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Per qoriq-thermal.yaml, 'big-endian' is not a valid property. > > When the 'little-endian' property is absent, the default is big endian. > > Remove it to fix the following schema warning: > > tmu@1f00000: 'big-endian' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/thermal/qoriq-thermal.yaml# > > Signed-off-by: Fabio Estevam <festevam@denx.de> Leo, Can you confirm this is fine? Shawn > --- > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > index a863022529ac..d0733451d3ce 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > @@ -346,7 +346,6 @@ tmu: tmu@1f00000 { > 0x00030004 0x00000047 > 0x00030005 0x00000053 > 0x00030006 0x00000060>; > - big-endian; > #thermal-sensor-cells = <1>; > }; > > -- > 2.34.1 >
Hi Leo, On Mon, Oct 9, 2023 at 10:40 PM Shawn Guo <shawnguo@kernel.org> wrote: > > On Fri, Sep 29, 2023 at 03:55:10PM -0300, Fabio Estevam wrote: > > From: Fabio Estevam <festevam@denx.de> > > > > Per qoriq-thermal.yaml, 'big-endian' is not a valid property. > > > > When the 'little-endian' property is absent, the default is big endian. > > > > Remove it to fix the following schema warning: > > > > tmu@1f00000: 'big-endian' does not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: http://devicetree.org/schemas/thermal/qoriq-thermal.yaml# > > > > Signed-off-by: Fabio Estevam <festevam@denx.de> > > Leo, > > Can you confirm this is fine? Do you agree with this change? > > Shawn > > > --- > > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > index a863022529ac..d0733451d3ce 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > @@ -346,7 +346,6 @@ tmu: tmu@1f00000 { > > 0x00030004 0x00000047 > > 0x00030005 0x00000053 > > 0x00030006 0x00000060>; > > - big-endian; > > #thermal-sensor-cells = <1>; > > }; > > > > -- > > 2.34.1 > >
> -----Original Message----- > From: Fabio Estevam <festevam@gmail.com> > Sent: Tuesday, December 5, 2023 4:00 PM > To: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com> > Cc: linux-arm-kernel@lists.infradead.org; Fabio Estevam > <festevam@denx.de> > Subject: Re: [PATCH] arm64: dts: ls1012a: Remove big-endian from thermal > > Hi Leo, > > On Mon, Oct 9, 2023 at 10:40 PM Shawn Guo <shawnguo@kernel.org> wrote: > > > > On Fri, Sep 29, 2023 at 03:55:10PM -0300, Fabio Estevam wrote: > > > From: Fabio Estevam <festevam@denx.de> > > > > > > Per qoriq-thermal.yaml, 'big-endian' is not a valid property. > > > > > > When the 'little-endian' property is absent, the default is big endian. > > > > > > Remove it to fix the following schema warning: > > > > > > tmu@1f00000: 'big-endian' does not match any of the regexes: 'pinctrl-[0- > 9]+' > > > from schema $id: > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevice > tree.org%2Fschemas%2Fthermal%2Fqoriq- > thermal.yaml%23&data=05%7C01%7Cleoyang.li%40nxp.com%7Caefb2100b7 > a34977023908dbf5dd81a5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0 > %7C638374103934974217%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA > wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C > %7C&sdata=yUSalG9%2B0INDoSpIIu1aCsIM9Jt%2BuiPnNIWHY0uuzik%3D&re > served=0 > > > > > > Signed-off-by: Fabio Estevam <festevam@denx.de> > > > > Leo, > > > > Can you confirm this is fine? > > Do you agree with this change? You are right. Thanks for the fix. Acked-by: Li Yang <leoyang.li@nxp.com> > > > > > Shawn > > > > > --- > > > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > > index a863022529ac..d0733451d3ce 100644 > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > > > @@ -346,7 +346,6 @@ tmu: tmu@1f00000 { > > > 0x00030004 0x00000047 > > > 0x00030005 0x00000053 > > > 0x00030006 0x00000060>; > > > - big-endian; > > > #thermal-sensor-cells = <1>; > > > }; > > > > > > -- > > > 2.34.1 > > >
On Fri, Sep 29, 2023 at 03:55:10PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > Per qoriq-thermal.yaml, 'big-endian' is not a valid property. > > When the 'little-endian' property is absent, the default is big endian. > > Remove it to fix the following schema warning: > > tmu@1f00000: 'big-endian' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/thermal/qoriq-thermal.yaml# > > Signed-off-by: Fabio Estevam <festevam@denx.de> Applied, thanks!
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi index a863022529ac..d0733451d3ce 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi @@ -346,7 +346,6 @@ tmu: tmu@1f00000 { 0x00030004 0x00000047 0x00030005 0x00000053 0x00030006 0x00000060>; - big-endian; #thermal-sensor-cells = <1>; };