diff mbox series

pwm: bcm2835: Add support for suspend/resume

Message ID 20231005171516.2908961-1-florian.fainelli@broadcom.com (mailing list archive)
State New, archived
Headers show
Series pwm: bcm2835: Add support for suspend/resume | expand

Commit Message

Florian Fainelli Oct. 5, 2023, 5:15 p.m. UTC 
Similar to other drivers, we need to make sure that the clock is
disabled during suspend and re-enabled during resume.

Reported-by: Angus Clark <angus.clark@broadcom.com>
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
 drivers/pwm/pwm-bcm2835.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Uwe Kleine-König Oct. 9, 2023, 10:06 a.m. UTC | #1 
Hello Florian,

On Thu, Oct 05, 2023 at 10:15:15AM -0700, Florian Fainelli wrote:
> +static SIMPLE_DEV_PM_OPS(bcm2835_pwm_pm_ops, bcm2835_pwm_suspend,
> +			 bcm2835_pwm_resume);

The definition of SIMPLE_DEV_PM_OPS has a comment saying:

	Deprecated. Use DEFINE_SIMPLE_DEV_PM_OPS() instead.

Can you please rework your patch accordingly?

Best regards
Uwe
diff mbox series

Patch

diff --git a/drivers/pwm/pwm-bcm2835.c b/drivers/pwm/pwm-bcm2835.c
index bdfc2a5ec0d6..46c59317ba54 100644
--- a/drivers/pwm/pwm-bcm2835.c
+++ b/drivers/pwm/pwm-bcm2835.c
@@ -182,6 +182,25 @@  static void bcm2835_pwm_remove(struct platform_device *pdev)
 	clk_disable_unprepare(pc->clk);
 }
 
+static int __maybe_unused bcm2835_pwm_suspend(struct device *dev)
+{
+	struct bcm2835_pwm *pc = dev_get_drvdata(dev);
+
+	clk_disable_unprepare(pc->clk);
+
+	return 0;
+}
+
+static int __maybe_unused bcm2835_pwm_resume(struct device *dev)
+{
+	struct bcm2835_pwm *pc = dev_get_drvdata(dev);
+
+	return clk_prepare_enable(pc->clk);
+}
+
+static SIMPLE_DEV_PM_OPS(bcm2835_pwm_pm_ops, bcm2835_pwm_suspend,
+			 bcm2835_pwm_resume);
+
 static const struct of_device_id bcm2835_pwm_of_match[] = {
 	{ .compatible = "brcm,bcm2835-pwm", },
 	{ /* sentinel */ }
@@ -192,6 +211,7 @@  static struct platform_driver bcm2835_pwm_driver = {
 	.driver = {
 		.name = "bcm2835-pwm",
 		.of_match_table = bcm2835_pwm_of_match,
+		.pm = &bcm2835_pwm_pm_ops,
 	},
 	.probe = bcm2835_pwm_probe,
 	.remove_new = bcm2835_pwm_remove,