| Message ID | 20231006073831.10402-21-shawn.sung@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add display driver for MT8188 VDOSYS1 | expand |
Hi, Hsiao-chien: On Fri, 2023-10-06 at 15:38 +0800, Hsiao Chien Sung wrote: > DPI input is in 1T2P mode on both MT8195 and MT8188. > Remove the redundant driver data to align the settings, or > the screen will glitch. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Fixes: 2847cd7e6403 ("drm/mediatek: Add mt8188 dpi compatibles and > platform data") > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 2f931e4e2b60..bc073a6b367e 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -957,20 +957,6 @@ static const struct mtk_dpi_conf mt8186_conf = { > .csc_enable_bit = CSC_ENABLE, > }; > > -static const struct mtk_dpi_conf mt8188_dpintf_conf = { > - .cal_factor = mt8195_dpintf_calculate_factor, > - .max_clock_khz = 600000, > - .output_fmts = mt8195_output_fmts, > - .num_output_fmts = ARRAY_SIZE(mt8195_output_fmts), > - .pixels_per_iter = 4, > - .input_2pixel = false, > - .dimension_mask = DPINTF_HPW_MASK, > - .hvsize_mask = DPINTF_HSIZE_MASK, > - .channel_swap_shift = DPINTF_CH_SWAP, > - .yuv422_en_bit = DPINTF_YUV422_EN, > - .csc_enable_bit = DPINTF_CSC_ENABLE, > -}; > - > static const struct mtk_dpi_conf mt8192_conf = { > .cal_factor = mt8183_calculate_factor, > .reg_h_fre_con = 0xe0, > @@ -1094,7 +1080,7 @@ static const struct of_device_id > mtk_dpi_of_ids[] = { > { .compatible = "mediatek,mt8173-dpi", .data = &mt8173_conf }, > { .compatible = "mediatek,mt8183-dpi", .data = &mt8183_conf }, > { .compatible = "mediatek,mt8186-dpi", .data = &mt8186_conf }, > - { .compatible = "mediatek,mt8188-dp-intf", .data = > &mt8188_dpintf_conf }, > + { .compatible = "mediatek,mt8188-dp-intf", .data = > &mt8195_dpintf_conf }, > { .compatible = "mediatek,mt8192-dpi", .data = &mt8192_conf }, > { .compatible = "mediatek,mt8195-dp-intf", .data = > &mt8195_dpintf_conf }, > { /* sentinel */ },
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index 2f931e4e2b60..bc073a6b367e 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -957,20 +957,6 @@ static const struct mtk_dpi_conf mt8186_conf = { .csc_enable_bit = CSC_ENABLE, }; -static const struct mtk_dpi_conf mt8188_dpintf_conf = { - .cal_factor = mt8195_dpintf_calculate_factor, - .max_clock_khz = 600000, - .output_fmts = mt8195_output_fmts, - .num_output_fmts = ARRAY_SIZE(mt8195_output_fmts), - .pixels_per_iter = 4, - .input_2pixel = false, - .dimension_mask = DPINTF_HPW_MASK, - .hvsize_mask = DPINTF_HSIZE_MASK, - .channel_swap_shift = DPINTF_CH_SWAP, - .yuv422_en_bit = DPINTF_YUV422_EN, - .csc_enable_bit = DPINTF_CSC_ENABLE, -}; - static const struct mtk_dpi_conf mt8192_conf = { .cal_factor = mt8183_calculate_factor, .reg_h_fre_con = 0xe0, @@ -1094,7 +1080,7 @@ static const struct of_device_id mtk_dpi_of_ids[] = { { .compatible = "mediatek,mt8173-dpi", .data = &mt8173_conf }, { .compatible = "mediatek,mt8183-dpi", .data = &mt8183_conf }, { .compatible = "mediatek,mt8186-dpi", .data = &mt8186_conf }, - { .compatible = "mediatek,mt8188-dp-intf", .data = &mt8188_dpintf_conf }, + { .compatible = "mediatek,mt8188-dp-intf", .data = &mt8195_dpintf_conf }, { .compatible = "mediatek,mt8192-dpi", .data = &mt8192_conf }, { .compatible = "mediatek,mt8195-dp-intf", .data = &mt8195_dpintf_conf }, { /* sentinel */ },
DPI input is in 1T2P mode on both MT8195 and MT8188. Remove the redundant driver data to align the settings, or the screen will glitch. Fixes: 2847cd7e6403 ("drm/mediatek: Add mt8188 dpi compatibles and platform data") Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dpi.c | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-)