clk: imx: imx8: build base support for scu clk

Commit Message

Arnd Bergmann Oct. 9, 2023, 11:44 a.m. UTC

From: Arnd Bergmann <[e-mail]>

There is now a dependency on a function from the clk.c file, so
this also needs to be built:

aarch64-linux-ld: Unexpected GOT/PLT entries detected!
aarch64-linux-ld: Unexpected run-time procedure linkages detected!
aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function `imx8_acm_clk_probe':
clk-imx8-acm.c:(.text+0xbf0): undefined reference to `imx_check_clk_hws'

Fixes: d3a0946d7ac9a ("clk: imx: imx8: add audio clock mux driver")
Signed-off-by: Arnd Bergmann <[e-mail]>
---
 drivers/clk/imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Peng Fan Oct. 9, 2023, 11:48 a.m. UTC | #1

> Subject: [PATCH] clk: imx: imx8: build base support for scu clk
> 
> From: Arnd Bergmann <[e-mail]>
> 
> There is now a dependency on a function from the clk.c file, so this also needs
> to be built:
> 
> aarch64-linux-ld: Unexpected GOT/PLT entries detected!
> aarch64-linux-ld: Unexpected run-time procedure linkages detected!
> aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function
> `imx8_acm_clk_probe':
> clk-imx8-acm.c:(.text+0xbf0): undefined reference to `imx_check_clk_hws'
> 
> Fixes: d3a0946d7ac9a ("clk: imx: imx8: add audio clock mux driver")
> Signed-off-by: Arnd Bergmann <[e-mail]>

Acked-by: Peng Fan <[e-mail]>

Stephen Boyd Oct. 10, 2023, 6:56 p.m. UTC | #2

Quoting Arnd Bergmann (2023-10-09 04:44:55)
> From: Arnd Bergmann <[e-mail]>
> 
> There is now a dependency on a function from the clk.c file, so
> this also needs to be built:
> 
> aarch64-linux-ld: Unexpected GOT/PLT entries detected!
> aarch64-linux-ld: Unexpected run-time procedure linkages detected!
> aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function `imx8_acm_clk_probe':
> clk-imx8-acm.c:(.text+0xbf0): undefined reference to `imx_check_clk_hws'
> 
> Fixes: d3a0946d7ac9a ("clk: imx: imx8: add audio clock mux driver")
> Signed-off-by: Arnd Bergmann <[e-mail]>
> ---

Is this another https://lore.kernel.org/r/[e-mail]

Arnd Bergmann Oct. 10, 2023, 7:26 p.m. UTC | #3

On Tue, Oct 10, 2023, at 20:56, Stephen Boyd wrote:
> Quoting Arnd Bergmann (2023-10-09 04:44:55)
>> From: Arnd Bergmann <[e-mail]>
>> 
>> There is now a dependency on a function from the clk.c file, so
>> this also needs to be built:
>> 
>> aarch64-linux-ld: Unexpected GOT/PLT entries detected!
>> aarch64-linux-ld: Unexpected run-time procedure linkages detected!
>> aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function `imx8_acm_clk_probe':
>> clk-imx8-acm.c:(.text+0xbf0): undefined reference to `imx_check_clk_hws'
>> 
>> Fixes: d3a0946d7ac9a ("clk: imx: imx8: add audio clock mux driver")
>> Signed-off-by: Arnd Bergmann <[e-mail]>
>> ---
>
> Is this another 
> https://lore.kernel.org/r/[e-mail]

I think that's correct and my patch is not needed any more now.
It looks like it was already obsolete when I sent it, but I can't
find out why that is. I'll let you know if it comes back.

     Arnd

Patch

diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index db3bca5f4ec9c..c6d3fda330341 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig
@@ -6,6 +6,7 @@  config MXC_CLK
 
 config MXC_CLK_SCU
 	tristate
+	select MXC_CLK
 
 config CLK_IMX1
 	def_bool SOC_IMX1