| Message ID | 20231013174204.1457085-17-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | pwm: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions | expand |
On Fri, 13 Oct 2023 19:42:09 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to > care about when the functions are actually used, so the corresponding > > Also make use of pm_ptr() to discard all PM related stuff if CONFIG_PM > isn't enabled. > > Acked-by: Florian Fainelli <florian.fainelli@broadcom.com> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Given the bit I commented on in v1 has gone away... Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/pwm/pwm-brcmstb.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/pwm/pwm-brcmstb.c b/drivers/pwm/pwm-brcmstb.c > index b723c2d4f485..0fdeb0b2dbf3 100644 > --- a/drivers/pwm/pwm-brcmstb.c > +++ b/drivers/pwm/pwm-brcmstb.c > @@ -259,7 +259,6 @@ static int brcmstb_pwm_probe(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM_SLEEP > static int brcmstb_pwm_suspend(struct device *dev) > { > struct brcmstb_pwm *p = dev_get_drvdata(dev); > @@ -275,17 +274,16 @@ static int brcmstb_pwm_resume(struct device *dev) > > return clk_prepare_enable(p->clk); > } > -#endif > > -static SIMPLE_DEV_PM_OPS(brcmstb_pwm_pm_ops, brcmstb_pwm_suspend, > - brcmstb_pwm_resume); > +static DEFINE_SIMPLE_DEV_PM_OPS(brcmstb_pwm_pm_ops, brcmstb_pwm_suspend, > + brcmstb_pwm_resume); > > static struct platform_driver brcmstb_pwm_driver = { > .probe = brcmstb_pwm_probe, > .driver = { > .name = "pwm-brcmstb", > .of_match_table = brcmstb_pwm_of_match, > - .pm = &brcmstb_pwm_pm_ops, > + .pm = pm_ptr(&brcmstb_pwm_pm_ops), > }, > }; > module_platform_driver(brcmstb_pwm_driver);
diff --git a/drivers/pwm/pwm-brcmstb.c b/drivers/pwm/pwm-brcmstb.c index b723c2d4f485..0fdeb0b2dbf3 100644 --- a/drivers/pwm/pwm-brcmstb.c +++ b/drivers/pwm/pwm-brcmstb.c @@ -259,7 +259,6 @@ static int brcmstb_pwm_probe(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM_SLEEP static int brcmstb_pwm_suspend(struct device *dev) { struct brcmstb_pwm *p = dev_get_drvdata(dev); @@ -275,17 +274,16 @@ static int brcmstb_pwm_resume(struct device *dev) return clk_prepare_enable(p->clk); } -#endif -static SIMPLE_DEV_PM_OPS(brcmstb_pwm_pm_ops, brcmstb_pwm_suspend, - brcmstb_pwm_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(brcmstb_pwm_pm_ops, brcmstb_pwm_suspend, + brcmstb_pwm_resume); static struct platform_driver brcmstb_pwm_driver = { .probe = brcmstb_pwm_probe, .driver = { .name = "pwm-brcmstb", .of_match_table = brcmstb_pwm_of_match, - .pm = &brcmstb_pwm_pm_ops, + .pm = pm_ptr(&brcmstb_pwm_pm_ops), }, }; module_platform_driver(brcmstb_pwm_driver);