From patchwork Fri Oct 13 21:52:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 13421763 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E088FCDB47E for ; Fri, 13 Oct 2023 21:53:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rDoUSt6MdGEPj9b0ZaZLISHAV30gP5qRe0Uoq7RKfEE=; b=GuXF4W7V6Q1NbQRqBTdmcDgnqY dfELpOc9EYpRk943iIrQiPobJkkwJcoRpZKPJ15/oup6gPPY13Mg3gcE5Gg1CXGpAOPgPBxwagssH udNcsnGH39crWuHrw8fD0YQsnGgpFO+7OVhsdMn3OQSvcylMuqcgSyEtyxzlgi/xaa1FhrwCc5AWU /8Sgj2mbeZs6aArtDNQXtUvEs2+wOscXG6lyNavhjHWqEJXj7Hm7c+Hqe1m78sWxC9c8PI953LJZJ 82sg22iXKxR/i5rVNsy4E5fOZq4TxzfoPqt5YFTu+indEdt0MpaVYi0xO/9kKHEUSm+lH5SUHv96m TMBA1RqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qrQ5k-004Ksm-0b; Fri, 13 Oct 2023 21:53:08 +0000 Received: from mail-yw1-x1134.google.com ([2607:f8b0:4864:20::1134]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qrQ5d-004Kqi-1g for linux-arm-kernel@lists.infradead.org; Fri, 13 Oct 2023 21:53:04 +0000 Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-5a7af20c488so30875017b3.1 for ; Fri, 13 Oct 2023 14:53:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1697233980; x=1697838780; darn=lists.infradead.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=UZU11u+C6MihY/+zILZLY2jSBC9bUVbuvAfMwUbd9KI=; b=fVAX350dOWU30GJ7qJ7RchwPfrQZ4BsmKtXn/FaYUcYhwVH04PzF138yTQoU5pp+4z xtzW7y7/oxhkTN4eSUi/T19y8nwVDIKEoMBPSJNIFz/2wSf7/S7/VOnvAw0TmVjUZUdR gb4EEPNr4T/Zusdpt5mjdRxkVb/YKiBZPFSd8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697233980; x=1697838780; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UZU11u+C6MihY/+zILZLY2jSBC9bUVbuvAfMwUbd9KI=; b=jvEpoQ2sRRprAdrJDuOUFdpD/lQncA0S+UzMA0WSHFogHAlOnhT17RsYbAoUhyVLmk 5LMfWBFQ5kxOx17xlBOGG3pVH1EnD6n7C0KyyP7PWDAaqos16cmuh7BqySYddC3ISzG7 f4tN8zodPcp4nN7MQtESqVuPQDW/0YY5OBbzYWReGf1RW1k/CiFllvPiCJ+MMBmtH/fw JqiGhdMpw3giNSXKdSiIrbVvOkiPSg12Jcm73Kv8zw6vMDZs8tC7OYZFY+gL140ZhMnb HMxa4i8ykHFaNwG5bpw7nwZWXb1c3hNasr3OsV+UyoZBj+n8JaOc1PU+sNl0C0wwHZOl YZQA== X-Gm-Message-State: AOJu0YywSj6GX+8OhCs953SlLre3LtnnKIzMaOi8UsPOXzmWCWqYIXdY 6xBMDwYMw7AwUjJloHkA3wB+qg== X-Google-Smtp-Source: AGHT+IFwY0JFRWZJMFIPMTQeyH7gDfTodpFfH6YtzlkoP8XffE1J5X4FL6mv0SKyn1K8gJXrseUKdQ== X-Received: by 2002:a81:b61d:0:b0:5a7:a81b:d9af with SMTP id u29-20020a81b61d000000b005a7a81bd9afmr14831323ywh.7.1697233980088; Fri, 13 Oct 2023 14:53:00 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y11-20020a0cf14b000000b0066d0621bb67sm1005295qvl.114.2023.10.13.14.52.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 14:52:59 -0700 (PDT) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Broadcom internal kernel review list , linux-kernel@vger.kernel.org (open list:ARM/Mediatek SoC support), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support) Subject: [PATCH net-next v3 2/2] net: dsa: Rename IFLA_DSA_MASTER to IFLA_DSA_CONDUIT Date: Fri, 13 Oct 2023 14:52:51 -0700 Message-Id: <20231013215251.152912-3-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231013215251.152912-1-florian.fainelli@broadcom.com> References: <20231013215251.152912-1-florian.fainelli@broadcom.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231013_145301_563322_AFE5D080 X-CRM114-Status: GOOD ( 21.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This preserves the existing IFLA_DSA_MASTER which is part of the uAPI and creates an alias named IFLA_DSA_CONDUIT. Reviewed-by: Andrew Lunn Signed-off-by: Florian Fainelli --- Documentation/networking/dsa/configuration.rst | 4 ++-- include/uapi/linux/if_link.h | 4 +++- net/dsa/netlink.c | 10 +++++----- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/Documentation/networking/dsa/configuration.rst b/Documentation/networking/dsa/configuration.rst index e6c9719874b0..6cc4ded3cc23 100644 --- a/Documentation/networking/dsa/configuration.rst +++ b/Documentation/networking/dsa/configuration.rst @@ -393,7 +393,7 @@ description which has an ``ethernet`` property. It is up to the user to configure the system for the switch to use other conduits. DSA uses the ``rtnl_link_ops`` mechanism (with a "dsa" ``kind``) to allow -changing the DSA conduit of a user port. The ``IFLA_DSA_MASTER`` u32 netlink +changing the DSA conduit of a user port. The ``IFLA_DSA_CONDUIT`` u32 netlink attribute contains the ifindex of the conduit device that handles each user device. The DSA conduit must be a valid candidate based on firmware node information, or a LAG interface which contains only slaves which are valid @@ -435,7 +435,7 @@ Using iproute2, the following manipulations are possible: dsa master bond0 Notice that in the case of CPU ports under a LAG, the use of the -``IFLA_DSA_MASTER`` netlink attribute is not strictly needed, but rather, DSA +``IFLA_DSA_CONDUIT`` netlink attribute is not strictly needed, but rather, DSA reacts to the ``IFLA_MASTER`` attribute change of its present conduit (``eth0``) and migrates all user ports to the new upper of ``eth0``, ``bond0``. Similarly, when ``bond0`` is destroyed using ``RTM_DELLINK``, DSA migrates the user ports diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index fac351a93aed..30ef80aff033 100644 --- a/include/uapi/linux/if_link.h +++ b/include/uapi/linux/if_link.h @@ -1392,7 +1392,9 @@ enum { enum { IFLA_DSA_UNSPEC, - IFLA_DSA_MASTER, + IFLA_DSA_CONDUIT, + /* Deprecated, use IFLA_DSA_CONDUIT insted */ + IFLA_DSA_MASTER = IFLA_DSA_CONDUIT, __IFLA_DSA_MAX, }; diff --git a/net/dsa/netlink.c b/net/dsa/netlink.c index f56f90a25b99..1332e56349e5 100644 --- a/net/dsa/netlink.c +++ b/net/dsa/netlink.c @@ -8,7 +8,7 @@ #include "user.h" static const struct nla_policy dsa_policy[IFLA_DSA_MAX + 1] = { - [IFLA_DSA_MASTER] = { .type = NLA_U32 }, + [IFLA_DSA_CONDUIT] = { .type = NLA_U32 }, }; static int dsa_changelink(struct net_device *dev, struct nlattr *tb[], @@ -20,8 +20,8 @@ static int dsa_changelink(struct net_device *dev, struct nlattr *tb[], if (!data) return 0; - if (data[IFLA_DSA_MASTER]) { - u32 ifindex = nla_get_u32(data[IFLA_DSA_MASTER]); + if (data[IFLA_DSA_CONDUIT]) { + u32 ifindex = nla_get_u32(data[IFLA_DSA_CONDUIT]); struct net_device *conduit; conduit = __dev_get_by_index(dev_net(dev), ifindex); @@ -38,7 +38,7 @@ static int dsa_changelink(struct net_device *dev, struct nlattr *tb[], static size_t dsa_get_size(const struct net_device *dev) { - return nla_total_size(sizeof(u32)) + /* IFLA_DSA_MASTER */ + return nla_total_size(sizeof(u32)) + /* IFLA_DSA_CONDUIT */ 0; } @@ -46,7 +46,7 @@ static int dsa_fill_info(struct sk_buff *skb, const struct net_device *dev) { struct net_device *conduit = dsa_user_to_conduit(dev); - if (nla_put_u32(skb, IFLA_DSA_MASTER, conduit->ifindex)) + if (nla_put_u32(skb, IFLA_DSA_CONDUIT, conduit->ifindex)) return -EMSGSIZE; return 0;