From patchwork Tue Oct 17 20:44:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13426093 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E05ECDB474 for ; Tue, 17 Oct 2023 20:47:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B1/U471x4UN9ItXUCKUIYxXRBRYaKoWg6GVALOZUudQ=; b=jyo1d2me9cmWZ6 dHYIgSzCwne5ewDeJfi1y3DZlfEwLQBQS3mWBY9p/9v45zh6HzdfgaKHzyzLEbUWhuXq29UHjSTgB wBKo2+QOwmGpPzt3umIKX7tEDJbpyB9tS463D7bjzsAl6rUAetqMbQse4sSq4m22cfX+qFbzyZm1u Di0Pr1P5x/q87PAon66bjBXh5nsZjAS8IPDL/bjDrGC7eQIixEokxip9oIFpWMTrZCjJfDmP9m7SI m6z4RKs4gOOlLsX+06EhMG11qXu+/+VaR9xMjnxgjbOqZxsWtQJ438tNc7YEvoaCUYg7vgWCt8IQZ JPuHmUv3YN2tkZaW93Sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qsqy7-00DEZw-2e; Tue, 17 Oct 2023 20:47:11 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qsqy2-00DEXf-29 for linux-arm-kernel@lists.infradead.org; Tue, 17 Oct 2023 20:47:08 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qsqy0-0001ny-Oy; Tue, 17 Oct 2023 22:47:04 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qsqxz-002OlA-Vg; Tue, 17 Oct 2023 22:47:03 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qsqxz-000U0f-ML; Tue, 17 Oct 2023 22:47:03 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman Cc: Vladimir Zapolskiy , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Arnd Bergmann , linux-kbuild@vger.kernel.org Subject: [PATCH 4/6] usb: gadget: lpc32xx-udc: Convert to use module_platform_driver() Date: Tue, 17 Oct 2023 22:44:47 +0200 Message-ID: <20231017204442.1625925-12-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231017204442.1625925-8-u.kleine-koenig@pengutronix.de> References: <20231017204442.1625925-8-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1436; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=sxbp0y/WRYI7u4m1SNALeJ77zvGjqnu7lZYDt8ktbnI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlLvJD8+ykX40knZvq2p34NQqD/Cl/Mc9/OyrcQ h+PzHXLeOOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZS7yQwAKCRCPgPtYfRL+ Tjb9B/9x6ytRK5v/+YM/jKR3Oj5x7fUF3Gfxfv3y93nqplJOfo37t1K4u0ulkWC7sEuNHRlqsjv 1JrHm6fb3Ti6w6riFm3HG4EVsqqvfCudeLza/4ielz//jBp9yNVLUyHx28lHIi7n8tvN4nZ2wgO wXdcJLStqH+xTWzqtBTIdDL7qAs0xWKq5PfSU7rOTwZTipLWaYwSYY+njuPJECKep8PtMiQ8iC9 DCTCIUiHQRc++edVAxvY2RkJQECIlTzVLwegi5XAzbnRuz5pxBbLN+oz3cijpvst0zy5fDRE7V+ 1ASslSwz6KQe2nd728HVrVGnKIdeIDe8YbmNVJsQ+kpS0GBa X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231017_134706_703368_39E5B80B X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org module_platform_driver_probe() has the advantage that the .probe() and .remove() calls can live in .init.text and .exit.text respectively and so some memory is saved. The downside is that dynamic bind and unbind are impossible. As the driver doesn't benefit from the advantages (both .probe and .remove are defined in plain .text), stop suffering from the downsides and use module_platform_driver() instead of module_platform_driver_probe(). Signed-off-by: Uwe Kleine-König --- drivers/usb/gadget/udc/lpc32xx_udc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c b/drivers/usb/gadget/udc/lpc32xx_udc.c index fe62db32dd0e..a917cc9a32ab 100644 --- a/drivers/usb/gadget/udc/lpc32xx_udc.c +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c @@ -3254,6 +3254,7 @@ MODULE_DEVICE_TABLE(of, lpc32xx_udc_of_match); #endif static struct platform_driver lpc32xx_udc_driver = { + .probe = lpc32xx_udc_probe, .remove = lpc32xx_udc_remove, .shutdown = lpc32xx_udc_shutdown, .suspend = lpc32xx_udc_suspend, @@ -3264,7 +3265,7 @@ static struct platform_driver lpc32xx_udc_driver = { }, }; -module_platform_driver_probe(lpc32xx_udc_driver, lpc32xx_udc_probe); +module_platform_driver(lpc32xx_udc_driver); MODULE_DESCRIPTION("LPC32XX udc driver"); MODULE_AUTHOR("Kevin Wells ");