From patchwork Wed Oct 18 12:35:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 13426992 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A76ECCDB484 for ; Wed, 18 Oct 2023 12:36:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P4kRgfyq9lsa+pHJsbqHRsTJzyNHHQSUdvhaftYD/hc=; b=I45RrK6G0CVh/d zD8sbgyFewyrtLRyCpcxT7dLOZbRGdZCYNBP1XsW0U43y2BVOqBdoZEu1jvr/nnV8y/q9UkwQUeho eVGs5D/lHOANx97VL63eI8fwg5NKCsCLolDi861AawRSS6xciDSfbpDwPxHpnnJyzE5b5ICHwrlVd TrF+zfe/IWNlpZ51EkDqb6xxW7DOXZ9BV21nBtkAClVyaUsx0xBvVL5Tg4kmxtW/VWEpEXZS0Qiff R875FGwTkT7vevYvKWipCnFjUo+BqN6C0X1s5hzm38ylS4tJEHxnyMKj2Xe6EU0l/10MBhOTEq/Yj VlkcVe0ThQaZ+MCJMQ0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qt5mV-00EfjN-1t; Wed, 18 Oct 2023 12:36:11 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qt5mP-00Efdw-0j for linux-arm-kernel@lists.infradead.org; Wed, 18 Oct 2023 12:36:06 +0000 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-32d9d8284abso4347954f8f.3 for ; Wed, 18 Oct 2023 05:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697632562; x=1698237362; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SSAhxNCccBDPfEaHOYwSm94ZHYVqbuNn4mUPNvHQg0g=; b=CQehzggS3ib1j6kbsg8WdZfeToi7r5YmCHn0Z1/yehZT46tKeOMK4zKxHL2z7fJNel vKuZHWtimZwNjA/2RSGTR2A7HvQOSf45ujk8Je983gziR/tClGuLLI1cWaogPAmTewJQ ARyD6Nixanq2xL3BefgWhZ1wkQlFW8k+H/OBMtHIDpj9N1rXwOyIcTyv++A+mt1aLzv+ HPK32mk20n5xzT784kkIOzFCy4tbhGMGsobnakdGlU6E/L1eenXa7DFy7jpIlhl7YJik ayLyCxE1+x8Qc7qAksQ4bdyX2+SAGMqbEv9sWRyQFDyt3IVM6VZNZBu1G6EOHlTLRKPZ oKRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697632562; x=1698237362; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SSAhxNCccBDPfEaHOYwSm94ZHYVqbuNn4mUPNvHQg0g=; b=frHPlk1a5xZavAYmVlh7yS+8mscAJ/kItfzpQNACH5YWLixmyqJerPHWzxC/x8qT61 k/tgWyCzSjNuHZADFM3eIQ7MpCTpVvrKwSSkvFxU49QXT4Ft/dtErV1697fkMUzANFk6 5nT3a++5M/tJ5uelUT9gN6/jcGUgRMOP1AD6t+lb85+yoTkb3L4x8MPBqk8K0VgkAE4e Th5jVefTw+CcGZDhQLhYSiDrOf9mcNLOACRLVsYNUWbwyEeBGGw913aojBu9DHtX6heU h78Da2rtO8trJFsyMJIEmm1bAwYiFkPkuje16ffnAWcQ2FsmbxhJ9Ivr53qv0LGQRLb0 ZGZg== X-Gm-Message-State: AOJu0Yx5wZ7+Jv00eRsEHWvU1TUXLwPgvrnIrr2K5hFlVb0u1sMlvulJ Jgk7H6obMbuBu1Eb2tR7F5E= X-Google-Smtp-Source: AGHT+IFEKMKg55GmM1zKHZcYfYfsUWrXoXfEZKLoyDe07dO2uoRsG8MlML19lGyIoctSD/nE3A+OCg== X-Received: by 2002:a5d:680d:0:b0:32c:d0e0:3e70 with SMTP id w13-20020a5d680d000000b0032cd0e03e70mr4069642wru.56.1697632562231; Wed, 18 Oct 2023 05:36:02 -0700 (PDT) Received: from localhost.localdomain (93-34-89-13.ip49.fastwebnet.it. [93.34.89.13]) by smtp.googlemail.com with ESMTPSA id q28-20020adfab1c000000b003248a490e3asm2048211wrc.39.2023.10.18.05.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 05:36:01 -0700 (PDT) From: Christian Marangi To: Raju Rangoju , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Ping-Ke Shih , Kalle Valo , Simon Horman , Daniel Borkmann , Jiri Pirko , Hangbin Liu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-wireless@vger.kernel.org Cc: Christian Marangi Subject: [net-next PATCH v4 4/4] net: stmmac: increase TX coalesce timer to 5ms Date: Wed, 18 Oct 2023 14:35:50 +0200 Message-Id: <20231018123550.27110-5-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231018123550.27110-1-ansuelsmth@gmail.com> References: <20231018123550.27110-1-ansuelsmth@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231018_053605_272540_CFC4C227 X-CRM114-Status: GOOD ( 15.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 8fce33317023 ("net: stmmac: Rework coalesce timer and fix multi-queue races") decreased the TX coalesce timer from 40ms to 1ms. This caused some performance regression on some target (regression was reported at least on ipq806x) in the order of 600mbps dropping from gigabit handling to only 200mbps. The problem was identified in the TX timer getting armed too much time. While this was fixed and improved in another commit, performance can be improved even further by increasing the timer delay a bit moving from 1ms to 5ms. The value is a good balance between battery saving by prevending too much interrupt to be generated and permitting good performance for internet oriented devices. Signed-off-by: Christian Marangi --- drivers/net/ethernet/stmicro/stmmac/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/common.h b/drivers/net/ethernet/stmicro/stmmac/common.h index 1e996c29043d..e3f650e88f82 100644 --- a/drivers/net/ethernet/stmicro/stmmac/common.h +++ b/drivers/net/ethernet/stmicro/stmmac/common.h @@ -293,7 +293,7 @@ struct stmmac_safety_stats { #define MIN_DMA_RIWT 0x10 #define DEF_DMA_RIWT 0xa0 /* Tx coalesce parameters */ -#define STMMAC_COAL_TX_TIMER 1000 +#define STMMAC_COAL_TX_TIMER 5000 #define STMMAC_MAX_COAL_TX_TICK 100000 #define STMMAC_TX_MAX_FRAMES 256 #define STMMAC_TX_FRAMES 25