From patchwork Thu Oct 19 09:01:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13428501 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 860A4CDB465 for ; Thu, 19 Oct 2023 09:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/QnuNkAHMKVAzuh6hU4ptEnObpxJkH531+gGByleQTI=; b=D3qcvpAuTdIhF8 RZdu4IFFgKNDgN9mGsKJbS9y47CdiQj491kS2UaOTmH1wIPjMk4Ul3HRNBtZdlEWjWtCCEuETGMiY YV/I3OFMv9jQRtz4q8b5r+OO8m9SimTamvy/nV5YtFJq02JQBlfWZ/Tod36i+auOk6B3GJ7kDTXCs 6AHTDC2XmMXf3mWpVvMbY7OIy8Ku8FacAgJje2DvWyjUofMv98JIDXVMDJFztV2Ecc3vFpD4n/kdX mSht5WaQekNQgqiwS+xa6HePGYKanA7V8XAj2GlLxFMg7n3Cmyf4Mxxu44Q9DQU4VH3pGpFtLl+3l AVW13MfhB1IwWNobzcHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtOup-00GnCO-1D; Thu, 19 Oct 2023 09:02:03 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtOug-00Gn9z-0Y; Thu, 19 Oct 2023 09:01:55 +0000 Received: from umang.jainideasonboard.com (unknown [103.251.226.1]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E3C06276; Thu, 19 Oct 2023 11:01:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1697706105; bh=0LdC8+GAY6U97gZ4OULmQjk1G/wf/jcpQbWa7v6paPw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vj9Qqk+pN56pV/YrmMjvSVJGUMYlp/0VGxs58NMXJwe+30ogcT2iZ8mksbY9sLP2l fDfqFtOcA48Y19y9NNEVsTkHvITVMJiJ24Kg4/ThFfzRY7maAcG+0sf8EizKw9k9Fg 5cMhFrHsjCM04vPQjQSHE9G42rUZV2MKkvoAXirY= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Umang Jain Subject: [PATCH v3 3/3] staging: vc04_services: bcm2835-camera: Drop MODULE_ALIAS Date: Thu, 19 Oct 2023 14:31:28 +0530 Message-Id: <20231019090128.430297-4-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231019090128.430297-1-umang.jain@ideasonboard.com> References: <20231019090128.430297-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231019_020154_353127_E752A0B4 X-CRM114-Status: UNSURE ( 9.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Drop MODULE_ALIAS in favour of MODULE_DEVICE_TABLE as the module alias should be picked from there. Signed-off-by: Umang Jain Reviewed-by: Laurent Pinchart --- .../staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c index c873eace1437..e860fb89d42e 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c +++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c @@ -1995,9 +1995,16 @@ static void bcm2835_mmal_remove(struct vchiq_device *device) vchiq_mmal_finalise(instance); } +static const struct vchiq_device_id device_id_table[] = { + { .name = "bcm2835-camera" }, + {} +}; +MODULE_DEVICE_TABLE(vchiq, device_id_table); + static struct vchiq_driver bcm2835_camera_driver = { .probe = bcm2835_mmal_probe, .remove = bcm2835_mmal_remove, + .id_table = device_id_table, .driver = { .name = "bcm2835-camera", }, @@ -2008,4 +2015,3 @@ module_vchiq_driver(bcm2835_camera_driver) MODULE_DESCRIPTION("Broadcom 2835 MMAL video capture"); MODULE_AUTHOR("Vincent Sanders"); MODULE_LICENSE("GPL"); -MODULE_ALIAS("bcm2835-camera");