From patchwork Thu Oct 19 20:07:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13429784 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED6DFCDB483 for ; Thu, 19 Oct 2023 20:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kFPYiJeTxEfoMPWozJPFj75513tpqy0aiSgMKx+GVdQ=; b=0QMnUSEMZsQ/XJ HhURpY//bkXbZ0boNPUcCk+QdAvd8HIiBF7GBBtwZb7N7y2QP0kMDX1TOdKTZEdodHZ0YB5sNysc3 /gt/9ADlz6zg4mYtfRymL4RxtKrq6xWsoz6WZRJw7jQfSsppTt+2SK74YUz3AWN4kTCsORV8clzMu s3xVTIkQEM9yg0VAdmLQ4+w6JxPREpoEe58Zc2g55nRMoIXclP3Hs1G0LTy9ZvS3xIv4rbggDzr1f 877+xPsss0VR2DwzwZJS7H6kLl/b8i9EbsJcEoXeP0kYYkDWH+xQt8bU5o8iBQMeUz9tiMwz0/nCC OBxyXjx7rgUmmroYsuIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtZJU-000eLB-20; Thu, 19 Oct 2023 20:08:12 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtZJI-000eI7-02 for linux-arm-kernel@lists.infradead.org; Thu, 19 Oct 2023 20:08:01 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qtZJ6-0000Aj-V6; Thu, 19 Oct 2023 22:07:48 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qtZJ6-002rfy-4z; Thu, 19 Oct 2023 22:07:48 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qtZJ5-001veL-Rn; Thu, 19 Oct 2023 22:07:47 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding Cc: Philipp Zabel , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 3/5] pwm: stm32: Use hweight32 in stm32_pwm_detect_channels Date: Thu, 19 Oct 2023 22:07:02 +0200 Message-ID: <20231019200658.1754190-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231019200658.1754190-7-u.kleine-koenig@pengutronix.de> References: <20231019200658.1754190-7-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1453; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=uyweP2aIcsRVvk3AtSYYRpvNOEu9/0+LfIDkqZDP1tI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlMYxl8jmcvHhowW1afeBxXdq95JiaMVza0c+Hn nJbhQ/YMSWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZTGMZQAKCRCPgPtYfRL+ Tk2WB/92MjgFC+qqLG5grNnjGFrJqjVg5me4tFTahRFqRZSDJaGHMqHClECOa7DxekoL7PfjvG4 hwbYWcM8YUlbwZ+6nkOAcyZ1Z4IU/SIZz7fZnuXbxOBft033flkVaqQk5brsw6CKQayzp73oXWx Z3dMmeW7HmOOWoypsnAoVt/OhfMdht/1zQZWAVeA16YHG5uXN96yWP1q4ZhZAqvqs2+J6E3mQW5 c4TQ+HiglsyP2uvXrVNLFk0ZPPf/kAsGw5cwsvZ7WfvirG4NKPmnht8ZOni8oub1XIuI/10rNfX 4qMOP2yhbxov/zxDBgaKfSi15UQuCZPG3RSXhIOEBxXH0g5x X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231019_130800_051322_54B4C3A8 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Philipp Zabel Use hweight32() to count the CCxE bits in stm32_pwm_detect_channels(). Since the return value is assigned to chip.npwm, change it to unsigned int as well. Signed-off-by: Philipp Zabel Signed-off-by: Uwe Kleine-König Reviewed-by: Fabrice Gasnier --- drivers/pwm/pwm-stm32.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c index 009f9c1a5eca..cc6cae07c02c 100644 --- a/drivers/pwm/pwm-stm32.c +++ b/drivers/pwm/pwm-stm32.c @@ -563,10 +563,9 @@ static void stm32_pwm_detect_complementary(struct stm32_pwm *priv) priv->have_complementary_output = (ccer != 0); } -static int stm32_pwm_detect_channels(struct stm32_pwm *priv) +static unsigned int stm32_pwm_detect_channels(struct stm32_pwm *priv) { u32 ccer; - int npwm = 0; /* * If channels enable bits don't exist writing 1 will have no @@ -576,19 +575,7 @@ static int stm32_pwm_detect_channels(struct stm32_pwm *priv) regmap_read(priv->regmap, TIM_CCER, &ccer); regmap_clear_bits(priv->regmap, TIM_CCER, TIM_CCER_CCXE); - if (ccer & TIM_CCER_CC1E) - npwm++; - - if (ccer & TIM_CCER_CC2E) - npwm++; - - if (ccer & TIM_CCER_CC3E) - npwm++; - - if (ccer & TIM_CCER_CC4E) - npwm++; - - return npwm; + return hweight32(ccer & TIM_CCER_CCXE); } static int stm32_pwm_probe(struct platform_device *pdev)