From patchwork Fri Oct 20 07:55:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13430186 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED590C07480 for ; Fri, 20 Oct 2023 07:57:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z+boIBNTom1/mAOgyUlE7M6/6KNp3MfmpeGIY7Jjt5g=; b=kYFXXXS63JETCj qk1L3rMl2svdzmuv8netEGgHFd8zrJFsY1Zzj0A7qzApDunZLNEuAof9mArVtxzgT8QTzvUNF5q2t ew1yueSX0Hc/WWtihohNtlEIjZHVcnyMOFF8MBoSNywx2g1jTQUkKO7EsV5F3BQLJdLpVKSbrZaQ4 rMkfSf2P5Si7u0GoK80dfd1Sa3XJd5R6pKGQQ3q3Q5apPmtbFmTm4f51BZt8+iOVvBB3ClfBRWehp SwlykZlpwQe5c1dxkd1q4wxFA8NAAau2UjmvDrQTeG+V7Z7kOfSCqBUa/NsU32N7Pwg7hfILqkyDR aAx7K9ka/Dy/rwWX7mZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtkNF-001UGe-2f; Fri, 20 Oct 2023 07:56:49 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtkN8-001UBk-02 for linux-arm-kernel@lists.infradead.org; Fri, 20 Oct 2023 07:56:43 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qtkMz-0003Gr-IJ; Fri, 20 Oct 2023 09:56:33 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qtkMz-002yUX-5Q; Fri, 20 Oct 2023 09:56:33 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qtkMy-002OIn-SK; Fri, 20 Oct 2023 09:56:32 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Herbert Xu , "David S. Miller" Subject: [PATCH 10/42] crypto: atmel-tdes - Convert to platform remove callback returning void Date: Fri, 20 Oct 2023 09:55:32 +0200 Message-ID: <20231020075521.2121571-54-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231020075521.2121571-44-u.kleine-koenig@pengutronix.de> References: <20231020075521.2121571-44-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1758; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=t+zZKF/41Pj8NMywr8APo/EkmnfD4TbA5Py4GmYqBb0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlMjJ1UaIojh+TPeL0s6oCgZLQXSnzxlS5/leo5 9crqTgUZRiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZTIydQAKCRCPgPtYfRL+ Tu0UB/9woJisdyYJBaNEYFOvHk+plPkoaERjrwAgYCgfR66po9nEO6WEfjW/KsPzb9bzv1qPhxE 5c/9j5TIgoMTL/pb+mJoaKAUwEapFYRBjjEX8YJFc7aUPgjq/Eei7XrruH5cyhDLaKlmMGzKZCd q1XuUmzJSNFAwWmDOzlLfijEvYQSJgvxe8glmA7C1Tw5ButatJGndx08FXn0G9OBPJfzUAOho2r 2k3ml3n4SK5u+bhnUrdVgF99Ldsimv250W5/haTEWFo719x04tkh1RtfBzrmKG3EDXH8IiUpsaC hvSHhdc10DUD0g+JxS2qQZAzZGw6fOQ1et1+vS4H1wQLESVo X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231020_005642_075663_A11A1144 X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Claudiu Beznea , linux-crypto@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/crypto/atmel-tdes.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c index 099b32a10dd7..27b7000e25bc 100644 --- a/drivers/crypto/atmel-tdes.c +++ b/drivers/crypto/atmel-tdes.c @@ -1246,7 +1246,7 @@ static int atmel_tdes_probe(struct platform_device *pdev) return err; } -static int atmel_tdes_remove(struct platform_device *pdev) +static void atmel_tdes_remove(struct platform_device *pdev) { struct atmel_tdes_dev *tdes_dd = platform_get_drvdata(pdev); @@ -1263,13 +1263,11 @@ static int atmel_tdes_remove(struct platform_device *pdev) atmel_tdes_dma_cleanup(tdes_dd); atmel_tdes_buff_cleanup(tdes_dd); - - return 0; } static struct platform_driver atmel_tdes_driver = { .probe = atmel_tdes_probe, - .remove = atmel_tdes_remove, + .remove_new = atmel_tdes_remove, .driver = { .name = "atmel_tdes", .of_match_table = atmel_tdes_dt_ids,