| Message ID | 20231023-display-support-v5-1-3905f1e4b835@baylibre.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add display support for the MT8365-EVK board | expand |
On Wed, 08 Jan 2025 17:15:43 +0100, amergnat@baylibre.com wrote: > From: Fabien Parent <fparent@baylibre.com> > > DPI is part of the display / multimedia block in MediaTek SoCs, and > always have a power-domain (at least in the upstream device-trees). > Add the power-domains property to the binding documentation. > > Fixes: 9273cf7d3942 ("dt-bindings: display: mediatek: convert the dpi bindings to yaml") > Signed-off-by: Fabien Parent <fparent@baylibre.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Acked-by: Rob Herring (Arm) <robh@kernel.org> > Reviewed-by: CK Hu <ck.hu@mediatek.com> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml:100:3: [error] duplication of key "power-domains" in mapping (key-duplicates) dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml: ignoring, error parsing file ./Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml:100:3: found duplicate key "power-domains" with value "{}" (original value: "{}") make[2]: *** Deleting file 'Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.example.dts' Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml:100:3: found duplicate key "power-domains" with value "{}" (original value: "{}") make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.example.dts] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2 make: *** [Makefile:251: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231023-display-support-v5-1-3905f1e4b835@baylibre.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml index 0f1e556dc8ef..d3c4942df58f 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml @@ -97,6 +97,9 @@ properties: - port@0 - port@1 + power-domains: + maxItems: 1 + required: - compatible - reg @@ -116,11 +119,13 @@ examples: - | #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/clock/mt8173-clk.h> + #include <dt-bindings/power/mt8173-power.h> dpi: dpi@1401d000 { compatible = "mediatek,mt8173-dpi"; reg = <0x1401d000 0x1000>; interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>; + power-domains = <&spm MT8173_POWER_DOMAIN_MM>; clocks = <&mmsys CLK_MM_DPI_PIXEL>, <&mmsys CLK_MM_DPI_ENGINE>, <&apmixedsys CLK_APMIXED_TVDPLL>;