From patchwork Mon Oct 23 17:46:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13433274 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6B1CC25B47 for ; Mon, 23 Oct 2023 17:47:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GsVV2kT8pPbk6+PUEb720dHqUipE9OnDjpb3bD0IB40=; b=xODolqIlhrkHBa ixw0TLrJ5tZfIsJuNRmeEwhLvZNM9bCbidqkw08apAGtzJG1FOW6htrQ8qDar3itIwUDWXg2nwLxX uMXGXwcTVc5u/QJ6p+oEUuhXZqNVA9HbmBQmRZqjyx57erEr8T7Vctule8Qrz6FnvX7pBgH+7dFpa ZuvcInJXjjK/XnDRr5DWtao+7w8xGUkVgWVdwuR2LpNTORpO1+ZyJSHhTnFkdqUmTwlMWxAhHyL8i NdkW/AetEg0K54AjPdb32meWfcQhiCux9qN3E31jp8stFHmXg60eZfztolS7TsKX1o84MpyJfoSRV KPV/xrcX9DrDsXJq2OgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1quz18-0080Ai-2Z; Mon, 23 Oct 2023 17:47:06 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1quz0t-00805E-2N for linux-arm-kernel@lists.infradead.org; Mon, 23 Oct 2023 17:46:53 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1quz0p-0001NZ-VI; Mon, 23 Oct 2023 19:46:47 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1quz0p-003lPv-Ho; Mon, 23 Oct 2023 19:46:47 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1quz0p-004VDO-8T; Mon, 23 Oct 2023 19:46:47 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding Cc: Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Jonathan Cameron Subject: [PATCH v3 09/11] pwm: stm32: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions Date: Mon, 23 Oct 2023 19:46:26 +0200 Message-ID: <20231023174616.2282067-22-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231023174616.2282067-13-u.kleine-koenig@pengutronix.de> References: <20231023174616.2282067-13-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1966; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=8LOtNenmZF8wkliwgTRGuRDknwBK+eJm9E5HUGBysKU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlNrFy1hWc33CRR/2b76E9SKmrA340sicAvYfa4 67mDAktmeCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZTaxcgAKCRCPgPtYfRL+ TkEYB/4k1mSfQC/yE61Yg3z1w6mZz0BcLElVa6wRMOaTFthbs2hM2gog9E7rYE/UCne1gIB2IZ2 b55bpjf/DsR635kfrre98SGG8uSIo68GhTPNYId62cW8gf0iYQqJc6Kjn40sKZ49RVEqBG+8VWJ avv43TynuqvRkFh1lDrbZl2326to99SFgrtmiy0mf1rNes/xgWYoXITYP6844cYnt+dkvqPxi62 YewNYUHuF61Q1UwbOZ7Pnj5om2S4tKogVMF7KRfSbdmnTOEyR4kzpBjj1e445m+sI5rTTfLkgf9 k50UcBgoCG7KWw+miFMajhsZz7cO5FEp9Hw0dD3mlj31WDWo X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231023_104651_789237_E29A73ED X-CRM114-Status: GOOD ( 14.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to care about when the functions are actually used, so the corresponding __maybe_unused can be dropped. Also make use of pm_ptr() to discard all PM related stuff if CONFIG_PM isn't enabled. Reviewed-by: Jonathan Cameron Signed-off-by: Uwe Kleine-König Reviewed-by: Fabrice Gasnier --- drivers/pwm/pwm-stm32.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c index 3303a754ea02..8be037757b8b 100644 --- a/drivers/pwm/pwm-stm32.c +++ b/drivers/pwm/pwm-stm32.c @@ -645,7 +645,7 @@ static int stm32_pwm_probe(struct platform_device *pdev) return 0; } -static int __maybe_unused stm32_pwm_suspend(struct device *dev) +static int stm32_pwm_suspend(struct device *dev) { struct stm32_pwm *priv = dev_get_drvdata(dev); unsigned int i; @@ -666,7 +666,7 @@ static int __maybe_unused stm32_pwm_suspend(struct device *dev) return pinctrl_pm_select_sleep_state(dev); } -static int __maybe_unused stm32_pwm_resume(struct device *dev) +static int stm32_pwm_resume(struct device *dev) { struct stm32_pwm *priv = dev_get_drvdata(dev); int ret; @@ -679,7 +679,7 @@ static int __maybe_unused stm32_pwm_resume(struct device *dev) return stm32_pwm_apply_breakinputs(priv); } -static SIMPLE_DEV_PM_OPS(stm32_pwm_pm_ops, stm32_pwm_suspend, stm32_pwm_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(stm32_pwm_pm_ops, stm32_pwm_suspend, stm32_pwm_resume); static const struct of_device_id stm32_pwm_of_match[] = { { .compatible = "st,stm32-pwm", }, @@ -692,7 +692,7 @@ static struct platform_driver stm32_pwm_driver = { .driver = { .name = "stm32-pwm", .of_match_table = stm32_pwm_of_match, - .pm = &stm32_pwm_pm_ops, + .pm = pm_ptr(&stm32_pwm_pm_ops), }, }; module_platform_driver(stm32_pwm_driver);