| Message ID | 20231024105715.2369638-1-sudeep.holla@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | firmware: arm_ffa: Declare ffa_bus_type structure in the header | expand |
On Tue, 24 Oct 2023 11:57:15 +0100, Sudeep Holla wrote: > smatch reports: > drivers/firmware/arm_ffa/bus.c:108:17: warning: > symbol 'ffa_bus_type' was not declared. Should it be static? > > ffa_bus_type is exported to be useful in the FF-A driver. So this > warning is not correct. However, declaring the ffa_bus_type structure > in the header like many other bus_types do already removes this warning. > So let us just do the same and get rid of the warning. > > [...] Applied to sudeep.holla/linux (for-next/ffa/fixes), thanks! [1/1] firmware: arm_ffa: Declare ffa_bus_type structure in the header https://git.kernel.org/sudeep.holla/c/3fad96e9b21b -- Regards, Sudeep
diff --git a/include/linux/arm_ffa.h b/include/linux/arm_ffa.h index 1abedb5b2e48..3d0fde57ba90 100644 --- a/include/linux/arm_ffa.h +++ b/include/linux/arm_ffa.h @@ -209,6 +209,8 @@ bool ffa_device_is_valid(struct ffa_device *ffa_dev) { return false; } #define module_ffa_driver(__ffa_driver) \ module_driver(__ffa_driver, ffa_register, ffa_unregister) +extern struct bus_type ffa_bus_type; + /* FFA transport related */ struct ffa_partition_info { u16 id;
smatch reports: drivers/firmware/arm_ffa/bus.c:108:17: warning: symbol 'ffa_bus_type' was not declared. Should it be static? ffa_bus_type is exported to be useful in the FF-A driver. So this warning is not correct. However, declaring the ffa_bus_type structure in the header like many other bus_types do already removes this warning. So let us just do the same and get rid of the warning. Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- include/linux/arm_ffa.h | 2 ++ 1 file changed, 2 insertions(+)