| Message ID | 20231027020703.1231875-1-suhui@nfschina.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: aspeed: lpc: Fix impossible judgment condition | expand |
On Fri, Oct 27, 2023 at 10:07:04AM +0800, Su Hui wrote: > smatch error： > drivers/soc/aspeed/aspeed-lpc-snoop.c:169 > aspeed_lpc_snoop_config_irq() warn: platform_get_irq() does not return zero > > platform_get_irq() return non-zero IRQ number or negative error code, > change '!lpc_snoop->irq' to 'lpc_snoop->irq < 0' to fix this. > > Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver") > Signed-off-by: Su Hui <suhui@nfschina.com> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> regards, dan carpenter
On Fri, Oct 27, 2023 at 10:07:04AM +0800, Su Hui wrote: > smatch error： > drivers/soc/aspeed/aspeed-lpc-snoop.c:169 > aspeed_lpc_snoop_config_irq() warn: platform_get_irq() does not return zero > > platform_get_irq() return non-zero IRQ number or negative error code, > change '!lpc_snoop->irq' to 'lpc_snoop->irq < 0' to fix this. > > Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver") > Signed-off-by: Su Hui <suhui@nfschina.com> > --- > drivers/soc/aspeed/aspeed-lpc-snoop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c index 773dbcbc03a6..8cb3a0b4692c 100644 --- a/drivers/soc/aspeed/aspeed-lpc-snoop.c +++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c @@ -166,7 +166,7 @@ static int aspeed_lpc_snoop_config_irq(struct aspeed_lpc_snoop *lpc_snoop, int rc; lpc_snoop->irq = platform_get_irq(pdev, 0); - if (!lpc_snoop->irq) + if (lpc_snoop->irq < 0) return -ENODEV; rc = devm_request_irq(dev, lpc_snoop->irq,
smatch error： drivers/soc/aspeed/aspeed-lpc-snoop.c:169 aspeed_lpc_snoop_config_irq() warn: platform_get_irq() does not return zero platform_get_irq() return non-zero IRQ number or negative error code, change '!lpc_snoop->irq' to 'lpc_snoop->irq < 0' to fix this. Fixes: 9f4f9ae81d0a ("drivers/misc: add Aspeed LPC snoop driver") Signed-off-by: Su Hui <suhui@nfschina.com> --- drivers/soc/aspeed/aspeed-lpc-snoop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)