diff mbox series

ARM: dts: imx6q: skov: fix ethernet clock regression

Message ID 20231101-v6-6-topic-imx6q-dt-v1-1-274f6c13c7d5@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series ARM: dts: imx6q: skov: fix ethernet clock regression | expand

Commit Message

Stefan Kerkmann via B4 Relay Nov. 1, 2023, 11:03 a.m. UTC 
From: Stefan Kerkmann <s.kerkmann@pengutronix.de>

A regression was introduced in the Skov specific i.MX6 flavor
reve-mi1010ait-1cp1 device tree causing the external ethernet controller
to not being selected as the clock source for the i.MX6 ethernet MAC,
resulting in a none functional ethernet interface. The root cause is
that the ethernet clock selection is now part of the clocks node, which
is overwritten in the specific device tree and wasn't updated to contain
these ethernet clocks.

Fixes: c89614079e44 ("ARM: dts: imx6qdl-skov-cpu: configure ethernet reference clock parent")
Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
---
This patch fixes a small regression in the device tree for the Skov
specific i.MX6 flavor reve-mi1010ait-1cp1 which caused a none functional
ethernet interface.
---
 arch/arm/boot/dts/nxp/imx/imx6q-skov-reve-mi1010ait-1cp1.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


---
base-commit: 05d3ef8bba77c1b5f98d941d8b2d4aeab8118ef1
change-id: 20231101-v6-6-topic-imx6q-dt-2a006e4a50f2

Best regards,

Comments

Shawn Guo Nov. 27, 2023, 3:25 a.m. UTC | #1 
On Wed, Nov 01, 2023 at 12:03:37PM +0100, Stefan Kerkmann via B4 Relay wrote:
> From: Stefan Kerkmann <s.kerkmann@pengutronix.de>
> 
> A regression was introduced in the Skov specific i.MX6 flavor
> reve-mi1010ait-1cp1 device tree causing the external ethernet controller
> to not being selected as the clock source for the i.MX6 ethernet MAC,
> resulting in a none functional ethernet interface. The root cause is
> that the ethernet clock selection is now part of the clocks node, which
> is overwritten in the specific device tree and wasn't updated to contain
> these ethernet clocks.
> 
> Fixes: c89614079e44 ("ARM: dts: imx6qdl-skov-cpu: configure ethernet reference clock parent")
> Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/imx/imx6q-skov-reve-mi1010ait-1cp1.dts b/arch/arm/boot/dts/nxp/imx/imx6q-skov-reve-mi1010ait-1cp1.dts
index a3f247c722b4..0342a79ccd5d 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6q-skov-reve-mi1010ait-1cp1.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6q-skov-reve-mi1010ait-1cp1.dts
@@ -37,9 +37,9 @@  panel_in: endpoint {
 
 &clks {
 	assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>,
-			  <&clks IMX6QDL_CLK_LDB_DI1_SEL>;
+			  <&clks IMX6QDL_CLK_LDB_DI1_SEL>, <&clks IMX6QDL_CLK_ENET_REF_SEL>;
 	assigned-clock-parents = <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>,
-				 <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>;
+				 <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>, <&clk50m_phy>;
 };
 
 &hdmi {