From patchwork Wed Nov 1 00:25:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13442428 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CEACC00142 for ; Wed, 1 Nov 2023 00:26:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ry4MMQIH4Jgg6fJohJzv9/th6WPtXA192xON6ixY5RU=; b=BXqMVfWvTpuvu8 bTkkYRVAX1eHnzzUhDONMdi7w7sCP5+FZ5RgS8GJvg2GmRRdCuZKMQkgpNJ4YjUpNmarlA6Pxj0hM 5gjbCWWcEvKUEmeYj6kLbaehzAQuOXE1xkSuP/FPqLFrXOn4dpQVd5J0xHo5346GSVTGTHdc/UyWY y0t1wo5aFOuFGZlWG+lg6jQXVTalpZh1nHfrUNP4XFqvI4zcP8N1tb28EvBuQjFhzyY+BiZeXqmuZ SOiHac4B4o9y5LkkuZlJ+AOOoNT5AWA+Ikmjo19yN7jctdQAndNeQ72eQyKRjmYh+hViBchQ0447E 22Jex5SH1VoKJb8wFAbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qxz3y-006OIc-2G; Wed, 01 Nov 2023 00:26:26 +0000 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qxz3v-006OFO-38 for linux-arm-kernel@lists.infradead.org; Wed, 01 Nov 2023 00:26:25 +0000 Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-7a6acc8e222so219690039f.0 for ; Tue, 31 Oct 2023 17:26:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698798381; x=1699403181; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1C+2NMg1JH09l8lpRwB0Ubzh+mfktnl5vVkwETAlRt8=; b=aCLC01PzbSz+4/zO7vBer5IYf+ggxoXOu6FFjsaA8XAZAdd/bW1i9mErpLd3alZEb2 vNlv9M8eTrxVcJJ+M0zmvAhjw4I+CrX5pF7Dv2RP984bjCZNyHhTTNIk6E89EvC/SZFr aK282Yox7Tur+MjeOdus1218EGd7rymW4Ez8wbteDJ87vwFJ5KUam1b/QcEQxm11JrUB 7KKsREqBujdF49Dmu3XpTSSFn2mhOOGU35cs7y0QkMa+B/C/saxxhPpQrsS9+T7KICWX ZG+MqDMajTE0lT5O+DUNUolNfp8KAcj3mXgLadnAZCgw0mAgzp9jbqPRGqysR8jqrbnY HtTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698798381; x=1699403181; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1C+2NMg1JH09l8lpRwB0Ubzh+mfktnl5vVkwETAlRt8=; b=vvWA9SdHRNV2ryyHBSDP1rIF+JdgkxepbI636iUJbCyoGMwOB8A/AA/YAIDAKYhEJo FCMjEuutfXpx5Y8jIC5X2T5lq8JCI86Gc3/0JMUY77H6ydhGRRt5pYKohS+ZFT9lbgoR pOd1PXYHmYtMKRfBqsvUoIjAfJxPnRE5Ya4bSkB6RAkeYlU+Of300w9cll1XtQt9hLgh xE47dusY7ARmy07GGL4T6HzKLs4ZyAUnAMf5m7rprT49gPDQGiRIzM1INCpsvxyhldns d1mLCL91lB9SXV39GaE68Weq7RkVMH+Igetdb5qd4EEv0eAT4OymiUa2B1xXWmqo8y8V 1JjA== X-Gm-Message-State: AOJu0Yza5mpyuTOuQt0y4M/RjXtw1ozio1x+tnksW0VsBlgno5VWVD5q g9cmrgChUnjnFiKaLUu435U= X-Google-Smtp-Source: AGHT+IHkBAKd0v4sabAiwOZ6Frg7FF4WYiVc4qinzWmOuYCNDVvs+YpA63Dkxm+3LAL7oJXh0CcdwQ== X-Received: by 2002:a92:c244:0:b0:357:f730:cc4c with SMTP id k4-20020a92c244000000b00357f730cc4cmr17966574ilo.6.1698798381342; Tue, 31 Oct 2023 17:26:21 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id t1-20020a92c901000000b00357cc8df1d5sm141701ilp.68.2023.10.31.17.26.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 17:26:21 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: lb@semihalf.com, linux@rasmusvillemoes.dk, joe@perches.com, mcgrof@kernel.org, daniel.vetter@ffwll.ch, jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, robdclark@gmail.com, groeck@google.com, yanivt@google.com, bleung@google.com, linux-doc@vger.kernel.org, quic_saipraka@quicinc.com, will@kernel.org, catalin.marinas@arm.com, quic_psodagud@quicinc.com, maz@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, mingo@redhat.com, jim.cromie@gmail.com Subject: [PATCH v7d 03/23] dyndbg: make ddebug_class_param union members same size Date: Tue, 31 Oct 2023 18:25:49 -0600 Message-ID: <20231101002609.3533731-4-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231101002609.3533731-1-jim.cromie@gmail.com> References: <20231101002609.3533731-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231031_172624_024613_CC5859AC X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org struct ddebug_class_param keeps a ref to the state-storage of the param, make both flavors use the same unsigned long under-type. ISTM this is simpler and safer. Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 4fcbf4d4fd0a..5231aaf361c4 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -124,7 +124,7 @@ struct _ddebug_info { struct ddebug_class_param { union { unsigned long *bits; - unsigned int *lvl; + unsigned long *lvl; }; char flags[8]; const struct ddebug_class_map *map; diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index ceb3067a5c83..b984ce338921 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -796,7 +796,7 @@ int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp) case DD_CLASS_TYPE_LEVEL_NAMES: case DD_CLASS_TYPE_LEVEL_NUM: - return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl); + return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl); default: return -1; }