From patchwork Mon Nov 6 17:17:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13447213 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40F64C4332F for ; Mon, 6 Nov 2023 17:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RIZ/LxAjknj6yJdMRIif43Ad6mC2EfB/rQkX1oTzxjM=; b=Z8mtd5wBaovSCJ l6DBfDsVXEBqCX3V9dXe1PKqYlhvubZCiYPdOhhymzBZMkkVjXCSYp54QxjofeLS67gjcG1m+As8V SvjOtci1l5IyY3qvBWpZ5jhyjRt/PU5JcyXkvTObiFtExN6SxHzgx0WLwPbBHpxhGQm9AXuu3JHJs jdwaMeDbjCt3CGKqnEzP9/F1P0irMOlSySB0RCWJkd0nrfVT+Gxkw7Jy26uWYeAFaVylSG0MBDzj/ bvJ5QIVeGMC/9ec6YbYvQGltdXZA6aREfu6GlxzLibGkJ7KN6knQh2nZTbe3fDYxyMQvXrWba2ftB gEcGzUcE8NC4372D5Zlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r03Eh-00HCy3-2h; Mon, 06 Nov 2023 17:18:03 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r03Ec-00HCuR-2f for linux-arm-kernel@lists.infradead.org; Mon, 06 Nov 2023 17:18:00 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r03ES-0005Qm-N4; Mon, 06 Nov 2023 18:17:48 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r03ES-0075yS-1K; Mon, 06 Nov 2023 18:17:48 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r03ER-00DrIw-OU; Mon, 06 Nov 2023 18:17:47 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 04/18] mfd: fsl-imx25-tsadc: Convert to platform remove callback returning void Date: Mon, 6 Nov 2023 18:17:13 +0100 Message-ID: <20231106171708.3892347-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231106171708.3892347-1-u.kleine-koenig@pengutronix.de> References: <20231106171708.3892347-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1657; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=H9E4DQumuJYM4xGNsjymKWQwrBqvaE1jdcSqA7stR1c=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlSR+ZgC8CiN4AXw68Xac7xLAtjysLjM58AGsxa S96l3uwAxGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZUkfmQAKCRCPgPtYfRL+ Tl7uCACZeoO2FEY4iUYohaHg2mVNmzCP4WapV70NlX8kXAT2Tp3dnW2heYmHB0Xvs//d3PC/z3c kABz4Psu0JWJJSNInbAk24uP2qBNa/vhOpfv0sF2WXHR+y6OLgo8LB2hLhfOt1EUx9O9D9Vmk7q Ak2kO9ExxuhqTkzUTQQKjR4IGQmEuvWJMY4+hrrBuNZRCtefBAPBGX/HzZDIlmkxz9MMPl4RLTT WISfBnEUuoUDiI43PqV60g75vYrN26JYRxz3gCQL3WIiS3ISBfiQhWtkiZN7kUKQKcYqf0dJpT7 4y991Gk4gxKVTjPoKF+yOy7iYRnK+fjtv19N50aZhxYSwOjp X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231106_091758_863788_99C015DE X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/fsl-imx25-tsadc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c index 089c2ce615b6..74f38bf3778f 100644 --- a/drivers/mfd/fsl-imx25-tsadc.c +++ b/drivers/mfd/fsl-imx25-tsadc.c @@ -194,11 +194,9 @@ static int mx25_tsadc_probe(struct platform_device *pdev) return ret; } -static int mx25_tsadc_remove(struct platform_device *pdev) +static void mx25_tsadc_remove(struct platform_device *pdev) { mx25_tsadc_unset_irq(pdev); - - return 0; } static const struct of_device_id mx25_tsadc_ids[] = { @@ -213,7 +211,7 @@ static struct platform_driver mx25_tsadc_driver = { .of_match_table = mx25_tsadc_ids, }, .probe = mx25_tsadc_probe, - .remove = mx25_tsadc_remove, + .remove_new = mx25_tsadc_remove, }; module_platform_driver(mx25_tsadc_driver);