diff mbox series

[1/2] staging: vc04_services: Use %p to log pointer address

Message ID 20231107165523.638555-2-umang.jain@ideasonboard.com (mailing list archive)
State New, archived
Headers show
Series staging: vc04_services: Use %p to log pointer | expand

Commit Message

Umang Jain Nov. 7, 2023, 4:55 p.m. UTC 
Solves the following Smatch warnings:
vchiq_arm.c:1113 service_callback() warn: argument 7 to %lx specifier is cast from pointer
vchiq_arm.c:1113 service_callback() warn: argument 11 to %lx specifier is cast from pointer
vchiq_arm.c:1113 service_callback() warn: argument 12 to %lx specifier is cast from pointer
vchiq_arm.c:1113 service_callback() warn: argument 13 to %lx specifier is cast from pointer

%p will print the hashed pointer to dynamic debug.
In order to print the unmodified pointer address, one can use the
`no_hash_pointers` via kernel parameters.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
 .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c  | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 4a2023919f5f..34b8985a57e2 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -1111,11 +1111,10 @@  service_callback(struct vchiq_instance *instance, enum vchiq_reason reason,
 	rcu_read_unlock();
 
 	dev_dbg(service->state->dev,
-		"%s: %s: %s - service %lx(%d,%p), reason %d, header %lx, instance %lx, bulk_userdata %lx\n",
+		"%s: %s: %s - service %p(%d,%p), reason %d, header %p, instance %p, bulk_userdata %p\n",
 		log_cat(VCHIQ_ARM), log_type(TRACE),
-		__func__, (unsigned long)user_service, service->localport,
-		user_service->userdata, reason, (unsigned long)header,
-		(unsigned long)instance, (unsigned long)bulk_userdata);
+		__func__, user_service, service->localport,
+		user_service->userdata, reason, header, instance, bulk_userdata);
 
 	if (header && user_service->is_vchi) {
 		spin_lock(&msg_queue_spinlock);