From patchwork Tue Nov 7 20:28:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13449273 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 658D4C4332F for ; Tue, 7 Nov 2023 20:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uztd48zyRxlvpExFYXAclnTVkl7cbRYxxU7ttFh5TBc=; b=ZoK/YTJZBaBj7R afnc2v/Mlbj2aCs3csEMM4zIoAkgAXYLae5AJL0+/+1Z+X5B4+iRZfLpLPtg+MJ3W2IE9XN6jSKuZ xd9XHTBpNRLrwK76V4DrgikLV62PM9xr9D16CgzvCTfYJqylUD4uOyEArAhEq9YONwbAnipT8uMdv OWXnyrKWzfOOZ9aMtHEHEMMG95Pcg4KD0iWNqy+FzPVFZFJ7dalwYd78/6zbA9k03W7JpVB8f5XR/ 8O56q7tG7Xa5BAkcY6pHSMUfO/WSPv5CYSGHcSySYSmGmL//PBE29IXnEumcu6C1svIkrgWqwHEcy c3PwCWQ2rKUnv1aRnoPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgq-002M1U-1m; Tue, 07 Nov 2023 20:28:48 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgl-002LzH-33 for linux-arm-kernel@lists.infradead.org; Tue, 07 Nov 2023 20:28:45 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0Sgf-00061t-77; Tue, 07 Nov 2023 21:28:37 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0Sge-007NNy-A5; Tue, 07 Nov 2023 21:28:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r0Sge-00EokQ-0z; Tue, 07 Nov 2023 21:28:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 2/8] coresight: dummy: Convert to platform remove callback returning void Date: Tue, 7 Nov 2023 21:28:21 +0100 Message-ID: <20231107202818.4005791-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> References: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1876; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=kDSbPhEnRTaF07v01xUBPsnezFcNE7nYzeMIOj+oAPA=; b=owGbwMvMwMXY3/A7olbonx/jabUkhlSvuU9Ugmbxd0aFph8WfXRk7YOiXbI7Poaf6A+oEU1T6 Quz0w/tZDRmYWDkYpAVU2Sxb1yTaVUlF9m59t9lmEGsTCBTGLg4BWAi2zk4GPo8OYKLYhf5fZoS ZsU+o39HeOv2PGOhHSs8shSuFdduv6au92CKbLDZzimPVbbVz85LT+HYt6T3e2DsVAHB/8YnF8v P+3JIbIZOtqCZOutWsckzZV8L1bCuyI6o0cnoXdhUIfil419L2bnGhAtr0tWFIjaIuccLct3SXW jwb01EEcvH2qXnX6eePuJvnPAkyMR4r233zCUSd++ErCp9tDCS4cqptfuVbD6sSLE7nXSwYMrC8 E6+3mcCKQwX2mdUFbM/3PHYK4Np/kGDm2HHbjtHrsn7rPE7v+wKd+zi48rbPBTN7wq1KXeLP1hd Hsb3oUBy0p1p+1Uc3fyXR6mEtiZZyt07nT9NIoxhU5w9AA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_122844_032093_D82F2D0A X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-dummy.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-dummy.c b/drivers/hwtracing/coresight/coresight-dummy.c index e4deafae7bc2..ac70c0b491be 100644 --- a/drivers/hwtracing/coresight/coresight-dummy.c +++ b/drivers/hwtracing/coresight/coresight-dummy.c @@ -122,14 +122,13 @@ static int dummy_probe(struct platform_device *pdev) return 0; } -static int dummy_remove(struct platform_device *pdev) +static void dummy_remove(struct platform_device *pdev) { struct dummy_drvdata *drvdata = platform_get_drvdata(pdev); struct device *dev = &pdev->dev; pm_runtime_disable(dev); coresight_unregister(drvdata->csdev); - return 0; } static const struct of_device_id dummy_match[] = { @@ -140,7 +139,7 @@ static const struct of_device_id dummy_match[] = { static struct platform_driver dummy_driver = { .probe = dummy_probe, - .remove = dummy_remove, + .remove_new = dummy_remove, .driver = { .name = "coresight-dummy", .of_match_table = dummy_match,