From patchwork Tue Nov 7 20:28:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13449271 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22950C4332F for ; Tue, 7 Nov 2023 20:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9E6gy4DWzC7ukvAMh2sRKMtpp0SX6NcUsGzOVdHuvTw=; b=JoCdXdoosXiKJa zTjj2d8QsrpzcegU0nNAYDStMl2gHoTSvo0dRWK0RAcmNnaG1vTsf66E+kmsQL48Y44K7BZMIFswZ n203PGUybytVehTNm+gqRvcvX9CC8f/JXPbv1c1mTZ2aSPyxR+Sly5MVj/ih/oHvBMkpnDw0IYYBk m8HWnFxOYR/MERvlpi8CjZiDakoRP0ve60n/UhFNxL5lr9pAsVctst6Vbg0MvxZYttx2lAEjG36yn c1FPj/iRyzm2GnzVrzC/Woa/f6L9LkjfZcJRQNaeQPlEpfeOWUrIq6u4FsQHCkgxu1nh0nrIDXvrY Zwm33S10VG1H5BbFqJsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgr-002M1Y-0A; Tue, 07 Nov 2023 20:28:49 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgl-002LzI-33 for linux-arm-kernel@lists.infradead.org; Tue, 07 Nov 2023 20:28:46 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0Sgf-00061v-EI; Tue, 07 Nov 2023 21:28:37 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0Sge-007NO4-UO; Tue, 07 Nov 2023 21:28:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r0Sge-00EokY-LD; Tue, 07 Nov 2023 21:28:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 4/8] coresight: funnel: Convert to platform remove callback returning void Date: Tue, 7 Nov 2023 21:28:23 +0100 Message-ID: <20231107202818.4005791-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> References: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1909; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ckxzLwYzLr/oPdmBU/IGTPID3/yg3Zuge/AMtvNE1GE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlSp3nrZ6cdUnRNQLscJi3mdw64qPSzSn4XA1OC +lsIQ3tq6+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZUqd5wAKCRCPgPtYfRL+ TsTZB/4pJF/USgJ5JCRG6r3HH1rcJAw2goaWKP/H8yaYnJfVq1aQpIVU80P3T844Tf9+L0kI8TQ oJarC92yDgG5FIfNnSfA3sNRJDU7ZSXH2R9rwz03o0y7KvYTuHkezW1ZbL97jkVbQGjKC8NwJ2G XN58sbGX7LMsRu4ZITpS9h5yaniFEnMMEJKHudne5DquUuPRCIQSO/TEUWE6OAi23FXtfC2+ppq MnUyCYCTWxc2ElOdGVWBWWMam122L1zz89cgr5wx8tI2J04WaJKhvrP7yGec8IaHJ9V6bsAUPZg U9OTHQTgZtToZhyBvxAwk640JM72N8cPPWlLO76M1PfTGLH1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_122844_038468_B0833A98 X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-funnel.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c index b8e150e45b27..a5b1fc787766 100644 --- a/drivers/hwtracing/coresight/coresight-funnel.c +++ b/drivers/hwtracing/coresight/coresight-funnel.c @@ -335,11 +335,10 @@ static int static_funnel_probe(struct platform_device *pdev) return ret; } -static int static_funnel_remove(struct platform_device *pdev) +static void static_funnel_remove(struct platform_device *pdev) { funnel_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); - return 0; } static const struct of_device_id static_funnel_match[] = { @@ -360,7 +359,7 @@ MODULE_DEVICE_TABLE(acpi, static_funnel_ids); static struct platform_driver static_funnel_driver = { .probe = static_funnel_probe, - .remove = static_funnel_remove, + .remove_new = static_funnel_remove, .driver = { .name = "coresight-static-funnel", /* THIS_MODULE is taken care of by platform_driver_register() */