From patchwork Tue Nov 7 20:28:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13449272 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BE4BC4167B for ; Tue, 7 Nov 2023 20:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8YCHEfnS7DowRR9++EqDiyDUeWNZ0JtjUc+IvqlvN8s=; b=sKnokZq8nVgmK6 VtjnNVi7UJqguWl6TT29F1RtSY+1Jrcjzc0jr5GQecSzGuhuaddzFPa7J+59nio6ngyDTT0ucKpD/ 57oMHxtlnQcv4Hkg93wAA+nI58vGAgRYwLr79ZBvZH3Lrgu1d2HChRCrI2hE475RKQgLLBmLR+KMM awKaxJko5zFR1wcp5PgX3hrVS3HLGAZOWkY/Vf9buF9hb/IpnRg6br0JbVQvAYODmFqHGJpzPczjy dhllm8qejHHzUh6RVuJLjO/l1I4W6B5iNjtk8EOHfyuOj4eWDKSO3M0W5hlxIhwsnYHysjxOtw3a1 obftchYWlbPb4cdfBImQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgs-002M1i-0F; Tue, 07 Nov 2023 20:28:50 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgl-002LzN-32 for linux-arm-kernel@lists.infradead.org; Tue, 07 Nov 2023 20:28:46 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0Sgf-00062K-Nf; Tue, 07 Nov 2023 21:28:37 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0Sgf-007NOA-Aj; Tue, 07 Nov 2023 21:28:37 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r0Sgf-00Eokc-1X; Tue, 07 Nov 2023 21:28:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 5/8] coresight: replicator: Convert to platform remove callback returning void Date: Tue, 7 Nov 2023 21:28:24 +0100 Message-ID: <20231107202818.4005791-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> References: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1930; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=4gwK1dyeiVLM++LqvnfFvxq0IcHYha+lEqNnIXDY8Wc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlSp3ooBdmk9AQC0Bp3BwIMKEWdCdC/rFSnh9dk HkN8iqU/GCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZUqd6AAKCRCPgPtYfRL+ TvqIB/964OF/FvTcWf0xnej3PePmMbAwXg04medTPCqqH/xu2xSvLAjfYI/KFVGbk6Xde1FL8lo J8QzG+MQJxtuTK5HO3pelu19LCK0fuuVegxR5730Xqb2iMZ3k1kmt/l8I1ynJZGCICbKn417opc qg/44cagVPPDsYmc6zMi9C0dx3z44qdCdu3L+zjuUUAcz6BDianL/u5jKwIL2typS+f/kjo0/0h jLZpSbEm24fHEBzQHX0APrYhvK/aloPBNE9+8i+4DuK5EXTPNx/1qqEvCz40BAp3Yxcc2/BLmWl qqu8+l+fziH8Vur3pMXEpj3ElVOVT3bEuvRrRWh+EonPfIMh X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_122844_052669_6DFF4192 X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-replicator.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c index b6be73034996..91d93060dda5 100644 --- a/drivers/hwtracing/coresight/coresight-replicator.c +++ b/drivers/hwtracing/coresight/coresight-replicator.c @@ -320,11 +320,10 @@ static int static_replicator_probe(struct platform_device *pdev) return ret; } -static int static_replicator_remove(struct platform_device *pdev) +static void static_replicator_remove(struct platform_device *pdev) { replicator_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); - return 0; } #ifdef CONFIG_PM @@ -373,7 +372,7 @@ MODULE_DEVICE_TABLE(acpi, static_replicator_acpi_ids); static struct platform_driver static_replicator_driver = { .probe = static_replicator_probe, - .remove = static_replicator_remove, + .remove_new = static_replicator_remove, .driver = { .name = "coresight-static-replicator", /* THIS_MODULE is taken care of by platform_driver_register() */