From patchwork Tue Nov 7 20:28:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13449276 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA84DC4167D for ; Tue, 7 Nov 2023 20:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=btoT75DIC/+XTI0AVbAQdXIB1GRd7zyIkyo9UNDo3G4=; b=qBILGwHEkwdjJN jGisQjb7MXvV80/qEjgxtq16ZYdyW8yhBW2Io2sPH9mFnGCsFnx3e1yPNZFjnqXLfdbqw8TF4qhZP qFHMcmym1wgyYBpU085j/dKl23n+R6bu4TY1BBqcaedFHsogKpr20xo3zouINqB84F+kHhRDAQ65e R8GSEsCtGL+fY4gwJLCq81YHeQAdysMGvhJSnLPmxyEY5Kz2xmbcYZ2NO5he70NCIVHsWPLm37rbS 4q1ZcPdIIf5SrSb1f6oXshTRcJGJ6gq6ymIWlkRsBzt4AtYeXZDjOTau7+nmdI/5hHIZVMVvzviun Zz9jKsI9bGYKDJlV5KEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgs-002M2a-1y; Tue, 07 Nov 2023 20:28:50 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0Sgl-002LzO-32 for linux-arm-kernel@lists.infradead.org; Tue, 07 Nov 2023 20:28:46 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0Sgf-00062U-V1; Tue, 07 Nov 2023 21:28:37 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r0Sgf-007NOH-IA; Tue, 07 Nov 2023 21:28:37 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r0Sgf-00Eokg-99; Tue, 07 Nov 2023 21:28:37 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 6/8] coresight: trbe: Convert to platform remove callback returning void Date: Tue, 7 Nov 2023 21:28:25 +0100 Message-ID: <20231107202818.4005791-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> References: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1895; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=KNvGLjYulDOon5MFKbMtWOyJgqmqqD8sX9roesDaPJI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlSp3pPC4/2a9B/0eEDTNOIF4aXQ9k/VHRyRSmF jotNQq8GmWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZUqd6QAKCRCPgPtYfRL+ TgebB/91lY73FPE9RpcNNTiVRlXMlJH2MKF4w9vAWZYb/kRlM2+dTK2N74+geI0rKMAMoCDJz1c GxWT/78KIGf/5PyFSS/sFTjy6pM/ZQ3ZAZrSIeKGBol7BxhLIbSL49SUEzx1IQNZq2S6DPNPVCx U/xQiIxxvbLCjnHgRYpvDELvTU+c98A1NLxwZNh0kXdNi51yxpU2QVTKpptcdxHf1WpyJiSOtdG Byv0LNAoYVHVf5GVo4b/rFtbnc+/sEcQOQJW7TN6QEXHcioGSE7OXIaf722SESUqunJ7QvULoIg BG/dl7OJ2SDafiUdaJoYBxg72QaqTmZVjpH0rDPovNlfU+Dw X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231107_122844_065518_A55A81B4 X-CRM114-Status: GOOD ( 16.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-trbe.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c index a3954be7b1f3..6136776482e6 100644 --- a/drivers/hwtracing/coresight/coresight-trbe.c +++ b/drivers/hwtracing/coresight/coresight-trbe.c @@ -1530,14 +1530,13 @@ static int arm_trbe_device_probe(struct platform_device *pdev) return ret; } -static int arm_trbe_device_remove(struct platform_device *pdev) +static void arm_trbe_device_remove(struct platform_device *pdev) { struct trbe_drvdata *drvdata = platform_get_drvdata(pdev); arm_trbe_remove_cpuhp(drvdata); arm_trbe_remove_coresight(drvdata); arm_trbe_remove_irq(drvdata); - return 0; } static const struct of_device_id arm_trbe_of_match[] = { @@ -1562,7 +1561,7 @@ static struct platform_driver arm_trbe_driver = { .suppress_bind_attrs = true, }, .probe = arm_trbe_device_probe, - .remove = arm_trbe_device_remove, + .remove_new = arm_trbe_device_remove, }; static int __init arm_trbe_init(void)