From patchwork Wed Nov 8 14:33:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13450226 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F28BC4332F for ; Wed, 8 Nov 2023 14:34:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V0ok+skCfY1938hB2UgYwV1B3QruEbPBoAVR0yFEcws=; b=U1sukus9JoieAN VRbJuD++zPaIKU993M0kuUZp693Vhty89uLP4h9CfiwD/q2t1L4cSZBLnm5UuoQEbALWUGh1KTaZb 1MtFWVNY5qkuXQDCo2eDQnWc5cEYsVEcvskiZ5eMNZm5OYilcCJKSP0aIoLjLHsQKTEk4uLOMBJ2r yWy9IJt3WlLmAjP98BmPILrsikda2KEmX9hMsVHG9Jtc0DygdS8b7Cfm9JEDW90+dUXVwvJVdJX1F IVzSDgljKD9fxzemodRiOcZnowlSN8tJFtqxPBOD8iUA8hMWs49NxOl+yMGQdlQ8adSkjfOr1Wmpf Ch37e6UjHszITq9XpVbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0jdE-0041Pt-2k; Wed, 08 Nov 2023 14:34:12 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r0jd6-0041HD-2C for linux-arm-kernel@lists.infradead.org; Wed, 08 Nov 2023 14:34:07 +0000 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-507bd19eac8so9120048e87.0 for ; Wed, 08 Nov 2023 06:34:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699454041; x=1700058841; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XORLfLOVJ2jQDbg32nclaixgD4oigISmdEZzRfl6mkQ=; b=Kw8zkziQQmIk48fQWMi7lP62iuBKowGkgnS3YgQNEVQPM8LtQoipPbeUlEXor8fXBH RXBZ8BKcTb6a4e9CXPwWyM1UP1QBgU52TuMkI3zQW9BOjKXRk17C1fFY7zDXpO984Wg4 sWnga2tKGi4WAKBfdu4SlLIOWQjeDi3NjTZIugxVRT616a9JnC1ZJILR6FrfetJd2nu0 K9QvAFDv6jV417F7bdZ0tap1HCcimdbGNaA9XmzhT8vwJ0bPYdEkSVyjTdx6SRw1lj73 t91ICYkdV29mk2cSQBCeRIDxWiQUAIW6Z7U9Dnb+H0UT8OjsKGnMnQUdGZUD9pu2kRTo YzuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699454041; x=1700058841; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XORLfLOVJ2jQDbg32nclaixgD4oigISmdEZzRfl6mkQ=; b=TkFOonnDoVNc5Q/QwcMuTvIwonwN6QfjOIgyV+sK+ZRXH1+hwZ2OwBwxXrHQzpWwii fj9hSSEA7aSfxRlH+isgusGmlRKt9JvJI2GFrqDPdbVD1/LrpOK6P+0+e1+gj6CnHRN2 mUqUhxLUph6HLSnMOKnBplv2XzLDyO0IWcgjhicEsETkquvN3idTlqtDUyy89WHNwqAT igDcUQCww4enpQiopHCC0B7xSTYmCeIb3QfBHIRQVLxiqyuia5MFB1+mHi94qjnOg0nE PiqoDDrg/bLtRfABSIAsbFbw3qPSjXns6Bpi7gwHHJEHRKuFZ9lCed+ZAgqbL1Ink2ES UilQ== X-Gm-Message-State: AOJu0Yw8vwzyhgJVx4NTM/HmyAAEE2MxNrpfPloXed1QjDc2OI/drJgV q79EvSTB+RE1H7A/H6cNDLCDSA== X-Google-Smtp-Source: AGHT+IFUUB+MEIyguPoyxj1+fLJV+aOZb8wF1YqAbqWQ7eWQC+wzmv7GE9RSys2AiakbuL3fuZImwg== X-Received: by 2002:ac2:5d2b:0:b0:500:7685:83d with SMTP id i11-20020ac25d2b000000b005007685083dmr1266850lfb.48.1699454041779; Wed, 08 Nov 2023 06:34:01 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id q10-20020ac24a6a000000b00507a3b8b007sm686773lfp.110.2023.11.08.06.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 06:34:01 -0800 (PST) From: Linus Walleij Date: Wed, 08 Nov 2023 15:33:51 +0100 Subject: [PATCH 3/6] MIPS: NI 169445: Fix NAND GPIOs MIME-Version: 1.0 Message-Id: <20231108-fix-mips-nand-v1-3-5fc5586d04de@linaro.org> References: <20231108-fix-mips-nand-v1-0-5fc5586d04de@linaro.org> In-Reply-To: <20231108-fix-mips-nand-v1-0-5fc5586d04de@linaro.org> To: Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Ben Dooks Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_063404_719473_BF52EA81 X-CRM114-Status: GOOD ( 15.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This changes the GPIOs defined in the device tree to recommended practice, which is also what the Linux NAND GPIO driver is actually using. In the process, fix up the CE and WP lines to be active low, as is required for proper hardware description. Signed-off-by: Linus Walleij --- arch/mips/boot/dts/ni/169445.dts | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/mips/boot/dts/ni/169445.dts b/arch/mips/boot/dts/ni/169445.dts index 5389ef46c480..3e7b46d5072c 100644 --- a/arch/mips/boot/dts/ni/169445.dts +++ b/arch/mips/boot/dts/ni/169445.dts @@ -1,4 +1,5 @@ /dts-v1/; +#include / { #address-cells = <1>; @@ -57,18 +58,18 @@ gpio2: gpio@14 { no-output; }; - nand@0 { + nand-controller@0 { compatible = "gpio-control-nand"; nand-on-flash-bbt; nand-ecc-mode = "soft_bch"; nand-ecc-step-size = <512>; nand-ecc-strength = <4>; reg = <0x0 4>; - gpios = <&gpio2 0 0>, /* rdy */ - <&gpio1 1 0>, /* nce */ - <&gpio1 2 0>, /* ale */ - <&gpio1 3 0>, /* cle */ - <&gpio1 4 0>; /* nwp */ + rdy-gpios = <&gpio2 0 GPIO_ACTIVE_HIGH>; + ce-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; + ale-gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>; + cle-gpios = <&gpio1 3 GPIO_ACTIVE_HIGH>; + wp-gpios = <&gpio1 4 GPIO_ACTIVE_LOW>; }; serial@80000 {