From patchwork Thu Nov 9 19:13:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 13451656 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9223C4167B for ; Thu, 9 Nov 2023 19:14:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pknit9+vrwZ+JHHBEghsR/8ttWMmYEDlbd0GSNw5PgU=; b=GHmAFP3kwvFjLWs9Q/B7yqpp4w KHaT42LLElfOr8xiwE0MMT+UBH8YNbZDu4PrmcU6qhA/OFAySKyNhE8YCLJ0PYqNeb9wYdNylo4jy WDi9D3xTSFvUAfpfEf0j8vW14V0w7CvjUIfz1GFIgeAmLxUh51wj7IKPYVVaEdZjtQUfA9tkPm4ns r2UDM6VcuQC1RprWunEQZ3PfZBYxn34u1M3N73VPuxYy6O5faHBGH8HO2AZZFC32BPtoJ9QKy/hp+ zpKbebQZdHqAiVm3GC1fVHvOtMf23D0zhoL5N9Mivuz8TOVSGhF2znC4I24jVeooNnTLXy6Xv+19o olMrzy3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1ATj-0075Mm-2Y; Thu, 09 Nov 2023 19:14:11 +0000 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1ATg-0075Jh-0R for linux-arm-kernel@lists.infradead.org; Thu, 09 Nov 2023 19:14:09 +0000 Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-5a9bf4fbd3fso1014050a12.1 for ; Thu, 09 Nov 2023 11:14:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1699557245; x=1700162045; darn=lists.infradead.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=ch8mrQrI0dgq+6F3kU1rBaVhFUPE19Alo6ui06R+8So=; b=GVxq3btzHiDu1rq52y/6MuqnXyNstXJ2axLo5lGsA0BVgohXbqSumtzqTdJwRueEc8 sh0av0JHvtynv05yYnyX9Fe9Fdbqb4pSnaYWGRdiZzMk6tegLPaT0t8Uf+GdDO8FkG6T YLYNxQXkPrSHUM5F8A7bOfcBERvjYPLp5JLFA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699557245; x=1700162045; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ch8mrQrI0dgq+6F3kU1rBaVhFUPE19Alo6ui06R+8So=; b=M03+Eo3jM+kpwtLqAqR89RCpN1D2EivrL5BdVUCuofnCrL0djzL8MGG9ADZ2gXXyWC VK0NdcLTSsssxkBBIFLY8Fq56WRedYY/0a5kKlBA1xWvB40c/1+h4ySYnljDfAtlpuXL lrd63gofehq+LYAD7GjCpzvuTJt2b1A6iiNikVV9r6H0X5yKf5FV/eRBwd294Mk7X4US fPvHbdvUbtKmgAC5S0RvPhkYNoMSkBCUNAOnRTJQ068oJJcxoZK5CDX305lypZkZ7Hxd Jxtqjm1kfgjUzi0bP8P+tDmG+r0x0kt64xpv+xReCmTgqntrIyTNYsNz86UZhM99tCFp 8g/w== X-Gm-Message-State: AOJu0YwICYHvMZ5wj+SVZd7+R2kqMFDREtBJgtZ2tOdouZjwnF/D5p9u j3ZCFS6hJFCJXebFd8l9+ADY9A== X-Google-Smtp-Source: AGHT+IEeKu000QUnOY8ufASRQnlK20TPw6yuERVkwYldxGsl22CFd1ano6SoYr6eisX00tuZkdW9tw== X-Received: by 2002:a17:90b:4c91:b0:27f:df1e:199e with SMTP id my17-20020a17090b4c9100b0027fdf1e199emr3039866pjb.28.1699557245028; Thu, 09 Nov 2023 11:14:05 -0800 (PST) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id pj9-20020a17090b4f4900b00282ecb631a9sm124069pjb.25.2023.11.09.11.14.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Nov 2023 11:14:04 -0800 (PST) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Jim Quinlan , Florian Fainelli , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v7 1/3] dt-bindings: PCI: brcmstb: Add property "brcm,clkreq-mode" Date: Thu, 9 Nov 2023 14:13:52 -0500 Message-Id: <20231109191355.27738-2-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231109191355.27738-1-james.quinlan@broadcom.com> References: <20231109191355.27738-1-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231109_111408_204812_5F3B7937 X-CRM114-Status: GOOD ( 13.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs -- requires the driver to deliberately place the RC HW one of three CLKREQ# modes. The "brcm,clkreq-mode" property allows the user to override the default setting. If this property is omitted, the default mode shall be "default". Signed-off-by: Jim Quinlan --- .../bindings/pci/brcm,stb-pcie.yaml | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml index 7e15aae7d69e..992b35e915a5 100644 --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml @@ -64,6 +64,27 @@ properties: aspm-no-l0s: true + brcm,clkreq-mode: + description: A string that determines the operating + clkreq mode of the PCIe RC HW WRT controlling the refclk signal. + There are three different modes -- + "safe", which drives the + refclk signal unconditionally and will work for all devices but does + not provide any power savings; + "no-l1ss" -- which provides Clock Power Management, L0s, and + L1, but cannot provide L1 substate (L1SS) power + savings. If the downstream device connected to the RC is + L1SS capable AND the OS enables L1SS, all PCIe traffic + may abruptly halt, potentially hanging the system; + "default" -- which provides L0s, L1, and L1SS, but not + compliant to provide Clock Power Management; + specifically, may not be able to meet the Tclron max + timing of 400ns as specified in "Dynamic Clock Control", + section 3.2.5.2.2 of the PCIe spec. This situation is + atypical and should happen only with older devices. + $ref: /schemas/types.yaml#/definitions/string + enum: [ safe, no-l1ss, default ] + brcm,scb-sizes: description: u64 giving the 64bit PCIe memory viewport size of a memory controller. There may be up to