From patchwork Fri Nov 10 15:29:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13452465 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4915C4332F for ; Fri, 10 Nov 2023 15:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YixTEGpwz4FNzXTY4dlP3DHUBQnlItYc1Lttfdexk+4=; b=09EQ/e2oM0RlhA QP7pT5Ua6U0bIzqA0Ds1q0hpwPVGiFW3HaBFcg3NdeSaC8nA2LjBvhkyp6MsrUcfayCqMuphI7u8D 1H9C9QC+8gucA0VyJtoVUUe8a59Av8/h8v3p64YPlK/ZrsVH7Yvll9whUKpO7LT51rNQ0PQ7UYhmP /tvSLytSLLa7WYXLuqGSY+oBvAVW2GVGLoJAIfYz+2Qd/AO74UNGE19kc1314go9adLW1OB8qJMak nF/XkzXvqx/3KZw1M82jhhR9IJNUE/V0LhemoWKBd0hILuJDnlESfINhpRC+XTO+kAaQ3jd5QxbgS MQB2D76r3Eqg5d6QTZew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1TTA-0090er-1T; Fri, 10 Nov 2023 15:30:52 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1TT7-0090dh-3A for linux-arm-kernel@lists.infradead.org; Fri, 10 Nov 2023 15:30:51 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1TT1-00067r-6Y; Fri, 10 Nov 2023 16:30:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1TT0-0083JK-8Z; Fri, 10 Nov 2023 16:30:42 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1TSz-00Gnva-Vf; Fri, 10 Nov 2023 16:30:41 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman , Jiri Slaby Cc: Baruch Siach , Thierry Reding , Tobias Klauser , Thomas Gleixner , kernel@pengutronix.de, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 12/52] serial: digicolor: Convert to platform remove callback returning void Date: Fri, 10 Nov 2023 16:29:40 +0100 Message-ID: <20231110152927.70601-13-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231110152927.70601-1-u.kleine-koenig@pengutronix.de> References: <20231110152927.70601-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1870; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=m1r+QnP/V3kim5WaF5/ossgE+daOyiM+Oba/zRsf6PU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTkxldbtdlasu2fgCBkvHIU0UHpc1TpfPHHQ4i C+4HuAlVYqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU5MZQAKCRCPgPtYfRL+ TjSTCACuWfN+bQoO9xganPfDGRi2FGjr5tmYUWYpcGC9fB+4bGv+CfhkRiG58Q/z7V8418yuo7h JAY7M7ASFODk5DgfEwW9E8QUVDFXA1IeyZZebxiOniXQCxfTQfN+QgnPxAaNz1Fsp22Yv0/9fd0 ynVktuIei55uYWy/R3GsUcp/qkmImrcLe/fFU407NdHkRmdna7tGy6MiVF1Y/kokZvC+QSfXZH9 7sfseQB9ua4mBl1IHcv96YPMCqCQ06DYRKV/0PpnMx/ytsKLUQ67MIzspZcQW7ezFCxlrMrLZ7q dEJVe8Dqut7Y/YaP21S4Tt94fHXtp8+WAIlHpTVdhO8/WNfW X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231110_073050_045585_BBF9B604 X-CRM114-Status: GOOD ( 16.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/tty/serial/digicolor-usart.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/digicolor-usart.c b/drivers/tty/serial/digicolor-usart.c index 5004125f3045..e419c4bde8b7 100644 --- a/drivers/tty/serial/digicolor-usart.c +++ b/drivers/tty/serial/digicolor-usart.c @@ -503,13 +503,11 @@ static int digicolor_uart_probe(struct platform_device *pdev) return uart_add_one_port(&digicolor_uart, &dp->port); } -static int digicolor_uart_remove(struct platform_device *pdev) +static void digicolor_uart_remove(struct platform_device *pdev) { struct uart_port *port = platform_get_drvdata(pdev); uart_remove_one_port(&digicolor_uart, port); - - return 0; } static const struct of_device_id digicolor_uart_dt_ids[] = { @@ -524,7 +522,7 @@ static struct platform_driver digicolor_uart_platform = { .of_match_table = of_match_ptr(digicolor_uart_dt_ids), }, .probe = digicolor_uart_probe, - .remove = digicolor_uart_remove, + .remove_new = digicolor_uart_remove, }; static int __init digicolor_uart_init(void)