From patchwork Wed Nov 15 08:57:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Su Hui X-Patchwork-Id: 13456402 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D6E6C07548 for ; Wed, 15 Nov 2023 08:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=t3ggfrI1uObKvUaZFOTHZelnIF1MgbIQaZBtWCsYDRM=; b=a6o0p9kRLUjGNL DJ+Zr3Uiix9zRfgui3BvRaV4+9xtZTsXhf9M9AG2EmCHnUKa1qRDeT5x4Wz9dY3s+hnGy/GlxqcBb cpts+PObZMlakXrkm1hlNXD7r/Xc0MeSquzLwuz5bBNzlHGN6Rmt2FdMqGsRCOpxCVUSWPvSGKRNs HL9WPPmIQB+tsIe/4Q0q4xoPeN7fEILd1eFzvjFU3kQ0fcQqf6LqOlIx42oShn60qtTmbrestJBTV fvdIGn3w5zE9KcxpFZ3g2JwdWuvAsqb8jp7wfypeFkCkwiHNlA+z+pGdSNc3Lb67/5JovnHuGcypT 6G5A7ec9VTIXWoC2AOfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3BjM-000HBo-2D; Wed, 15 Nov 2023 08:58:40 +0000 Received: from [42.101.60.195] (helo=mail.nfschina.com) by bombadil.infradead.org with smtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3BjJ-000H9q-0p for linux-arm-kernel@lists.infradead.org; Wed, 15 Nov 2023 08:58:39 +0000 Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id B57E860230185; Wed, 15 Nov 2023 16:58:22 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui To: s.nawrocki@samsung.com, mchehab@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com Cc: Su Hui , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: [PATCH] media: platform: exynos4-is: return callee's error code rather than -ENXIO Date: Wed, 15 Nov 2023 16:57:54 +0800 Message-Id: <20231115085753.1027348-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231115_005837_488990_B7339160 X-CRM114-Status: UNSURE ( 8.33 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Clang static analyzer complains that value stored to 'ret' is never read. Return the callee's error code to fix this. Signed-off-by: Su Hui --- drivers/media/platform/samsung/exynos4-is/fimc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-core.c b/drivers/media/platform/samsung/exynos4-is/fimc-core.c index 97908778e1c8..0be687b01ce5 100644 --- a/drivers/media/platform/samsung/exynos4-is/fimc-core.c +++ b/drivers/media/platform/samsung/exynos4-is/fimc-core.c @@ -814,7 +814,7 @@ static int fimc_clk_get(struct fimc_dev *fimc) fimc_clk_put(fimc); dev_err(&fimc->pdev->dev, "failed to get clock: %s\n", fimc_clocks[i]); - return -ENXIO; + return ret; } #ifdef CONFIG_PM