From patchwork Thu Nov 16 17:33:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13458141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8328C54E76 for ; Thu, 16 Nov 2023 17:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fHILuwPj/Cs4is/BearqRLutOloHjBAskBGNaaMcLw4=; b=VJNX4uaOEG1mlN Nd+uZV45uTWbXcJgFA6Ep6Rlo3ym8x8OtE9qaAEqFKgQwg9IrtdjI4BiL5NB6Iaaw/Vz4Nm4MdUud Z9Kg4IKWY3S/gMMFODZcqDkNcMNOVGUspdd/g6MoguXgPtYDecTQkmCN+LOElVRqYDdisDCjVFqVf 2Dol93vQ+InRuNR83zki4cslIryQnRzUw839P2jaucWWuk7v8U0a6/WOT+8tprGRxJnlvENivTWA5 lP6AyFs1SZTigtZc/A0Hiha/LWzzLjzQ4iIcoGiLXHgt15HBdJsWc+4mVBiWPCZGvDVfCIaqqxP9K Q3aDnbDS+1ziixGZMGuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3gFI-0049HY-0x; Thu, 16 Nov 2023 17:33:40 +0000 Received: from metis.whiteo.stw.pengutronix.de ([185.203.201.7]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r3gF8-0049DK-1L for linux-arm-kernel@lists.infradead.org; Thu, 16 Nov 2023 17:33:33 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3gEz-0006as-7N; Thu, 16 Nov 2023 18:33:21 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r3gEy-009V5M-LW; Thu, 16 Nov 2023 18:33:20 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r3gEy-002kDu-BK; Thu, 16 Nov 2023 18:33:20 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Suzuki K Poulose , Alexander Shishkin Cc: Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH v2 4/6] coresight: replicator: Convert to platform remove callback returning void Date: Thu, 16 Nov 2023 18:33:05 +0100 Message-ID: <20231116173301.708873-12-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231116173301.708873-8-u.kleine-koenig@pengutronix.de> References: <20231116173301.708873-8-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1978; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Gyu1d6jyQQYyw21kV+Sob8B/KfWa8xxUaksFIP46F/U=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlVlJSSbqfjS2U44HCQb+yjOc3I71h97v4pnMef Njy73AkPveJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZVZSUgAKCRCPgPtYfRL+ TlTOB/4urXUrlCkXZfpQsbznmFZmcR7rTFahMbAYAAcAnkQlSZDNVTHDfw/9YsYZNRgxhAvb18n 8TdItXxsknIXv3HcN8QXEK6mwR4WDwNyyiztZxZ1/Kxp2yq5LgPOM7+Ygu6naNvPKU2t2ZVTkAr Gz1xkuwDUsj0dfem4i7MJyh8318enWJvUb0hTP67UuKcAgGjqys5Bb3EaENnSL5OMmCDQXYsVhr hkvSOrKpMZAFXodQ2iXOWtor08SpduwxOyr4yOX5US8Mfvij8OcnQ07iKcSRxNEEl7GBnbSk8yQ T/gathPTUIJLzKxwFPK+N9yRFKaXPJPcLCj7bflFf189k0/o X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231116_093330_499334_072426F4 X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Reviewed-by: James Clark Signed-off-by: Uwe Kleine-König --- drivers/hwtracing/coresight/coresight-replicator.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c index b6be73034996..91d93060dda5 100644 --- a/drivers/hwtracing/coresight/coresight-replicator.c +++ b/drivers/hwtracing/coresight/coresight-replicator.c @@ -320,11 +320,10 @@ static int static_replicator_probe(struct platform_device *pdev) return ret; } -static int static_replicator_remove(struct platform_device *pdev) +static void static_replicator_remove(struct platform_device *pdev) { replicator_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); - return 0; } #ifdef CONFIG_PM @@ -373,7 +372,7 @@ MODULE_DEVICE_TABLE(acpi, static_replicator_acpi_ids); static struct platform_driver static_replicator_driver = { .probe = static_replicator_probe, - .remove = static_replicator_remove, + .remove_new = static_replicator_remove, .driver = { .name = "coresight-static-replicator", /* THIS_MODULE is taken care of by platform_driver_register() */