From patchwork Thu Nov 23 09:35:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Furong Xu <0x1207@gmail.com> X-Patchwork-Id: 13465983 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBAECC5AD4C for ; Thu, 23 Nov 2023 09:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=u+pEfx2I6a4Wkr8R4H5XPrbK4jpiDKwQQA84hslpaL0=; b=1cTtO6zGCai6N2 BGiRELTRw8PVjW6f9vH3SmmqAg5jLo2heejjqb9LZ0yD2rALERzn9AYWXbFe2xr9ne6WmwxLKI60x DDuvAETQQnzzSIn6swQRcxMaLMs10VjO1Tk2Iwy3xL4TSJlbhRdUT6I3JqQsyWmC5w/wJBLGXsB7c vUkgqkp9IFj+7M6ZZC3HQwZQL7nFFv9iSctpWECha9aWBFElBScExJ2/tlUNrnkQP5D5/QNdvfId4 eoUzkqCcci7XaZs3I48/WsstsADdfgcfJS56GXTDowGVey0uQ7WQzHl/9g2CP9nPhKHVn62T2YxNp IGGG3sWRoLoXLB6RoFSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r668F-004Gv0-2N; Thu, 23 Nov 2023 09:36:23 +0000 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r668C-004Gub-1s for linux-arm-kernel@lists.infradead.org; Thu, 23 Nov 2023 09:36:21 +0000 Received: by mail-ot1-x32c.google.com with SMTP id 46e09a7af769-6d7e794f5d3so441041a34.0 for ; Thu, 23 Nov 2023 01:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732179; x=1701336979; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dQhHNIKfWiIWad6NjUl3O8AGhzuURYHnVhK+SmvQomg=; b=hsPfdKLSb7GdJh06Wy0Rum+GBInr0WtIR9982YvPc4TIG0i/6w3o9pXZSCGEEsZYrk TD10kynfQ5k76KDMNpKwgkhW++MqozAl0Br+eNBcHZkg2cBltHA6dZ9aKtpCGpzHFvRC z17YlXt0UGiEWPLQ6lb7b3IJ8Fu2eWUnMkC3vbdIM9eRPEyUYE+rhk5nun2V7fx7BcQI oCkswg1IvCDU3A0sI7sFE6IXCmAlJC/T2Wff5Lqy+rU3qZ4JNBkxXhzvgpGPjPx9kAc8 s8HAcSMDaOqqsMP3gLL+YPf6B3nqxDxlnKp8dlwofO8kvxpL84A304Iqtde1+86LH66f jQNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732179; x=1701336979; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dQhHNIKfWiIWad6NjUl3O8AGhzuURYHnVhK+SmvQomg=; b=T84SHbmnZXlvK6dOQrNQbqt35wjGCrfkc9vYNkZpVjngPgTJ9GlJwmt581ME2wVFtA Mhy+OMX+4zTgrnwX/xnRYYoheYmqRKJYOIT001wPsiUAlzYaVLO2LW5coEGu8g3RW/8C eFXjVJ/c2JDiwd3Y8JSOttqJOy/UcK0TsUYb5b1407I/w22jpj5CNfRDn8v527O/YzH0 J2PMyo5j1QL3Xui1kNCvWhvrevUYferF/r7dc9Q5UgzCIGPys6A0CbK5fN7T3gh1lvP5 DxwGC5XqmjGMBjvoRzsmajLJwY+92HUqeAtdiVd6OCoP9iYFXvpN50+5x8rWODfX8DuJ fOCA== X-Gm-Message-State: AOJu0YyKc0ic54gK0zvE+mpUhvgJot/ovaBXh2J+s/kpGXui+imNlOWX z++PjwNKk4lacQS9QOVCG70= X-Google-Smtp-Source: AGHT+IEpKb2YEB93s5BEDe/ctdnNVWLRYV7AcKyFu0sGdgnl4YodP6t5BrbO/0iA6SuVCzPswe8etA== X-Received: by 2002:a9d:6857:0:b0:6d6:4b8b:baf1 with SMTP id c23-20020a9d6857000000b006d64b8bbaf1mr5427820oto.23.1700732178744; Thu, 23 Nov 2023 01:36:18 -0800 (PST) Received: from localhost.localdomain ([74.48.130.204]) by smtp.googlemail.com with ESMTPSA id o13-20020a635a0d000000b005a9b20408a7sm922970pgb.23.2023.11.23.01.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:36:18 -0800 (PST) From: Furong Xu <0x1207@gmail.com> To: "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto , Simon Horman Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com, Furong Xu <0x1207@gmail.com> Subject: [PATCH net v1] net: stmmac: xgmac: Disable FPE MMC interrupts Date: Thu, 23 Nov 2023 17:35:38 +0800 Message-Id: <20231123093538.2216633-1-0x1207@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_013620_622256_34E6FE06 X-CRM114-Status: UNSURE ( 9.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit aeb18dd07692 ("net: stmmac: xgmac: Disable MMC interrupts by default") leaves the FPE(Frame Preemption) MMC interrupts enabled. Now we disable FPE TX and RX interrupts too. Fixes: aeb18dd07692 ("net: stmmac: xgmac: Disable MMC interrupts by default") Signed-off-by: Furong Xu <0x1207@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/mmc_core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c index ea4910ae0921..cdd7fbde2bfa 100644 --- a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c @@ -177,8 +177,10 @@ #define MMC_XGMAC_RX_DISCARD_OCT_GB 0x1b4 #define MMC_XGMAC_RX_ALIGN_ERR_PKT 0x1bc +#define MMC_XGMAC_FPE_TX_INTR_MASK 0x204 #define MMC_XGMAC_TX_FPE_FRAG 0x208 #define MMC_XGMAC_TX_HOLD_REQ 0x20c +#define MMC_XGMAC_FPE_RX_INTR_MASK 0x224 #define MMC_XGMAC_RX_PKT_ASSEMBLY_ERR 0x228 #define MMC_XGMAC_RX_PKT_SMD_ERR 0x22c #define MMC_XGMAC_RX_PKT_ASSEMBLY_OK 0x230 @@ -352,6 +354,8 @@ static void dwxgmac_mmc_intr_all_mask(void __iomem *mmcaddr) { writel(0x0, mmcaddr + MMC_RX_INTR_MASK); writel(0x0, mmcaddr + MMC_TX_INTR_MASK); + writel(MMC_DEFAULT_MASK, mmcaddr + MMC_XGMAC_FPE_TX_INTR_MASK); + writel(MMC_DEFAULT_MASK, mmcaddr + MMC_XGMAC_FPE_RX_INTR_MASK); writel(MMC_DEFAULT_MASK, mmcaddr + MMC_XGMAC_RX_IPC_INTR_MASK); }