diff mbox series

[v1] arm64: dts: imx8-apalis: set wifi regulator to always-on

Message ID 20231123104812.13906-1-francesco@dolcini.it (mailing list archive)
State New, archived
Headers show
Series [v1] arm64: dts: imx8-apalis: set wifi regulator to always-on | expand

Commit Message

Francesco Dolcini Nov. 23, 2023, 10:48 a.m. UTC 
From: Stefan Eichenberger <stefan.eichenberger@toradex.com>

Make sure that the wifi regulator is always on. The wifi driver itself
puts the wifi module into suspend mode. If we cut the power the driver
will crash when resuming from suspend.

Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Fabio Estevam Nov. 23, 2023, 10:52 a.m. UTC | #1 
Hi Francesco,

On Thu, Nov 23, 2023 at 7:48 AM Francesco Dolcini <francesco@dolcini.it> wrote:
>
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
>
> Make sure that the wifi regulator is always on. The wifi driver itself
> puts the wifi module into suspend mode. If we cut the power the driver
> will crash when resuming from suspend.
>
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>

I think this one deserves a Fixes tag.
Francesco Dolcini Nov. 23, 2023, 10:56 a.m. UTC | #2 
Hello Fabio,

On Thu, Nov 23, 2023 at 07:52:27AM -0300, Fabio Estevam wrote:
> On Thu, Nov 23, 2023 at 7:48 AM Francesco Dolcini <francesco@dolcini.it> wrote:
> >
> > From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> >
> > Make sure that the wifi regulator is always on. The wifi driver itself
> > puts the wifi module into suspend mode. If we cut the power the driver
> > will crash when resuming from suspend.
> >
> > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> I think this one deserves a Fixes tag.

Fixes: ad0de4ceb706 ("arm64: dts: freescale: add initial apalis imx8 aka quadmax module support")

Shawn, I assume you could just pick the Fixes tag without me sending a
v2, if you disagree just speak-up.

Francesco
Shawn Guo Dec. 6, 2023, 1:48 a.m. UTC | #3 
On Thu, Nov 23, 2023 at 11:56:39AM +0100, Francesco Dolcini wrote:
> Hello Fabio,
> 
> On Thu, Nov 23, 2023 at 07:52:27AM -0300, Fabio Estevam wrote:
> > On Thu, Nov 23, 2023 at 7:48 AM Francesco Dolcini <francesco@dolcini.it> wrote:
> > >
> > > From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> > >
> > > Make sure that the wifi regulator is always on. The wifi driver itself
> > > puts the wifi module into suspend mode. If we cut the power the driver
> > > will crash when resuming from suspend.
> > >
> > > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > 
> > I think this one deserves a Fixes tag.
> 
> Fixes: ad0de4ceb706 ("arm64: dts: freescale: add initial apalis imx8 aka quadmax module support")
> 
> Shawn, I assume you could just pick the Fixes tag without me sending a
> v2, if you disagree just speak-up.

Applied with the Fixes tag, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
index 5ce5fbf2b38e..f69b0c17560a 100644
--- a/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi
@@ -82,12 +82,9 @@  reg_module_wifi: regulator-module-wifi {
 		pinctrl-0 = <&pinctrl_wifi_pdn>;
 		gpio = <&lsio_gpio1 28 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
+		regulator-always-on;
 		regulator-name = "wifi_pwrdn_fake_regulator";
 		regulator-settling-time-us = <100>;
-
-		regulator-state-mem {
-			regulator-off-in-suspend;
-		};
 	};
 
 	reg_pcie_switch: regulator-pcie-switch {