From patchwork Fri Nov 24 08:06:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13467136 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA469C61D97 for ; Fri, 24 Nov 2023 08:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K4fVaZiSgtEmFki6MKPeI/05lVPN4xJfqIhV2A1Gqaw=; b=RJfQSjdIv/J7Ga OIsdCgMe4A6MjKBaQvpM598ENII8mh7wJUwYxrf53CS5obbYHeADd9NLXPLKnMpF3IfNVnhsxIJ7Y uFIBWZLAyiRR1IeG3DsNh5TAcxAlWQGd44v546yMhfVf/UtZa4oovayCMUCk5EqnNQrM1vJk8LPsc Co+bDCvAniv/iBaCIhc/bHiPRHHhQjNu6aCIHF7jaO5MZW1wmvtoDV9BySC34e1vdaxRQUTl3yqqr +qmdFlNBM27wp8k8073jYhowUlkG9cGBlCBjgehtW+FYXO3CgguqhiJZBWeTTy4fCJDa7sXwiNpSg HJAcjO91BkOEQvPZAq4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6RHC-006TIg-1t; Fri, 24 Nov 2023 08:11:02 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6RH8-006TDq-1V for linux-arm-kernel@lists.infradead.org; Fri, 24 Nov 2023 08:10:59 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6RGp-0005Ko-Tt; Fri, 24 Nov 2023 09:10:39 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6RGp-00BDab-Fu; Fri, 24 Nov 2023 09:10:39 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6RGp-007Hhq-5q; Fri, 24 Nov 2023 09:10:39 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Ulf Hansson , Shawn Guo , Sascha Hauer , Linus Walleij , Arnd Bergmann , "Rafael J. Wysocki" Cc: Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 6/9] pmdomain: imx93-blk-ctrl: Convert to platform remove callback returning void Date: Fri, 24 Nov 2023 09:06:30 +0100 Message-ID: <20231124080623.564924-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231124080623.564924-1-u.kleine-koenig@pengutronix.de> References: <20231124080623.564924-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1973; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=qlTqRAkHlYmqKK29fATW8unizLMrfP09jkrBAih35fw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlYFmG/UN8qYgG4O1CAZiiL7Pgwp2kRFh2lpG9c rcJb5XPWPKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZWBZhgAKCRCPgPtYfRL+ TjhvCACxH0KfYKXiutfgoinNuzIIxkpnBLcXyGmmDksEkYt1HQdGYhuc0HveuhkcvNn7q6HkxRH XgWShZ1hyUiXNTUKxMrrvhXcUzBLQnMDaZ8WChtpvDUwNKk///wHYIH7V2ltNnKMLMO6WmF1IV1 6nkoZ49n765pD0YoVemRbtyniNnL8f3GwntkOmoepA8hCVF5e7JaXDpQ6yt/n3Lbnf0Daq3QesD HDDy5dc5bjqiP3KF+mNDd449hONfGmujz1/IBm5r976ZL7bz+n/uzwg/uo9joL8q2r20JI1EKHT 8T+0dX/70a8IQsg91ItxYEj5ZZt14QXMFI5QhKzYYmVc9mJo X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231124_001058_509748_6A6469E4 X-CRM114-Status: GOOD ( 16.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pmdomain/imx/imx93-blk-ctrl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pmdomain/imx/imx93-blk-ctrl.c b/drivers/pmdomain/imx/imx93-blk-ctrl.c index 40bd90f8b977..904ffa55b8f4 100644 --- a/drivers/pmdomain/imx/imx93-blk-ctrl.c +++ b/drivers/pmdomain/imx/imx93-blk-ctrl.c @@ -306,7 +306,7 @@ static int imx93_blk_ctrl_probe(struct platform_device *pdev) return ret; } -static int imx93_blk_ctrl_remove(struct platform_device *pdev) +static void imx93_blk_ctrl_remove(struct platform_device *pdev) { struct imx93_blk_ctrl *bc = dev_get_drvdata(&pdev->dev); int i; @@ -318,8 +318,6 @@ static int imx93_blk_ctrl_remove(struct platform_device *pdev) pm_genpd_remove(&domain->genpd); } - - return 0; } static const struct imx93_blk_ctrl_domain_data imx93_media_blk_ctl_domain_data[] = { @@ -438,7 +436,7 @@ MODULE_DEVICE_TABLE(of, imx93_blk_ctrl_of_match); static struct platform_driver imx93_blk_ctrl_driver = { .probe = imx93_blk_ctrl_probe, - .remove = imx93_blk_ctrl_remove, + .remove_new = imx93_blk_ctrl_remove, .driver = { .name = "imx93-blk-ctrl", .of_match_table = imx93_blk_ctrl_of_match,