From patchwork Wed Nov 29 14:44:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13472957 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0DB1C46CA3 for ; Wed, 29 Nov 2023 14:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FIfJJVt1ojfaavK4o8mmuF+6fxAFAEqu2p8hmm1FWyk=; b=Kc3X0iJRvMdY38 hLssRkj7sr50J9HzapKQyQco61FPhAprReaVaL6xFfIf39Je8wCmj6suz86559Q9yUADamLOkXHLJ H4FSTHBq0m8Ys4JoscpTUPF8K9TTTFjvBieAiC+2e8/9SPv+CKr7dtg2EtOXXLrTjasRSKzEADzHh Suf/zUoTMWtkd9fhc0TzYqs+8LfZHuW/F/0pyU3+mK3vYGfEdEMaDufiZlKMvo7wGywigxMZFZcUF P8KFfjMPUVUy6bnwxBg0b+IXmb8AmSTzptpq2MIM/tNsMhtk9UlZB8IOPIn9BD85PkOt3YLT+tDlY qsTuoO3k4L6zU1KDE9Ag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8Lnv-008f7E-1B; Wed, 29 Nov 2023 14:44:43 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8Lnl-008ex3-0G for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 14:44:35 +0000 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a00cbb83c80so935244766b.0 for ; Wed, 29 Nov 2023 06:44:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701269072; x=1701873872; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9K/KL6rUHA7mDcBMrrqIFDkXaVSeDD2iYf5D2W8YBIg=; b=Z6n+dnrnVnOBE5FDEGFg2PsImyUeggyNo+/lfPpI8UMu/4b/dY/NNAT2lZI6yflSpy 2LPNbCwgyBopEbVnVYWO4FRpFewxEw5H1SLH2/NF4Ay24U334LNyAf68JRwh7g03I25P uWaL1RW//jQeGI+15k8X/JDSxnzX6MLBrCGTFY8TQGTd9hCRsmQsXyAw0wfUGcyU7dJt /HADtNjif7gb4ulo2n9/pELUjumZrJJXfPm4wVQYfzmL+lDzngtiiBD47TGw6899BRfO wS0ehoO8zR/MVCPfT6D56PyjoyVCbOBF9XIZmtvwdVgbSxOv4tTtLGsDM56Qv37AMviV Q7uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701269072; x=1701873872; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9K/KL6rUHA7mDcBMrrqIFDkXaVSeDD2iYf5D2W8YBIg=; b=Z1vm5F1tl59UF+JDLeEKaiCtbHR9dllns4JuVYTjAY9MUHtzBpM//pJ7OBonQjqaw8 i/lYq39D4IxMoiKs+3XSx5NUVeECqqe1QBag4ruAugHeLYF4k9I2ApzOEGZBQu34hwMf 4DWGO/MdBtKo5YjAsO9hfNZtL2UmmHExJto5egaYBWG5CtFznu4Fdr0gRlv8KX4UPUY4 8lzs+26iCde1Aqs+powalaAmGpuIn6+W5p/5gkUgfyhHUaQmDoIn/23GHuytUcOahyeE wWeC4JAb5rtrt2vimE2Dt+qKQzGQ9L/3FSkLF7iDvX0SjMvypuf+nX1NG1tY0tocWdiJ RSmg== X-Gm-Message-State: AOJu0YyQoarRBiBDXem0wMCkv13AAq8Wq0dTMagpZ8mSs3MLPWZcCTyI D7FLGmpjC/IcsaEbKElRLMM4Yg== X-Google-Smtp-Source: AGHT+IGjVdN7cz5padHg+T+KRoFbmsMzhIWory1lFuWkxTuEmzq2syYeBQUInK/9FTSsztA+J2jYow== X-Received: by 2002:a17:906:2219:b0:a16:8d1b:5b13 with SMTP id s25-20020a170906221900b00a168d1b5b13mr3159519ejs.73.1701269071739; Wed, 29 Nov 2023 06:44:31 -0800 (PST) Received: from [10.167.154.1] (178235187166.dynamic-4-waw-k-2-3-0.vectranet.pl. [178.235.187.166]) by smtp.gmail.com with ESMTPSA id e27-20020a1709062c1b00b009fda627abd9sm7913738ejh.79.2023.11.29.06.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 06:44:31 -0800 (PST) From: Konrad Dybcio Date: Wed, 29 Nov 2023 15:44:04 +0100 Subject: [PATCH v3 07/12] arm64: dts: qcom: sc7280: Add the missing MDSS icc path MIME-Version: 1.0 Message-Id: <20231125-topic-rb1_feat-v3-7-4cbb567743bb@linaro.org> References: <20231125-topic-rb1_feat-v3-0-4cbb567743bb@linaro.org> In-Reply-To: <20231125-topic-rb1_feat-v3-0-4cbb567743bb@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Loic Poulain , Bryan O'Donoghue , Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Georgi Djakov , Will Deacon , Robin Murphy , Joerg Roedel , Krishna Manikandan , Robert Marko , Das Srinagesh , cros-qcom-dts-watchers@chromium.org Cc: Marijn Suijten , Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1701269042; l=1493; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=RpzLMWuMbYjvqQjs1yjMVMPj1VmkWicMXA9dO0pSXPQ=; b=idb266kdiffZu3Aqa8UlqEsL6fRd558KK+7szhEZHwR5Nruiw3g141r8j8bfrnqsrqdUyCE8W EO6Zzca5zhMB+0xwj+IunhA6686/xhyDdRSJIxzzge1Fic1shg6vvOS X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_064433_121671_3BCDB529 X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MDSS, aside from the MDP-MEM path, also requires the CPU-DISP_CFG one. Failing to provide it may result in register accesses failing and that's never good. Add the missing path. Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 04bf85b0399a..41d327b1f1b6 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -3958,8 +3959,12 @@ mdss: display-subsystem@ae00000 { interrupt-controller; #interrupt-cells = <1>; - interconnects = <&mmss_noc MASTER_MDP0 0 &mc_virt SLAVE_EBI1 0>; - interconnect-names = "mdp0-mem"; + interconnects = <&mmss_noc MASTER_MDP0 QCOM_ICC_TAG_ALWAYS + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS + &cnoc2 SLAVE_DISPLAY_CFG QCOM_ICC_TAG_ALWAYS>; + interconnect-names = "mdp0-mem", + "cpu-cfg"; iommus = <&apps_smmu 0x900 0x402>;