From patchwork Mon Nov 27 11:45:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Zyngier X-Patchwork-Id: 13469424 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2C6FC07CB1 for ; Mon, 27 Nov 2023 11:46:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Lq+I6kTUbKLo+owu08f4bWu3gPCFq8sOOEDAmAt/W8c=; b=uMyNFeugPeJf+f 1EPl8u6TaeBxKn0Regc0ncrhZ7yDvt0EQvmsKK6jSkEpxrnNaVqPYUEZOfYQEkk785h97BsGfqfq/ OUaPa7wDnrajYOB2a3gEErRL0mjVrak+b3ddaKXuVn4MB76PPIBx7t8AtsrxywTsu8SBtUw1KHW2n TKqajmPtckVeby5wq4LPtJ4MqDJwKg+DJ6N8EyRrrHVoojdlwCZJucKuBG4XQrUxpUbVBzIDPd8u1 EiCH1Lxay8sn7YLT3gxXeQB40xKv3JJm3PW8JRyNUYb5mnnrACRCl6aUjsxBG0o3aFzkupBucgQPo 0jtTT8pmH2nC1p4iOIgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7a4K-002IL9-1S; Mon, 27 Nov 2023 11:46:28 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7a41-002I2F-1x for linux-arm-kernel@lists.infradead.org; Mon, 27 Nov 2023 11:46:11 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 50B8ECE10F8; Mon, 27 Nov 2023 11:46:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA7B5C433C7; Mon, 27 Nov 2023 11:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701085566; bh=+V9YPjvEYXSSt60U3gViHm0Gqh4URgGIV2rxi/DYKhY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D2mTBcl1gv6m7LRzMsDkctB4ruZqxQxLcoB79jOVaRkl+4xcpfF9SlFbLg+AGSkp/ ioi+deqtQ74MtlTffgf1Dl6+RNsZwohHF/hLBaGa6wDJnl8KnYqZK5U4UoeKa5GRWZ uWIJLtriT6t0zpmd6vfK8rRjBZykUhc/J3yh6FqD2wJzr5fNGFeSNRRi5aaVyxRQi2 gL8WunrOAbUjH7hP0wAwrNfp8F0jZNToiAuuoGlMSRZ5pV0TaiPOGXhXuS9IjDhpaf PN469MkRTbNqZAhsPiQmdGNFd15iXHCKF1hjy9+QcSvu8B2azn3ISBmSg2xDtyGGqK 6c9EZGxSehR4Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=valley-girl.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1r7a3w-00GleL-Ij; Mon, 27 Nov 2023 11:46:04 +0000 From: Marc Zyngier To: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Will Deacon , Mark Rutland , Ard Biesheuvel , James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: [PATCH v3 03/13] arm64: cpufeature: Correctly display signed override values Date: Mon, 27 Nov 2023 11:45:49 +0000 Message-Id: <20231127114559.990314-4-maz@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231127114559.990314-1-maz@kernel.org> References: <20231127114559.990314-1-maz@kernel.org> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, ardb@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231127_034609_991362_C32F9939 X-CRM114-Status: GOOD ( 12.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When a field gets overriden, the kernel indicates the result of the override in dmesg. This works well with unsigned fields, but results in a pretty ugly output when the field is signed. Truncate the field to its width before displaying it. Reviewed-by: Oliver Upton Reviewed-by: Suzuki K Poulose Signed-off-by: Marc Zyngier --- arch/arm64/kernel/cpufeature.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index bc8787f28ffd..9c3ded9635dd 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c @@ -949,7 +949,8 @@ static void init_cpu_ftr_reg(u32 sys_reg, u64 new) pr_warn("%s[%d:%d]: %s to %llx\n", reg->name, ftrp->shift + ftrp->width - 1, - ftrp->shift, str, tmp); + ftrp->shift, str, + tmp & (BIT(ftrp->width) - 1)); } else if ((ftr_mask & reg->override->val) == ftr_mask) { reg->override->val &= ~ftr_mask; pr_warn("%s[%d:%d]: impossible override, ignored\n",