| Message ID | 20231128005849.19044-3-andre.przywara@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for H616 Thermal system | expand |
On 28/11/2023 01:58, Andre Przywara wrote: > From: Martin Botka <martin.botka@somainline.org> > > This controller is similar to the H6, but covers four sensors and uses > slightly different calibration methods. > Also the H616 requires to poke a bit in the SYS_CFG register range for > correct operation, so add a "syscon" phandle property to point there. > > Signed-off-by: Martin Botka <martin.botka@somainline.org> > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > .../thermal/allwinner,sun8i-a83t-ths.yaml | 30 ++++++++++++------- > 1 file changed, 20 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > index fbd4212285e28..95a6ab9a5889b 100644 > --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml > @@ -20,6 +20,7 @@ properties: > - allwinner,sun50i-a100-ths > - allwinner,sun50i-h5-ths > - allwinner,sun50i-h6-ths > + - allwinner,sun50i-h616-ths > > clocks: > minItems: 1 > @@ -63,6 +64,7 @@ allOf: > enum: > - allwinner,sun50i-a100-ths > - allwinner,sun50i-h6-ths > + - allwinner,sun50i-h616-ths > > then: > properties: > @@ -80,6 +82,18 @@ allOf: > clock-names: > minItems: 2 > > + - if: > + properties: > + compatible: > + contains: > + const: allwinner,sun50i-h616-ths > + > + then: > + properties: > + syscon: Nope, there is no such property. First of all, properties must be defined in top level. Second of all - this is exactly the example I used for my talk. Two times. > + maxItems: 1 > + description: phandle to syscon device allowing access to SYS_CFG registers You must also say what is the purpose. Drop redundant parts like "phandle to syscon device allowing access" and explain what is the hardware. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml index fbd4212285e28..95a6ab9a5889b 100644 --- a/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml +++ b/Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml @@ -20,6 +20,7 @@ properties: - allwinner,sun50i-a100-ths - allwinner,sun50i-h5-ths - allwinner,sun50i-h6-ths + - allwinner,sun50i-h616-ths clocks: minItems: 1 @@ -63,6 +64,7 @@ allOf: enum: - allwinner,sun50i-a100-ths - allwinner,sun50i-h6-ths + - allwinner,sun50i-h616-ths then: properties: @@ -80,6 +82,18 @@ allOf: clock-names: minItems: 2 + - if: + properties: + compatible: + contains: + const: allwinner,sun50i-h616-ths + + then: + properties: + syscon: + maxItems: 1 + description: phandle to syscon device allowing access to SYS_CFG registers + - if: properties: compatible: @@ -97,16 +111,12 @@ allOf: const: 1 - if: - properties: - compatible: - contains: - enum: - - allwinner,sun8i-h3-ths - - allwinner,sun8i-r40-ths - - allwinner,sun50i-a64-ths - - allwinner,sun50i-a100-ths - - allwinner,sun50i-h5-ths - - allwinner,sun50i-h6-ths + not: + properties: + compatible: + contains: + enum: + - allwinner,sun8i-a83t-ths then: required: