From patchwork Wed Nov 29 06:02:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13472247 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C16A3C4167B for ; Wed, 29 Nov 2023 06:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:From:Subject:References:Mime-Version :Message-Id:In-Reply-To:Date:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IopEWHMhmwrmgHoYdTLHUZN8v7hTEkhccs5sdLVieMo=; b=HWKFFMM+YscnTU yCR5Hp64VnIz4agwc5Xx3aOtDR1pO37lCjBh1iHfMUTxPc685UtdOzGd9CyItZJR8QqigNK9hXUn0 jP3YuYhm0KjMLkl9x2Z+3982A9s21raNJMmsfV82L86xf3wRhxWqtopaxC4PqzAhJl1dKP5ocLgPT jrvMw39aO+V5437hZ0mARrLAkNEpOZ+JexE21ADO1yrHmgWvse4NpIXepYq8YmDlCzNZu65NjN2tj MOpUsjo28rQtgoRHwthQhL1vO+0EisVPimvYVDwmPDSCDg+1jncCzE4qk8/Kp/pddbmPGghI38LI6 12MLyJ/ZzcazmOWbilSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8Dfc-007A1H-1U; Wed, 29 Nov 2023 06:03:36 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8Dek-0079JM-1q for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 06:02:44 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-daf702bde7eso6645677276.3 for ; Tue, 28 Nov 2023 22:02:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701237761; x=1701842561; darn=lists.infradead.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=0DVMbIRV+NQmnATStJOD8jb70rfi854C2wLg/boNolQ=; b=PGKnA66ld6OgU9fy2BneUY+zoxGhdGmyHEDhfR5IRfQaAKfk/+3ecxh0sRhFQ4Mdr5 0cBMrKFItgQNlNlhPWseNSvoPSy89nlswrqNdX8yWkc7atm5ILVONookGryfa2khU0f8 saUgjkEpqw18L8zAqjBLiDG0V8ZGM+qnKbwkBruQWIY4qhIqZwsqYHKWhbnXe8VTiUMy MrE9iAWZ7idqoAsSm7awbMr3z9LWXaaJgfbCG57NgY+WSsO+5ZLSDMdNGXInnpcEAbcs zAH0XPlOpfQdJRpE0f6bTlNlzpw79pIvnSsDyQG7Kyf1h75yUeH8gRJLHozrGDdvIKBv +ijQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701237761; x=1701842561; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0DVMbIRV+NQmnATStJOD8jb70rfi854C2wLg/boNolQ=; b=e11uunnTVw3J6pZRKZMm/dC03YNXoxEX+1DHCXuhItmVhN2K+qH3XdpCjc45rM/Yi5 VRZfEFFgKb/35u7ujlnYC6tX4i0mis6ZD+fMKWdQ8fr6HHy7FbUI91iadrYmTT2Z+6Iu IeiEZnWx2wCDylrwpz68DRFeYJseMmxpCgYy4tG8m2hpKJCjANRsMyZZfxrthrLNba69 wvtiAFXR5Mfj3FVYRm7N74aaunr7i0rq1bIp4uhWposL2WdBxtAfM7bkeXAg0XgqXJnp gBa3y8DVrhBiFX0xI1XrSCfkftA/Lv7lME0lljrcXBP+R3SrePwTpKmPopoUHdnPyPH2 5lxQ== X-Gm-Message-State: AOJu0Yy86zEXH+xblnx/QA/m1C6FDs1UOfVm746Oy9DFhHn4JIh5wwsP 6G6ZuskrGgjw3fLaKVvuP+Hlhsq+2bPW X-Google-Smtp-Source: AGHT+IHJMRqYtdqiq8wS3BvtGG3WjhuhilD2hoypqMhKE4FVBpXobXp8Db6UyUfeaAWJBMxnRYUQrmZznlQj X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:763b:80fa:23ca:96f8]) (user=irogers job=sendgmr) by 2002:a25:e4c5:0:b0:d9c:801c:4230 with SMTP id b188-20020a25e4c5000000b00d9c801c4230mr494820ybh.5.1701237761085; Tue, 28 Nov 2023 22:02:41 -0800 (PST) Date: Tue, 28 Nov 2023 22:02:08 -0800 In-Reply-To: <20231129060211.1890454-1-irogers@google.com> Message-Id: <20231129060211.1890454-12-irogers@google.com> Mime-Version: 1.0 References: <20231129060211.1890454-1-irogers@google.com> X-Mailer: git-send-email 2.43.0.rc1.413.gea7ed67945-goog Subject: [PATCH v1 11/14] perf arm64 header: Remove unnecessary CPU map get and put From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , John Garry , Will Deacon , Thomas Gleixner , Darren Hart , Davidlohr Bueso , " =?utf-8?q?Andr=C3=A9_Almeida?= " , Kan Liang , K Prateek Nayak , Sean Christopherson , Paolo Bonzini , Kajol Jain , Athira Rajeev , Andrew Jones , Alexandre Ghiti , Atish Patra , "Steinar H. Gunderson" , Yang Jihong , Yang Li , Changbin Du , Sandipan Das , Ravi Bangoria , Paran Lee , Nick Desaulniers , Huacai Chen , Yanteng Si , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231128_220242_646990_C8F23214 X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In both cases the CPU map is known owned by either the caller or a PMU. Signed-off-by: Ian Rogers Reviewed-by: James Clark --- tools/perf/arch/arm64/util/header.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/perf/arch/arm64/util/header.c b/tools/perf/arch/arm64/util/header.c index 97037499152e..a9de0b5187dd 100644 --- a/tools/perf/arch/arm64/util/header.c +++ b/tools/perf/arch/arm64/util/header.c @@ -25,8 +25,6 @@ static int _get_cpuid(char *buf, size_t sz, struct perf_cpu_map *cpus) if (!sysfs || sz < MIDR_SIZE) return EINVAL; - cpus = perf_cpu_map__get(cpus); - for (cpu = 0; cpu < perf_cpu_map__nr(cpus); cpu++) { char path[PATH_MAX]; FILE *file; @@ -51,7 +49,6 @@ static int _get_cpuid(char *buf, size_t sz, struct perf_cpu_map *cpus) break; } - perf_cpu_map__put(cpus); return ret; }