From patchwork Fri Dec 1 13:20:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475818 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31A57C4167B for ; Fri, 1 Dec 2023 13:31:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pIvF1lKldyfiG002BqS+9yoSsgfv9vDSeOz66bwsGow=; b=E4HsEHxMuIXYHN 5eRePjXX04XTpEx+scIaGeUfV4KilvoArl7a7nLZ1lTt1UerkJ/HukMeDA9dkG/UjhK/TdqO3uiBA bFqUALsKxKzVdGtXQTgcuZIy8Ml76RUo9tDXBI5UUrW/gGMLhj5nOh2Q6xkmXgM4nbFp9/zHjHNuq pRfOsnbILvu8DpZADcKsaAtFaNkR5pE0S5/ClBEhvOsJqp8Q4lg/4uxcgAmrU7/VKNE4rj+B8q93L gZArU0vtitu2GaraeuGXcZzpP1i+9AMO4wpErKZlKhMoM92i4OYSAjn53yv8mutmm61odsz5Si1kZ phHHa2XAOW5ZiqPfJV7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r93c0-00DoKU-0V; Fri, 01 Dec 2023 13:31:20 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r93Re-00DjQs-04 for linux-arm-kernel@lists.infradead.org; Fri, 01 Dec 2023 13:20:39 +0000 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-50bc22c836bso3028908e87.0 for ; Fri, 01 Dec 2023 05:20:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436834; x=1702041634; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hvwEnfEWC7X3PkrakUYA7rH73mlgP4mcx3Rphz/0vOk=; b=Y3bhb1UWtscc7A2UvJzODi504UcRk0++YiK2IG17Xiv98MnhwQU4vX5RT8x+lPzVxM maSxKQbK5ZWyQ5nv+EPA4qYvHGsMYydILqUTxrPkFfrowYTt/MTBv2c7LR9zcr/xlsCd ybbOLNa2lk7LCTpLExBv14qzaO9zOxMQZtDd/GYwxjjkvMuKuS73TC09RrpZiubAvABY Cw+31fUT6wm6oiK1/FtrIF4zXUboeBxozGikB0yNaU17jwLWN1EiIXis6Sf09ZgS7YHP WvI0duo6AzYfyl3u/FpPux9w0PUyJCw5APX0kqyh8oIUjVPHpGmB+JfKUcmKvLQBJIeD nxpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436834; x=1702041634; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hvwEnfEWC7X3PkrakUYA7rH73mlgP4mcx3Rphz/0vOk=; b=G08N8MMlE5Fuwgl64LAQVCIOOb+scoNRLQUFqrs+82avq5CMZ0Iiz1VTErNjg90MXK qrkDQfdxzHgvzxIAo4S/jBw+dsDoQ1ENJtmOP8tYvPofczbWYa00VSDMmz1xNBFTxDdr 1o3JjymzNGaQ97d34zV02M8Yu4p0jZWlZ8vjj3oMef6rC8SAs+R3CH5tdj6El4qCqM4X Da6LpCZawEGhp0EE5hDjfMIvw6XRxi5t8T3gahBC8PPBrq5s1ZkRK8xYl3zSvIYyDgHY yjykvLDl+rgEzRNGFdFDq0sjJUFZzAckJgDTImcl+tGjNXCOrrUMMdClwAB7oosA+/AT b7Tg== X-Gm-Message-State: AOJu0YxbZSV0DcAGE3JuPaS9hq1OCu7FlIivLb9xy0eJ9oPpCmVxIPHH NZEyR3nHMjtiTbi+01docj9mwA== X-Google-Smtp-Source: AGHT+IHy8r+VGJLhcKYulz95n0Llz8QkGNwo3fVIlOQzYeCx6OX80VUxPFF/MbvUz9dVuCcnHSKjPw== X-Received: by 2002:a05:6512:36d2:b0:50b:d764:6ec8 with SMTP id e18-20020a05651236d200b0050bd7646ec8mr745977lfs.120.1701436834148; Fri, 01 Dec 2023 05:20:34 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:33 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:31 +0100 Subject: [PATCH v2 02/10] ASoC: cs35l33: Fix GPIO name and drop legacy include MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-2-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231201_052038_059231_7184F320 X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "reset" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.") Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l33.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c index 4010a2d33a33..a19a2bafb37c 100644 --- a/sound/soc/codecs/cs35l33.c +++ b/sound/soc/codecs/cs35l33.c @@ -22,13 +22,11 @@ #include #include #include -#include #include #include #include #include #include -#include #include #include "cs35l33.h" @@ -1165,7 +1163,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client) /* We could issue !RST or skip it based on AMP topology */ cs35l33->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_HIGH); + "reset", GPIOD_OUT_HIGH); if (IS_ERR(cs35l33->reset_gpio)) { dev_err(&i2c_client->dev, "%s ERROR: Can't get reset GPIO\n", __func__);