From patchwork Fri Dec 1 13:20:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475820 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6272C46CA0 for ; Fri, 1 Dec 2023 13:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EpXIjXZDql0TgHdQi8SpukTlrkMVfbJz8Mal4UjXDo0=; b=hpcdWBV/CgTp+j UKXTQDwvPe29LmUq1OIzYf4mO4ZRqv+VeMBwJGp805fRkzC+7EsFIyeiL46tTha+66WxMEGgTYAqe TtEg8LctIh8abkO8952f7oofdQS2Z0msEz0EJz5butJFkRqY1e1o1sP+KLnC3zC1lYJbp9+KQpu8k 6jzBd8moa3B1Hmwtg3HTs/Fi2NfVMGEFnZ5+1/ZBfZld9RJXoK/53Ws3k53djHqxV2bUyKgKeURjn nRyKUt++TX8aQtl558vsMZh3vJTnW8yR936JpJw7Osln04sfi5BFyWX7fLa33pwAG7fwkowTlSm6N MFmwH8bLtMPfdNHV/lmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r93c1-00DoLS-19; Fri, 01 Dec 2023 13:31:21 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r93Rf-00DjRS-0v for linux-arm-kernel@lists.infradead.org; Fri, 01 Dec 2023 13:20:40 +0000 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-50bc4fe8158so3001576e87.0 for ; Fri, 01 Dec 2023 05:20:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436835; x=1702041635; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lDKFgSOaPuVFur80bPhP3dFYnn3zUMFtVllkw5He9o4=; b=pDN7HPTCFHiImK3hdzaQu5GtFcvxSXHk2CBUIk0rQbrHK2Ur1MxRTL9DmZO9M4qqs0 e8Qn3PN2zJpX3IbD6c7NIE4x9knBIhAxhpAPAb8Clxf8xanL3g7tivLXIUdMx6igi2S9 RWZjkxuaohQ0JJEvZsf7c+1qdqWDQdys1N0jGymUXk9ovu/6DDd96bFaigPyfma3vavW hO+bYFXhM6LrI42qC9l06PdrKOJwy7x5QpUN1b5OWvJkOPUu+nPMbFaI1uU3KvT4JcgB V7D3jLU1kqEvuUAwhfRjU6huiEMoAXRG+x0S7ffxbFTZjnhNLIwQROFqGFJg8Trz3Gqu eM4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436835; x=1702041635; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lDKFgSOaPuVFur80bPhP3dFYnn3zUMFtVllkw5He9o4=; b=mP/45UOxDv/Q8OaPZXLJ4jvL1Mo7QZ/6G21mpNbPr+tgRfe2PMfTGZeh4kpjH9ThS3 jOlQyPRiSshkAbkFRU5T5skAFt3VnzX72Np0M7QwYgLLZvOyX/wiJ0oy0JuO0D4QP0C3 fp5CCT+nFNwUWr4ed5TtO1gGJgHtbJ6Cobmr46QZR+PQUNVpOYU3sX2O3LN+H46jzuIN l4l6oMeFYEEct5zEN+ih6Qv9xogzRlwfsLe0m+9tCw9gufBSm+Ai0K2KatWciJXPIGD9 ozz0v/00lSHoWRzCx6lNrurUG1dk5uYd/mbaQ2BH6XAZ7FXVjAaKUOgwoVS7ec+bMlXn w4XA== X-Gm-Message-State: AOJu0Yy7Ie05KT734ZmaXIaetJNe3TP9lfoAasGdsn0MzkI9u/FcRow8 C7M2Kzq5SobaiprHvoRsJ26G1A== X-Google-Smtp-Source: AGHT+IHPhwhCcZemWJXPkwH3F0g8I2ogdr+dlRUEBR2WBwxAYjUakxV0jDfSRYYeCIC7/cyqXFUOUQ== X-Received: by 2002:a05:6512:615:b0:50b:d764:9683 with SMTP id b21-20020a056512061500b0050bd7649683mr765669lfe.103.1701436835426; Fri, 01 Dec 2023 05:20:35 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:34 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:32 +0100 Subject: [PATCH v2 03/10] ASoC: cs35l34: Fix GPIO name and drop legacy include MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-3-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231201_052039_352506_112D68A6 X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "reset" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: c1124c09e103 ("ASoC: cs35l34: Initial commit of the cs35l34 CODEC driver.") Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l34.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l34.c b/sound/soc/codecs/cs35l34.c index e5871736fa29..cca59de66b73 100644 --- a/sound/soc/codecs/cs35l34.c +++ b/sound/soc/codecs/cs35l34.c @@ -20,14 +20,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include @@ -1061,7 +1059,7 @@ static int cs35l34_i2c_probe(struct i2c_client *i2c_client) dev_err(&i2c_client->dev, "Failed to request IRQ: %d\n", ret); cs35l34->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_LOW); + "reset", GPIOD_OUT_LOW); if (IS_ERR(cs35l34->reset_gpio)) { ret = PTR_ERR(cs35l34->reset_gpio); goto err_regulator;