diff mbox series

[2/2] ARM: dts: imx23/28: Remove undocumented "fsl,clkctrl"

Message ID 20231205144713.2053916-2-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/2] ARM: mxs: Do not search for "fsl,clkctrl" | expand

Commit Message

Fabio Estevam Dec. 5, 2023, 2:47 p.m. UTC
From: Fabio Estevam <festevam@denx.de>

Per imx23-clock.yaml and imx28-clock.yaml, fsl,clkctrl is not a valid
compatible string.

Remove it to fix the following dt-schema warning:

imx28-evk.dtb: clkctrl@80040000: compatible: ['fsl,imx28-clkctrl', 'fsl,clkctrl'] is too long
	from schema $id: http://devicetree.org/schemas/clock/imx28-clock.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/mxs/imx23.dtsi | 2 +-
 arch/arm/boot/dts/nxp/mxs/imx28.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Stefan Wahren Dec. 5, 2023, 6:54 p.m. UTC | #1
Hi Fabio,

Am 05.12.23 um 15:47 schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> Per imx23-clock.yaml and imx28-clock.yaml, fsl,clkctrl is not a valid
> compatible string.
>
> Remove it to fix the following dt-schema warning:
>
> imx28-evk.dtb: clkctrl@80040000: compatible: ['fsl,imx28-clkctrl', 'fsl,clkctrl'] is too long
> 	from schema $id: http://devicetree.org/schemas/clock/imx28-clock.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>   arch/arm/boot/dts/nxp/mxs/imx23.dtsi | 2 +-
>   arch/arm/boot/dts/nxp/mxs/imx28.dtsi | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
> index fdf18b7cb2f6..69e65e218afe 100644
> --- a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
> +++ b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
> @@ -484,7 +484,7 @@ apbx@80040000 {
>   			ranges;
>
>   			clks: clkctrl@80040000 {
> -				compatible = "fsl,imx23-clkctrl", "fsl,clkctrl";
> +				compatible = "fsl,imx23-clkctrl";
this look fine:

Reviewed-by: Stefan Wahren <wahrenst@gmx.net>

Btw the node name clkctrl is also incorrect here. According to the yaml
it should be clock-controller.

Regards
>   				reg = <0x80040000 0x2000>;
>   				#clock-cells = <1>;
>   			};
> diff --git a/arch/arm/boot/dts/nxp/mxs/imx28.dtsi b/arch/arm/boot/dts/nxp/mxs/imx28.dtsi
> index 6932d23fb29d..39b59619eb2e 100644
> --- a/arch/arm/boot/dts/nxp/mxs/imx28.dtsi
> +++ b/arch/arm/boot/dts/nxp/mxs/imx28.dtsi
> @@ -1100,7 +1100,7 @@ apbx@80040000 {
>   			ranges;
>
>   			clks: clkctrl@80040000 {
> -				compatible = "fsl,imx28-clkctrl", "fsl,clkctrl";
> +				compatible = "fsl,imx28-clkctrl";
>   				reg = <0x80040000 0x2000>;
>   				#clock-cells = <1>;
>   			};
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
index fdf18b7cb2f6..69e65e218afe 100644
--- a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
+++ b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
@@ -484,7 +484,7 @@  apbx@80040000 {
 			ranges;
 
 			clks: clkctrl@80040000 {
-				compatible = "fsl,imx23-clkctrl", "fsl,clkctrl";
+				compatible = "fsl,imx23-clkctrl";
 				reg = <0x80040000 0x2000>;
 				#clock-cells = <1>;
 			};
diff --git a/arch/arm/boot/dts/nxp/mxs/imx28.dtsi b/arch/arm/boot/dts/nxp/mxs/imx28.dtsi
index 6932d23fb29d..39b59619eb2e 100644
--- a/arch/arm/boot/dts/nxp/mxs/imx28.dtsi
+++ b/arch/arm/boot/dts/nxp/mxs/imx28.dtsi
@@ -1100,7 +1100,7 @@  apbx@80040000 {
 			ranges;
 
 			clks: clkctrl@80040000 {
-				compatible = "fsl,imx28-clkctrl", "fsl,clkctrl";
+				compatible = "fsl,imx28-clkctrl";
 				reg = <0x80040000 0x2000>;
 				#clock-cells = <1>;
 			};