diff mbox series

ARM: dts: imx28-tx28: Pass #sound-dai-cells

Message ID 20231205145335.2055549-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series ARM: dts: imx28-tx28: Pass #sound-dai-cells | expand

Commit Message

Fabio Estevam Dec. 5, 2023, 2:53 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

Per sgtl5000.yaml, '#sound-dai-cells' is a required property.

Pass it to fix the following dt-schema warning:

imx28-tx28.dtb: sgtl5000@a: '#sound-dai-cells' is a required property
	from schema $id: http://devicetree.org/schemas/sound/sgtl5000.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Wahren Dec. 5, 2023, 6:32 p.m. UTC | #1 
Hi Fabio,

Am 05.12.23 um 15:53 schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> Per sgtl5000.yaml, '#sound-dai-cells' is a required property.
>
> Pass it to fix the following dt-schema warning:
>
> imx28-tx28.dtb: sgtl5000@a: '#sound-dai-cells' is a required property
> 	from schema $id: http://devicetree.org/schemas/sound/sgtl5000.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>   arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts b/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts
> index 153e4017951d..5485fe118dc4 100644
> --- a/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts
> @@ -260,6 +260,7 @@ &i2c0 {
>   	sgtl5000: sgtl5000@a {
this patch is fine

Reviewed-by: Stefan Wahren <wahrenst@gmx.net>

but this node name looks wrong.

It should be sgtl5000: codec@a

Regards
>   		compatible = "fsl,sgtl5000";
>   		reg = <0x0a>;
> +		#sound-dai-cells = <0>;
>   		VDDA-supply = <&reg_2p5v>;
>   		VDDIO-supply = <&reg_3p3v>;
>   		clocks = <&mclk>;
Fabio Estevam Dec. 5, 2023, 9:26 p.m. UTC | #2 
Hi Stefan,

On Tue, Dec 5, 2023 at 3:32 PM Stefan Wahren <wahrenst@gmx.net> wrote:

> this patch is fine
>
> Reviewed-by: Stefan Wahren <wahrenst@gmx.net>

Thanks for your review.

> but this node name looks wrong.
>
> It should be sgtl5000: codec@a

Yes, I noticed that too.

I will address this on a separate patch. There are other i.MX DTs that use the
sgtl5000@a format and need to be fixed as well.
Shawn Guo Dec. 6, 2023, 3:18 a.m. UTC | #3 
On Tue, Dec 05, 2023 at 11:53:35AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per sgtl5000.yaml, '#sound-dai-cells' is a required property.
> 
> Pass it to fix the following dt-schema warning:
> 
> imx28-tx28.dtb: sgtl5000@a: '#sound-dai-cells' is a required property
> 	from schema $id: http://devicetree.org/schemas/sound/sgtl5000.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts b/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts
index 153e4017951d..5485fe118dc4 100644
--- a/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts
+++ b/arch/arm/boot/dts/nxp/mxs/imx28-tx28.dts
@@ -260,6 +260,7 @@  &i2c0 {
 	sgtl5000: sgtl5000@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		#sound-dai-cells = <0>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
 		clocks = <&mclk>;