From patchwork Thu Dec 7 18:55:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13483856 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4099C4167B for ; Thu, 7 Dec 2023 18:56:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JOz+xeijikmXwu+gb9nGUMl+ehVOOcabNaybTgAvmz4=; b=rpQZW69beQhWg7 V6dCHMLHS8wB61Y7LDahIWwvJ09YlboZ1Li5UtqkWfyWT/6pNyWwKOM9N/5HOfollx3Yov8lj1fcS CkzJZc9njujlfmNJFDOPAIzoQ9VNILJvTTlBTq1zSluWYhoKvyc7uKKNwmtPYBfGCJIZJlj8VjHwR CNwuj58q1FH4QeEMuqlY8ehtSrI4quewPiBu55n+B6M/L+srgBRN1BB9IR6/47CsHbIQbypZHe2GI 9QVqt31aZpo96Hf7XVjA/3NQdZYq2tE33Qpsjyfut0Qm1pG6qStiCJsO44SXff98Ed8f0laKPgfG8 mm3PQE8s45P15OrQ94LQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBJXT-00DgdJ-0H; Thu, 07 Dec 2023 18:55:59 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBJXO-00DgbE-1j for linux-arm-kernel@lists.infradead.org; Thu, 07 Dec 2023 18:55:56 +0000 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-2866b15b013so246809a91.0 for ; Thu, 07 Dec 2023 10:55:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701975353; x=1702580153; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f92ey//GX+Rbqx09COi87AZGGQWIeZfnPA8hrWm87UE=; b=SlVCEH/CA4OIvbAY2FEy973geYTiXfNqjjuUNTzk0Fzcf/eqFnciwOR/MEsE7NPCOg SZ2UGy9QMFe+dFz6HPSTmnHu4CP1MRDmq/s4couH0jec/+8QwBpIXSugpKvaW9habuUe douyOiQ7Mw5/OxwxUQqG5KO/2LBtHb+PJUsRbkBbVI1mgeEvNLWRS6MMy1PNBOMeQkyF oauAf0t77uMtPrq75USmtfUruRSVE6V3rAuK4aO0HCtXkHTgxNMoR9tlovwpVjc5rjGP Fbsoa8CrND/QOD2GUoazv9wNywqO04Im/cGq2ykb37Txkr5yWIVEun8OnGEX53db7MSQ Oacw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701975353; x=1702580153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f92ey//GX+Rbqx09COi87AZGGQWIeZfnPA8hrWm87UE=; b=DD/Pz9FLaQvoQ26oaQBIfOh+d5YpPoN5exskOhVzg5bld5uusRl7aL+0k8yF30iHHu wsVUAmoxCafLv40Lo/NjiRNDhETbwFgZm4/UMweuGh+TpzQar0j8OB7v/Sc9/PtSkvy5 v/l0OX3QPvj4q2eY2krg8jIutk+jUicTccAik4teHsARWPkuHoJeyIQSMw+Ef5fN//PK WJLbZLa8ivztx63ILugDVglgZOPMIv6vmLY7RppE4wfsotrjlGM1krL/NwOs08jziIML /8Scf2ReMHfYoBasTaN9/+V2bl/pRHjtYUu2U8FiBZnkaREScemAr5VMkIJ6rs38/VbF eSBA== X-Gm-Message-State: AOJu0YyJQi1HEZS2MrjOCuhpsJKKwTg09qEZR0lG2VTAub9iemlwTGsd B3d9fBsEV6Jx4v8hbNWVH9w= X-Google-Smtp-Source: AGHT+IHaXNmeqVM91a7esXurTTlDnrjJb8+rGqD/j2O/OfpHDNZnGDW4vZuG2H/XIbXr6VhANvEYvA== X-Received: by 2002:a17:90a:d252:b0:286:f169:79f1 with SMTP id o18-20020a17090ad25200b00286f16979f1mr5849429pjw.2.1701975352922; Thu, 07 Dec 2023 10:55:52 -0800 (PST) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:492a:db3d:eb42:de92]) by smtp.gmail.com with ESMTPSA id hk13-20020a17090b224d00b0028699a25207sm1723732pjb.12.2023.12.07.10.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 10:55:52 -0800 (PST) From: Fabio Estevam To: shawnguo@kernel.org Cc: linux-arm-kernel@lists.infradead.org, tharvey@gateworks.com, marcel.ziswiler@toradex.com, alexander.stein@ew.tq-group.com, Fabio Estevam Subject: [PATCH 2/3] arm64: dts: imx8mp-venice: Fix USB connector description Date: Thu, 7 Dec 2023 15:55:42 -0300 Message-Id: <20231207185543.2699697-2-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231207185543.2699697-1-festevam@gmail.com> References: <20231207185543.2699697-1-festevam@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_105554_577774_DB498EAF X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Fabio Estevam The USB connector should not be placed under the dwc3 node. Move the USB connector out of the SoC level and use port to describe the connection to the dwc3 controller. This fixes the following dt-schema warning: imx8mp-venice-gw72xx-2x.dtb: usb@38100000: Unevaluated properties are not allowed ('connector' was unexpected) from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# Signed-off-by: Fabio Estevam Acked-by: Tim Harvey --- .../dts/freescale/imx8mp-venice-gw71xx.dtsi | 26 +++++++++++++----- .../dts/freescale/imx8mp-venice-gw72xx.dtsi | 27 ++++++++++++++----- .../dts/freescale/imx8mp-venice-gw73xx.dtsi | 27 ++++++++++++++----- .../dts/freescale/imx8mp-venice-gw74xx.dts | 27 ++++++++++++++----- 4 files changed, 79 insertions(+), 28 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi index bf47b5e9dd8c..0e8d0f3c7ea8 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi @@ -8,6 +8,21 @@ #include / { + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + type = "micro"; + label = "Type-C"; + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + led-controller { compatible = "gpio-leds"; pinctrl-names = "default"; @@ -132,13 +147,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - type = "micro"; - label = "Type-C"; - id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi index 28eb7c00a1d9..f8ad5ea96330 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi @@ -8,6 +8,22 @@ #include / { + + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + type = "micro"; + label = "otg"; + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + led-controller { compatible = "gpio-leds"; pinctrl-names = "default"; @@ -182,13 +198,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - type = "micro"; - label = "otg"; - id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi index b0d42b18c5ce..0b89aa73998c 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi @@ -8,6 +8,22 @@ #include / { + + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + type = "micro"; + label = "otg"; + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + led-controller { compatible = "gpio-leds"; pinctrl-names = "default"; @@ -201,13 +217,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - type = "micro"; - label = "otg"; - id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts index dcf9bababffc..b323711fa090 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts @@ -35,6 +35,22 @@ memory@40000000 { reg = <0x0 0x40000000 0 0x80000000>; }; + + connector { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + compatible = "gpio-usb-b-connector", "usb-b-connector"; + type = "micro"; + label = "Type-C"; + id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + gpio-keys { compatible = "gpio-keys"; @@ -692,13 +708,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - compatible = "gpio-usb-b-connector", "usb-b-connector"; - type = "micro"; - label = "Type-C"; - id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; };