From patchwork Tue Dec 12 14:27:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 13489335 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B03E9C4332F for ; Tue, 12 Dec 2023 14:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZDGHLseMG3KieGpjFTfuv9psY1el3b4UpO7z5D7075g=; b=MRVraLOz8tBCl9 ynL0tO6O7Q6VivG8f5iX9nwOgbPaYtqh7J8x/FbpT9YEqBpYggeesUjf8det6jrvk3TDlgmHHfuwR eELgthxf2VdcuNiSMDtGoqt3vh85vtY9+FW+d0qC6ZXQ3s6h4QVYS4/gzxf84VMmcb1+uHgMgTbUN /sl0aViMFNNp53DbjU6uB9VsY0kTT5/P5I+oJF7NNbWp3zSW1lDksEQejrOLmMw92Oki7BeZTP4jx GvbzXUGRggPmo1rNk9hkYelnhUCuKjzjkRgAlXe58GRTqAC6ALr1SPkQzOUJ05hDmboqVXzPdDg+N tBmI58qCNCt59ZWh2O6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rD3ji-00Bu2U-1T; Tue, 12 Dec 2023 14:27:50 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rD3ja-00Btyg-1t for linux-arm-kernel@lists.infradead.org; Tue, 12 Dec 2023 14:27:43 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40c2718a768so58380745e9.0 for ; Tue, 12 Dec 2023 06:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702391260; x=1702996060; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2Srtyc9L2FmnDVigDPLvZ20bwEGcznbGsIksRkAyk9I=; b=ecvLXdVqe0ZineqjY5Gf3WFsAjO1Tl+IfvbRAmg5DlohBB+cmlRVen6tJ4h9Dl1F8o TxREplbUQAFw9PVfFzkWhZ1liqFlI/7z20Nepk/VvKBa44e0qrg7iWXJ22+wyttRUvSS xZDaVEUzmfWPTlWMSZ37+xAZMCVluIalnwbIC/6AAXpJ1zoNiFn32W+n8dz8WmdKtoMn 8xNweFpLHF9bgw9uqUEhfP4oYP5hDlKgmJpeIjHbZTZbM4GlrqQ3igNdqwgfPc2nZiMf /2l7jLOsDNDdRsL3JUUDG0QJtdAYyz/gBaPPa1YWtImu1b6B3zsBUt7z50vxf+mJpc6a 3qOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702391260; x=1702996060; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2Srtyc9L2FmnDVigDPLvZ20bwEGcznbGsIksRkAyk9I=; b=WAuaqT3QpTqjEFMNlq2bdKMVwuVnCiaNaN7BpOvodKV0kY+anJbSPrGAKWgKYq4dSM jc0qlNj2b3QkCa6az8DuKo5W+SxuDYwBnruB50Hxp/zHATbt9FfNAG2jnuS9DP63QDe7 PL8n+Vgmc82bh6lIp9HZcC8lVvK6zJUVDaVBALrLIVoulJvr6+j0PARShw2Q+WpxbkQO NLAQTD60IGAxpWvZDQHZtm2dF0G+GREUnixkM8ftQnAhBNSbushtLwqpWQgVi5UkyxYy V+Q5PJQjZXTP0fzj/2uKhwANAWoas83CizF71WYtUp1DAERHfZiEaIw+HJZpNgqBqJrG vRxA== X-Gm-Message-State: AOJu0YxaNzCZdDEiBqdUvPjfxlh49Oxyg7rZR6OUroUTe8WdoEiBQAnO kAEyGjc/y/JZSPnpJO0rWx4plQ== X-Google-Smtp-Source: AGHT+IEVZYNuESRPJf3SrUdgnSNQA3/D7rxcbHH36IiDkYzOkOFOUBTfqnbL3HQ+Is5iFwmlPLB85w== X-Received: by 2002:a05:600c:1c09:b0:40b:3645:4671 with SMTP id j9-20020a05600c1c0900b0040b36454671mr3704773wms.10.1702391260249; Tue, 12 Dec 2023 06:27:40 -0800 (PST) Received: from vingu-book.. ([2a01:e0a:f:6020:a004:6e24:43ee:dd81]) by smtp.gmail.com with ESMTPSA id fc7-20020a05600c524700b0040c44cb251dsm9078291wmb.46.2023.12.12.06.27.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 06:27:39 -0800 (PST) From: Vincent Guittot To: catalin.marinas@arm.com, will@kernel.org, sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, lukasz.luba@arm.com, rui.zhang@intel.com, mhiramat@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Vincent Guittot Subject: [PATCH 3/4] thermal/cpufreq: Remove arch_update_thermal_pressure() Date: Tue, 12 Dec 2023 15:27:29 +0100 Message-Id: <20231212142730.998913-4-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231212142730.998913-1-vincent.guittot@linaro.org> References: <20231212142730.998913-1-vincent.guittot@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231212_062742_626261_D098BBAC X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org arch_update_thermal_pressure() aims to update fast changing signal which should be averaged using PELT filtering before being provided to the scheduler which can't make smart use of fast changing signal. cpufreq now provides the maximum freq_qos pressure on the capacity to the scheduler, which includes cpufreq cooling device. Remove the call to arch_update_thermal_pressure() in cpufreq cooling device as this is handled by cpufreq_get_pressure(). Signed-off-by: Vincent Guittot Reviewed-by: Lukasz Luba --- drivers/thermal/cpufreq_cooling.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c index e2cc7bd30862..e77d3b44903e 100644 --- a/drivers/thermal/cpufreq_cooling.c +++ b/drivers/thermal/cpufreq_cooling.c @@ -448,7 +448,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, unsigned long state) { struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata; - struct cpumask *cpus; unsigned int frequency; int ret; @@ -465,8 +464,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency); if (ret >= 0) { cpufreq_cdev->cpufreq_state = state; - cpus = cpufreq_cdev->policy->related_cpus; - arch_update_thermal_pressure(cpus, frequency); ret = 0; }