From patchwork Wed Dec 13 21:18:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13491885 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35733C4332F for ; Wed, 13 Dec 2023 21:19:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gJVL32Vq6uItYaRhBcO6hIuBfy2kOEyVBdLpxR6Wvxw=; b=N+NzJ4+vvEUooj 3QAZNRZ2yFAcaK14gihIARkemQtUaQJ50eq0pN8mCzcPf3WUWDQ7aeE0PtQbahQdWwj0wDjjacSZs gM/rjalO3Y8IgdRyJfXZMx0IAh7rEqeHVdo2WIe4pMd7OmhjC54/9bt+KgYljO9Rgr9o36AoXWO/W q88B/fz+j+P+hITV/XtU94fWJLylIVo3qUkJgPvjijfP3pKQWCNK+aPUGJMq/oXA4upQAY0zp+ujs W/q8ycP93HHBthMJn1vEQKbws6p0pfrEZOkDRD4VP6iGVSaHYfuhmbdQPITCjf/XsGYyRi0new/QL eY5qkEi4z1XNso/u2KGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDWdI-00G2dN-2e; Wed, 13 Dec 2023 21:19:08 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDWdB-00G2c0-2K for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2023 21:19:03 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-5c67fdbe7d4so1067263a12.0 for ; Wed, 13 Dec 2023 13:18:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702502339; x=1703107139; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jQW63/FoQmulr1Lm6mD+QofbEapeexg5XilPGXLeaWM=; b=mCu2YhhkHjgZdwfjIvLr7KRuGVXPv88Q78O7a6BF9hTKmKHmDVi6dCHOXSQD39nwOI CTcel562GXLeXe8r8K8W3a0aGXEWLbDYioWVuLkXVZuXnR6s+9sQR7yRJh0uQRf39IVD NhmBUPO7fqvj7Z3VSBK3Bb+PNIL/DtXriCh5bNm6rS/YZe66n28CQGDmbdIfV60cNday ipzP68G5t5TRvz0cMcYgEOFs5cyLLl25OceJDnEwYCeDh2HXV/uw0i3xN8RkzRsRapA5 T6sYBnOoZ/o5yX53un6ZNFZalXSRS/HM/K7BVuFGjax9LHgBJbkY5PjJPRhifdj88PFD HTEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702502339; x=1703107139; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jQW63/FoQmulr1Lm6mD+QofbEapeexg5XilPGXLeaWM=; b=QyO8vso5ovF2tMBab2L2EcU06BxVR9HxX8fMZUCrj3cUvTvskrahoveZkKr+Mgo5Il zxn30b5Cd6QVD2va7wnOg98yN8pZVjKZzN3llIvKZjx7tOkjvUEMGHTK2/T4GhGj5XAU m5lIYqcAgFYTzXXQGe9Z0jPoj8IRuPal8eUu8xredMnVeB+VXwsrm//oc+trZPnLzezz DJHU+6Z7asGcsyWrBtjwv8OmlGhl5QIk7+tuQrVzxUUSnOVlbATCibRYBBXA5cRqspxW dDHwlgm9rRhJktBxe+Y5cynIdDcXanksbthhkDOOsHixWwV1f5vdlrIj53eHBbIK8Ubs ErQA== X-Gm-Message-State: AOJu0YzBGEnzDhyciITrzlowPRlzdBNPgOACZ8AWM4pn0+iRnA/Ypo4i uennyBrZmIN7sHQWA5QjQ/Y= X-Google-Smtp-Source: AGHT+IGo3kiYDgv/6q6u3ANWXf/4Thd2lkAnfQMJq8elWiIIbJIM9sL5reWouMDymE7Uo1BCZjqJ6Q== X-Received: by 2002:a17:902:ab0e:b0:1d3:6255:6c8c with SMTP id ik14-20020a170902ab0e00b001d362556c8cmr1156693plb.2.1702502338672; Wed, 13 Dec 2023 13:18:58 -0800 (PST) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:a61c:8373:8743:d180]) by smtp.gmail.com with ESMTPSA id j15-20020a170903024f00b001d0b080c7e6sm10957310plh.208.2023.12.13.13.18.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 13:18:58 -0800 (PST) From: Fabio Estevam To: shawnguo@kernel.org Cc: linux-arm-kernel@lists.infradead.org, tharvey@gateworks.com, marcel.ziswiler@toradex.com, alexander.stein@ew.tq-group.com, Fabio Estevam Subject: [PATCH v2 2/3] arm64: dts: imx8mp-venice: Fix USB connector description Date: Wed, 13 Dec 2023 18:18:46 -0300 Message-Id: <20231213211847.1096033-2-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231213211847.1096033-1-festevam@gmail.com> References: <20231213211847.1096033-1-festevam@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_131901_759381_E6716019 X-CRM114-Status: GOOD ( 12.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Fabio Estevam The USB connector should not be placed under the dwc3 node. Move the USB connector out of the SoC level and use port to describe the connection to the dwc3 controller. This fixes the following dt-schema warning: imx8mp-venice-gw72xx-2x.dtb: usb@38100000: Unevaluated properties are not allowed ('connector' was unexpected) from schema $id: http://devicetree.org/schemas/usb/snps,dwc3.yaml# Signed-off-by: Fabio Estevam Acked-by: Tim Harvey --- Changes since v1: - Removed blank lines. (Tim) - Collected Tim's ACK. .../dts/freescale/imx8mp-venice-gw71xx.dtsi | 26 ++++++++++++++----- .../dts/freescale/imx8mp-venice-gw72xx.dtsi | 26 ++++++++++++++----- .../dts/freescale/imx8mp-venice-gw73xx.dtsi | 26 ++++++++++++++----- .../dts/freescale/imx8mp-venice-gw74xx.dts | 26 ++++++++++++++----- 4 files changed, 76 insertions(+), 28 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi index bf47b5e9dd8c..0e8d0f3c7ea8 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx.dtsi @@ -8,6 +8,21 @@ #include / { + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + type = "micro"; + label = "Type-C"; + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + led-controller { compatible = "gpio-leds"; pinctrl-names = "default"; @@ -132,13 +147,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - type = "micro"; - label = "Type-C"; - id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi index 28eb7c00a1d9..c24587c895e1 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx.dtsi @@ -8,6 +8,21 @@ #include / { + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + type = "micro"; + label = "otg"; + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + led-controller { compatible = "gpio-leds"; pinctrl-names = "default"; @@ -182,13 +197,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - type = "micro"; - label = "otg"; - id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi index b0d42b18c5ce..628ffba69862 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx.dtsi @@ -8,6 +8,21 @@ #include / { + connector { + compatible = "gpio-usb-b-connector", "usb-b-connector"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + type = "micro"; + label = "otg"; + id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + led-controller { compatible = "gpio-leds"; pinctrl-names = "default"; @@ -201,13 +216,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - compatible = "gpio-usb-b-connector", "usb-b-connector"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - type = "micro"; - label = "otg"; - id-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts index dcf9bababffc..9caf7ca25444 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts @@ -35,6 +35,21 @@ memory@40000000 { reg = <0x0 0x40000000 0 0x80000000>; }; + connector { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbcon1>; + compatible = "gpio-usb-b-connector", "usb-b-connector"; + type = "micro"; + label = "Type-C"; + id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + + port { + usb_dr_connector: endpoint { + remote-endpoint = <&usb3_dwc>; + }; + }; + }; + gpio-keys { compatible = "gpio-keys"; @@ -692,13 +707,10 @@ &usb_dwc3_0 { role-switch-default-mode = "peripheral"; status = "okay"; - connector { - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_usbcon1>; - compatible = "gpio-usb-b-connector", "usb-b-connector"; - type = "micro"; - label = "Type-C"; - id-gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; + port { + usb3_dwc: endpoint { + remote-endpoint = <&usb_dr_connector>; + }; }; };