From patchwork Fri Dec 15 14:34:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Himanshu Bhavani X-Patchwork-Id: 13494535 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E16BDC35274 for ; Fri, 15 Dec 2023 14:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=o4tQ7bA/1BlI5A5P4z+/iZ1WfrryjXMdK71BG4BpwX0=; b=cFfuFnjhtkQtXS CY9bmHqn1u+iIsjhRhTuGaulffdxbstwrBVxfXmHCvHK6KQzKaHPpgKzJYxK3RzH9dc4OBgN0TeRU 3sPdhGjUy6lsJs0w5pd4QYSf5ooTkJBb6ASBt8RTyyAE5GlnXnab9lC4uBJhp7bZtC7Fy7Mpr33Va wBcgQ6GvPiiUR8pLlrC5XFhUh+9jC07JvNM1g6OFmSpaopUzuGpf6CCGPFz1i0+qepk5VwXy+VTTK 251mPLkr3xKztJt3+UZ4Z4Vs0UOPn40BnaVnlwvhr+KN2XhYoBgCwSH4wTRKOFNdsH+YJunmPlpG9 NBllqYFbG7PBd+0hEDjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rE9IX-003ZtB-0k; Fri, 15 Dec 2023 14:36:17 +0000 Received: from mail-bmxind01on20601.outbound.protection.outlook.com ([2a01:111:f403:2021::601] helo=IND01-BMX-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rE9IU-003Zr2-28 for linux-arm-kernel@lists.infradead.org; Fri, 15 Dec 2023 14:36:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=czeoSTM9sj2aMlDb/pTPzOx6iKlm008V8e9fYeFRvqBYas7vkYr/YS791LLHypLmLNIzzUF+JjF8o7bpfLZEx12N4ZtU/U8bXLxpXRJ3BonIPx2R2W47z8pmWej4We0OT+HZQzCe2JgQ9E4eC7BNVBlyTFhgKix2hSKn0dWro31k9Y8X4XkbcWxIAHZ42x+D3xV+7JMZaawZqmV8hDIMjiF/yTnJxad0sc7D+Rj0hjmoiHWlEXuUFeyDi099BZffMZs1VTuEMNDGo1o+coebm8AaPuLZRyqA+JGRUHTSOLHjsrNxdekymZZer1QP//XrLPZ/BBnjkA1iAJkRB9+syA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KJTRZ4reRGz4Tki8DbCg4GQ8JpDBEtLn4D2r1otZ+uY=; b=etiSEnq1X/nBBAePYaGAo03WZrRn4bIK7TZE4iIAC8O0hqHV0I5VwIXcMt/dxDEqoNokYleQAEnT0w+dCLahpxJFRaSxzz6as97f03bATYgA/XRqR2PbKEHO3D5Xzh7YnDXrrZuwxSCpPDmAC5BgMh0En1D+t1Hk54xlHRNcdjaHa7eNvnFgHdmwB1SJ3yN3wo1as8Ijkmf0cHDxoZ8le2U1YD9YS53o8ZUf1ZvU0Uo7JQtzfgVaOFTf27YzYY5f8u3kol1FF4PHvyMYNCsFfJfGEZEO7T+ruWX+f+soXMhWYCgEBVzWo0wH6/myjKMTX529nq4o41EugbzNxxgJUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siliconsignals.io; dmarc=pass action=none header.from=siliconsignals.io; dkim=pass header.d=siliconsignals.io; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siliconsignals.io; Received: from PN2PR01MB4908.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:8::19) by PN2PR01MB8971.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:114::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.28; Fri, 15 Dec 2023 14:35:51 +0000 Received: from PN2PR01MB4908.INDPRD01.PROD.OUTLOOK.COM ([fe80::7c37:5b8e:a99d:65be]) by PN2PR01MB4908.INDPRD01.PROD.OUTLOOK.COM ([fe80::7c37:5b8e:a99d:65be%4]) with mapi id 15.20.7091.030; Fri, 15 Dec 2023 14:35:51 +0000 From: Himanshu Bhavani To: Thinh.Nguyen@synopsys.com, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: himanshu.bhavani@siliconsignals.io, Greg Kroah-Hartman , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: dwc3: imx8mp: Fix smatch warning Date: Fri, 15 Dec 2023 20:04:57 +0530 Message-Id: <20231215143458.158810-1-himanshu.bhavani@siliconsignals.io> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: PN2PR01CA0074.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:23::19) To PN2PR01MB4908.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:8::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN2PR01MB4908:EE_|PN2PR01MB8971:EE_ X-MS-Office365-Filtering-Correlation-Id: c60ed3e0-55b6-487c-ca8c-08dbfd7b2289 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uhqiA9AP7Qh/dZOW/101BxU+EDnYvHvbi3nXk7BAKYk300zn7QIcnsjIK6/kPpdi6ZWbRtRelucus+M5xvBUjMetnv+oO3Siz+fgkUQ9/rJ7Aj70bW0GMmgCZ+956DcZ+ar/lOZo3hfJokWmAbv4Bbz71pHazwSGqq+Yv8uyJtxpZncSI+6Y+HR+AHuvVNDmx7kAI4EEpLH58M2cjtTrmomALZL2PB7YvJ3KNCtDq6bN/VahrLkDyVH8Nu+Xa0/SHGgSGCtYdMgOH3I3KweSk9X+4ShwYUDwaaieyOflBWRny/Gm+tGb8KmjidFqMBli+jPlRGN0uFtDjc8XcIErHpG82eYSp5FPeCzePkNtonzEQxECcEeGWhXpzhIJVBF/R4F9NGLQ37WK/0zh3SInVxKfAtqsvKhOccWKRZlK+RB8JObSsu8ADcSOfVFzzL3kju8grqNo26LBHwA/z8Fdn8VPEl8vbnmQTnGLqIcWfIfMVlGYJKfp+wcCv2kYGoPHKUS9sMN0v/B0UYvYrqX0HxVMsOGmQfAGtvN2TqVHCGeWLFTG9vxoD45yOLAtY0PjAFS+a3XExqcZWmIP9EsyDl/HRkCDynJcaZPTEaVMONEKfrj7+nTkNYplzzoUjdolo12BZcgLO1kmoznz9+ay9A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PN2PR01MB4908.INDPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39830400003)(376002)(136003)(346002)(396003)(366004)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(2616005)(36756003)(6512007)(52116002)(6506007)(2906002)(38100700002)(83380400001)(38350700005)(26005)(41300700001)(86362001)(1076003)(66946007)(66476007)(66556008)(316002)(478600001)(54906003)(4326008)(8936002)(8676002)(6486002)(44832011)(4744005)(7416002)(5660300002)(32563001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ohJwRQzMgdICugFIeoYPnDhN0dmp8RyIDSeLcxpEJCjaJ8LrmwoRrQMbQS3jjz4SJ8PtkHlB3A5D75oTFyeXkvycZCiBWFI27MkGuFlade/nzE2XBYchSgIgn/Nru4fAbFqGSO/sOKaXRlNum9K4kuNLuJ/dvmW9oAo5QNeOlQd60svviuhi15Mi6dRVU99BBIfszTVupwBzQI2i95ahWlGrzjR0QeL9B81pYSevNJ2EnTDsQMK7IS8zB30Od5umqcOnJV/k4OTud5XnIIgwsejTVSyXMNDjLhpLEBhNqoaRZsi647XGfad8u9bR9H4Bkra0svHz1k6ThTWbmLoKj3OwZ65CApGrJRIaplJrFMREndOvXJSg+E/0pu0HfpqVkrIh1tLqbQRlEWLeT2D3uIkkdFUQHQBKRt2ji1thO4s3KcYXUWj4Sg5hmtnvRi7da1q8x2lFnlKkRRqnyWJcJv3v+RF6K4/P/RbieamG3VT22aTAD+sgDIIyoH6/fqybz9RIQggmuaUIH1fciH83Hxu7PbpaPbQwzR4WrgPMR2o7tFNoB6PCCvxPBIWus5O1pllN/WFZ2nfPwFCWD7w1xThaVponLcpzo/T30j74PKwq25+inZUyCubOcF0sPrZiNusjflgn0W0wk7qIW0orW6CM+ts5joD19YneSd7/NcYLUtj9KzzcGt6TAI4QBewPlhlMfvgeQw8nknRICk/omSe9/0qav29vyppo1sKER6P84+2ZGzh5svOw3h6OqnHYjJ41JYqAXNy7kc725x3RpOAGYQoM7X/ZqxXOrTV4hDLBjPdQmIl4dekkXsHpOMzhhLd4hY3Y+c528SV5JxlbI7Btr4ZjR9SvogVl0wqrd1vdwbv8dRetVvWM5UBxbLIJdl1sZNIevz6VouVopMmPSc4BNOKbCC7KPhD6D2L0qSiE8my6GR704hFPBIPNHE2EGUfwYkd2gX7MLouA6bSz1eTHdGCprAI+V8IitqCIiHWe1SP+QUHvcG7pp4Ap/wJC6Ggpdt8ngQt+wZvxokTV9YolMt9MuLO4ftyfz6pxRi8u+9yIEJAktwi3gCtSs42POLno734JcBBhdf2IvoFfl7w4bompSDbzaqD7Ij5Px0r3W7m4DHUclmuKPB3liigUQb6dtMTDiNJmDvO5bSry3v0iyOzj0yfOWBkMonjGr8Zxh48lMxhl32w42zpviRfzEW3tcD18vTxjcxdzOhP7NlvM86+aPDazglzER2DwdhjdHrwk4LBF9p4xmipIobPW6/ajsxVIIqEOd2uD8OjFyNu+ofXgrLBPEDv4+rOvw6ixkeD2QELU2+A8JozUIPeJC3JPcCmKkEUoQHMGZAHWpx+qgjvqw1FAZbk9u18WT+IyUPhtKlIHKQ7mr81UaW2PodKR/ckStjpeTJqtXZfdnd3Bhh7rv+lyHh9gywHseVIhBeOvt62ukcLvYyTM9MNNKmFQf58XKng1/U4QA7UI2ppg+kYp+WEAdDRDW68puN1ZY5wZcaf47v8ZJmKyUXXZTo3RKoDQIlUTHrkA2JN5oxabY/isUzAduQOKIwhU5BCW0lA5YqRz0t/YnQdf1r3ehzr33lEW1C/6TqZbSXmN1vOPewbiis2EGc2VSR8svho= X-OriginatorOrg: siliconsignals.io X-MS-Exchange-CrossTenant-Network-Message-Id: c60ed3e0-55b6-487c-ca8c-08dbfd7b2289 X-MS-Exchange-CrossTenant-AuthSource: PN2PR01MB4908.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 14:35:51.0780 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7ec5089e-a433-4bd1-a638-82ee62e21d37 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nA/oQ+dn/7HVfwZlPMIhcLEzOjU/+Lec8C4aqpLINP9nTc86yFfXrDf0yrssnvKojGTw+MDjdbLVfDL1TegcftVXze/AopAagfzOEL+L3FqQhWg64cgUHpmWn4HaRzmb X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN2PR01MB8971 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231215_063614_725642_A6EAEEC9 X-CRM114-Status: UNSURE ( 6.35 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org dwc3_imx8mp_pm_resume() warn: 'dwc3_imx->suspend_clk' from clk_prepare_enable() not released Signed-off-by: Himanshu Bhavani diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c index a1e15f2fffdb..8ee448068503 100644 --- a/drivers/usb/dwc3/dwc3-imx8mp.c +++ b/drivers/usb/dwc3/dwc3-imx8mp.c @@ -363,8 +363,10 @@ static int __maybe_unused dwc3_imx8mp_pm_resume(struct device *dev) } ret = clk_prepare_enable(dwc3_imx->hsio_clk); - if (ret) + if (ret) { + clk_disable_unprepare(dwc3_imx->suspend_clk); return ret; + } ret = dwc3_imx8mp_resume(dwc3_imx, PMSG_RESUME);