| Message ID | 20231218105718.2445136-7-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dev_err_probe usage for imx8qxp DPU pipeline | expand |
Am Montag, 18. Dezember 2023, 11:57:18 CET schrieb Alexander Stein: > -517 errors are just annoying. dev_err_probe can't be used here either > as this would hide the error message already set in us->init. Please ignore. I just noticed this file is added in a locally applied series. Thanks Alexander > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > drivers/gpu/drm/imx/dpu/dpu-core.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/imx/dpu/dpu-core.c > b/drivers/gpu/drm/imx/dpu/dpu-core.c index d6116b3e4ed7..ea2558a14a6c > 100644 > --- a/drivers/gpu/drm/imx/dpu/dpu-core.c > +++ b/drivers/gpu/drm/imx/dpu/dpu-core.c > @@ -592,9 +592,10 @@ static int dpu_submodules_init(struct dpu_soc *dpu, > unsigned long dpu_base) ret = us->init(dpu, j, us->ids[j], us->types[j], > pec_ofs, dpu_base + us- >ofss[j]); > if (ret) { > - dev_err(dpu->dev, > - "failed to initialize %s%d: %d\n", > - us->name, us- >ids[j], ret); > + if (ret != -EPROBE_DEFER) > + dev_err(dpu->dev, > + "failed to initialize %s%d: %d\n", > + us- >name, us->ids[j], ret); > return ret; > } > }
diff --git a/drivers/gpu/drm/imx/dpu/dpu-core.c b/drivers/gpu/drm/imx/dpu/dpu-core.c index d6116b3e4ed7..ea2558a14a6c 100644 --- a/drivers/gpu/drm/imx/dpu/dpu-core.c +++ b/drivers/gpu/drm/imx/dpu/dpu-core.c @@ -592,9 +592,10 @@ static int dpu_submodules_init(struct dpu_soc *dpu, unsigned long dpu_base) ret = us->init(dpu, j, us->ids[j], us->types[j], pec_ofs, dpu_base + us->ofss[j]); if (ret) { - dev_err(dpu->dev, - "failed to initialize %s%d: %d\n", - us->name, us->ids[j], ret); + if (ret != -EPROBE_DEFER) + dev_err(dpu->dev, + "failed to initialize %s%d: %d\n", + us->name, us->ids[j], ret); return ret; } }
-517 errors are just annoying. dev_err_probe can't be used here either as this would hide the error message already set in us->init. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- drivers/gpu/drm/imx/dpu/dpu-core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)