| Message ID | 20231218134532.50599-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: MAINTAINERS: drop empty entries for removed boards | expand |
On Mon, Dec 18, 2023, at 13:45, Krzysztof Kozlowski wrote: > Drop empty and redundant maintainer entries for boards which were > removed to fix `scripts/get_maintainer.pl --self-test=sections` errors > like: > > ./MAINTAINERS:2021: warning: section without file pattern ARM/CIRRUS > LOGIC EDB9315A MACHINE SUPPORT Good catch, I wonder if I missed these in last year's board removal or if they were already broken back then. Some of these > @@ -2171,11 +2166,6 @@ T: git > git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git > F: arch/arm/boot/dts/nxp/vf/ > F: arch/arm/mach-imx/*vf610* > > -ARM/GUMSTIX MACHINE SUPPORT > -M: Steve Sakoman <sakoman@gmail.com> > -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > -S: Maintained I don't know if Steve still cares, but the board is still there in arch/arm/mach-pxa/{gumstix,am200epd.c,am300epd.c} > -ARM/INTEL XSC3 (MANZANO) ARM CORE > -M: Lennert Buytenhek <kernel@wantstofly.org> > -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > -S: Maintained Same here, the code is still there and used by pxa3xx: arch/arm/mm/*xsc3l2* > ARM/LG1K ARCHITECTURE > M: Chanho Min <chanho.min@lge.com> > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > @@ -2840,11 +2825,6 @@ F: arch/arm/boot/dts/synaptics/ > F: arch/arm/mach-berlin/ > F: arch/arm64/boot/dts/synaptics/ > > -ARM/TECHNOLOGIC SYSTEMS TS7250 MACHINE SUPPORT > -M: Lennert Buytenhek <kernel@wantstofly.org> > -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > -S: Maintained arch/arm/mach-ep93xx/ts72xx.c is about to be obsoleted by the ongoing DT conversion. > @@ -17674,14 +17649,6 @@ L: linux-gpio@vger.kernel.org > S: Maintained > F: drivers/gpio/gpio-pxa.c > > -PXA MMCI DRIVER > -S: Orphan > - > -PXA RTC DRIVER > -M: Robert Jarzmik <robert.jarzmik@free.fr> > -L: linux-rtc@vger.kernel.org > -S: Maintained > - drivers/mmc/host/pxamci.c and drivers/rtc/rtc-pxa.c are still in use. > > -RDC R-321X SoC > -M: Florian Fainelli <florian@openwrt.org> > -S: Maintained > - This is still supported and it's x86 rather than arm. There is a good chance that we /should/ remove it for being obsolete, but that has to be a separate series and remove the drivers and architecture support if we decide to go that way. I'm fairly sure this platform was originally added for use with OpenWRT but not everything was merged and OpenWRT stopped carrying the required patches in 2016: https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=fed29fa36bf9ff387ff6e96522b1b5423fed3581 Some of the drivers might still be in use on the related vortex86 cores, so maybe we keep the support and add N: rdc321x Arnd
On 18/12/2023 15:21, Arnd Bergmann wrote: > On Mon, Dec 18, 2023, at 13:45, Krzysztof Kozlowski wrote: >> Drop empty and redundant maintainer entries for boards which were >> removed to fix `scripts/get_maintainer.pl --self-test=sections` errors >> like: >> >> ./MAINTAINERS:2021: warning: section without file pattern ARM/CIRRUS >> LOGIC EDB9315A MACHINE SUPPORT > > Good catch, I wonder if I missed these in last year's board removal > or if they were already broken back then. Some of these > >> @@ -2171,11 +2166,6 @@ T: git >> git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git >> F: arch/arm/boot/dts/nxp/vf/ >> F: arch/arm/mach-imx/*vf610* >> >> -ARM/GUMSTIX MACHINE SUPPORT >> -M: Steve Sakoman <sakoman@gmail.com> >> -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >> -S: Maintained > > I don't know if Steve still cares, but the board is still there > in arch/arm/mach-pxa/{gumstix,am200epd.c,am300epd.c} I did not dig that deep before, but since you insist let's take a look: Entry was introduced in 90b8fc34968d ("[ARM] 4867/1: Adds flash, udc, mci support for gumstix F boards") and it did not cover board files. > >> -ARM/INTEL XSC3 (MANZANO) ARM CORE >> -M: Lennert Buytenhek <kernel@wantstofly.org> >> -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >> -S: Maintained > > Same here, the code is still there and used by pxa3xx: > > arch/arm/mm/*xsc3l2* Similar see: 2b7a52a459cb ("[PATCH] Update CREDITS and MAINTAINERS entries for Lennert Buytenhek") Adding the files to these entries would be actually changing status quo. > >> ARM/LG1K ARCHITECTURE >> M: Chanho Min <chanho.min@lge.com> >> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >> @@ -2840,11 +2825,6 @@ F: arch/arm/boot/dts/synaptics/ >> F: arch/arm/mach-berlin/ >> F: arch/arm64/boot/dts/synaptics/ >> >> -ARM/TECHNOLOGIC SYSTEMS TS7250 MACHINE SUPPORT >> -M: Lennert Buytenhek <kernel@wantstofly.org> >> -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >> -S: Maintained > > arch/arm/mach-ep93xx/ts72xx.c is about to be obsoleted by the ongoing > DT conversion. > > >> @@ -17674,14 +17649,6 @@ L: linux-gpio@vger.kernel.org >> S: Maintained >> F: drivers/gpio/gpio-pxa.c >> >> -PXA MMCI DRIVER >> -S: Orphan >> - >> -PXA RTC DRIVER >> -M: Robert Jarzmik <robert.jarzmik@free.fr> >> -L: linux-rtc@vger.kernel.org >> -S: Maintained >> - > > drivers/mmc/host/pxamci.c and drivers/rtc/rtc-pxa.c > are still in use. MMCI does not have maintainer. For the RTC, I guess the intention of 57f63bc8fe79 ("rtc: update maintainership of pxa rtc driver") was to maintain the driver. The actual problem is that all of these entries (and R-321X below) come from the times people were not putting any file paths to MAINTAINERS. They stayed like this for 15-17 years, thus being effectively noop. Let's maybe wait till any of Cc-ed people respond and confirm they want to grow the maintainer entry to cover the files? If they don't come, I propose to remove them. > >> >> -RDC R-321X SoC >> -M: Florian Fainelli <florian@openwrt.org> >> -S: Maintained >> - > > This is still supported and it's x86 rather than arm. > > There is a good chance that we /should/ remove it for being obsolete, > but that has to be a separate series and remove the drivers and > architecture support if we decide to go that way. Sure. > > I'm fairly sure this platform was originally added for use with > OpenWRT but not everything was merged and OpenWRT stopped > carrying the required patches in 2016: > > https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=fed29fa36bf9ff387ff6e96522b1b5423fed3581 > Best regards, Krzysztof
On Mon, Dec 18, 2023, at 15:39, Krzysztof Kozlowski wrote: > On 18/12/2023 15:21, Arnd Bergmann wrote: >> On Mon, Dec 18, 2023, at 13:45, Krzysztof Kozlowski wrote: >> >> drivers/mmc/host/pxamci.c and drivers/rtc/rtc-pxa.c >> are still in use. > > MMCI does not have maintainer. > > For the RTC, I guess the intention of 57f63bc8fe79 ("rtc: update > maintainership of pxa rtc driver") was to maintain the driver. > > The actual problem is that all of these entries (and R-321X below) come > from the times people were not putting any file paths to MAINTAINERS. > They stayed like this for 15-17 years, thus being effectively noop. > > Let's maybe wait till any of Cc-ed people respond and confirm they want > to grow the maintainer entry to cover the files? If they don't come, I > propose to remove them. Nobody else replied now, so for the moment, I applied a partial patch removing the EDB9315A, TS7250, TETON and CATS entries that are for files that were removed or are in the process. For the other ones, I would still prefer to just list the files. Arnd
diff --git a/MAINTAINERS b/MAINTAINERS index 0d26c5311fb1..cdf1575dc851 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2018,11 +2018,6 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Odd Fixes N: clps711x -ARM/CIRRUS LOGIC EDB9315A MACHINE SUPPORT -M: Lennert Buytenhek <kernel@wantstofly.org> -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) -S: Maintained - ARM/CIRRUS LOGIC EP93XX ARM ARCHITECTURE M: Hartley Sweeten <hsweeten@visionengravers.com> M: Alexander Sverdlin <alexander.sverdlin@gmail.com> @@ -2171,11 +2166,6 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git F: arch/arm/boot/dts/nxp/vf/ F: arch/arm/mach-imx/*vf610* -ARM/GUMSTIX MACHINE SUPPORT -M: Steve Sakoman <sakoman@gmail.com> -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) -S: Maintained - ARM/HISILICON SOC SUPPORT M: Wei Xu <xuwei5@hisilicon.com> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) @@ -2254,11 +2244,6 @@ F: Documentation/devicetree/bindings/arm/intel,keembay.yaml F: arch/arm64/boot/dts/intel/keembay-evm.dts F: arch/arm64/boot/dts/intel/keembay-soc.dtsi -ARM/INTEL XSC3 (MANZANO) ARM CORE -M: Lennert Buytenhek <kernel@wantstofly.org> -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) -S: Maintained - ARM/LG1K ARCHITECTURE M: Chanho Min <chanho.min@lge.com> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) @@ -2840,11 +2825,6 @@ F: arch/arm/boot/dts/synaptics/ F: arch/arm/mach-berlin/ F: arch/arm64/boot/dts/synaptics/ -ARM/TECHNOLOGIC SYSTEMS TS7250 MACHINE SUPPORT -M: Lennert Buytenhek <kernel@wantstofly.org> -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) -S: Maintained - ARM/TEGRA HDMI CEC SUBSYSTEM SUPPORT M: Hans Verkuil <hverkuil-cisco@xs4all.nl> L: linux-tegra@vger.kernel.org @@ -2861,11 +2841,6 @@ L: linux-samsung-soc@vger.kernel.org S: Maintained F: arch/arm64/boot/dts/tesla/ -ARM/TETON BGA MACHINE SUPPORT -M: "Mark F. Brown" <mark.brown314@gmail.com> -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) -S: Maintained - ARM/TEXAS INSTRUMENT AEMIF/EMIF DRIVERS M: Santosh Shilimkar <ssantosh@kernel.org> L: linux-kernel@vger.kernel.org @@ -17674,14 +17649,6 @@ L: linux-gpio@vger.kernel.org S: Maintained F: drivers/gpio/gpio-pxa.c -PXA MMCI DRIVER -S: Orphan - -PXA RTC DRIVER -M: Robert Jarzmik <robert.jarzmik@free.fr> -L: linux-rtc@vger.kernel.org -S: Maintained - PXA2xx/PXA3xx SUPPORT M: Daniel Mack <daniel@zonque.org> M: Haojian Zhuang <haojian.zhuang@gmail.com> @@ -18320,10 +18287,6 @@ F: drivers/media/i2c/max9271.c F: drivers/media/i2c/max9271.h F: drivers/media/i2c/rdacm21.c -RDC R-321X SoC -M: Florian Fainelli <florian@openwrt.org> -S: Maintained - RDC R6040 FAST ETHERNET DRIVER M: Florian Fainelli <f.fainelli@gmail.com> L: netdev@vger.kernel.org @@ -19930,11 +19893,6 @@ F: Documentation/devicetree/bindings/display/simple-framebuffer.yaml F: drivers/video/fbdev/simplefb.c F: include/linux/platform_data/simplefb.h -SIMTEC EB110ATX (Chalice CATS) -M: Simtec Linux Team <linux@simtec.co.uk> -S: Supported -W: http://www.simtec.co.uk/products/EB110ATX/ - SIOX M: Thorsten Scherer <t.scherer@eckelmann.de> M: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Drop empty and redundant maintainer entries for boards which were removed to fix `scripts/get_maintainer.pl --self-test=sections` errors like: ./MAINTAINERS:2021: warning: section without file pattern ARM/CIRRUS LOGIC EDB9315A MACHINE SUPPORT Cc: Lennert Buytenhek <kernel@wantstofly.org> Cc: Steve Sakoman <sakoman@gmail.com> Cc: Mark F. Brown <mark.brown314@gmail.com> Cc: Robert Jarzmik <robert.jarzmik@free.fr> Cc: Florian Fainelli <florian@openwrt.org> Cc: Simtec Linux Team <linux@simtec.co.uk> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- MAINTAINERS | 42 ------------------------------------------ 1 file changed, 42 deletions(-)