From patchwork Thu Dec 21 15:24:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 13502271 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F0C8C35274 for ; Thu, 21 Dec 2023 15:24:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IPPV/81VXhPlC0Vwnrhm//IrjYKizK03yxjARqaAuYI=; b=P9N7fsA1HbbEpM Ubc6W7WW5daFNSUFdLUsxepj9P98RzqjVkHenvANaVprebiatw5D1rlarevmOEuEUgPCfzSJIzM55 yhyrwDfKimJa/008B6Vjn/Ps1+SyQoOw4OpUbJv33etmS/XCyW/jM88aoCqGDOzde3OrKt+T+Smwh sMDHTMi1XgvgHRcTLNZjxQeRXLwmsY2G3VMmidl9+OcgxKlP7LfQ3jOgUEgjPyQ/P2c3D4fChqdIv +/dP94g/h5efaQ7xTQKDD+mRHEvZQMZSuZqXNOLKcNN91wWggVwy2cCMLiWhQo4ZyZfLME/DI4peA D7wt/6SRplG/TlO6NFRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rGKuW-003K4R-2j; Thu, 21 Dec 2023 15:24:32 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rGKuH-003JwS-1i for linux-arm-kernel@lists.infradead.org; Thu, 21 Dec 2023 15:24:19 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40c6ea99429so10173475e9.3 for ; Thu, 21 Dec 2023 07:24:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703172255; x=1703777055; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ldki2kQSS5xwW+AeQkZhBQ2GExVZGYy+iS8PnV7iC50=; b=tCopmaO68Vltu8r71jyuJGZ03tyGHFa9vJKRmtzDGXT63DgvI4gdFspTjJfb9m+abX YtWAigtc1Lt8JZI1SgW6WR1Xwss5JCznIjXMql7enR2INB4qm7z/wHz/bOqY/SHF52Ed gxgqdq5bnetVp9aIxgLioS9XcBn9VtqRLk5XiZnUOCS9m01FsN/6pi+t2EaFTEc+CL9K bl9/2rWujbASLnoVN+jjCskTvmFvnE6y+RbnIJI2Yu0eraF1iMPbNyhLOBzRB6qm/vJF gfsFdbtwRQ9qoXDWZValdqrbf6oWOLYLI0AlbtYZAtsPkkk/rhpaJRvHEeiniXfpcczK E/Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703172255; x=1703777055; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ldki2kQSS5xwW+AeQkZhBQ2GExVZGYy+iS8PnV7iC50=; b=XbBwq0O8tg6plZOy9mGn7mY90wb19jlBqY5fMmAViroVpcNlzF+ZSVPv/CmH5+pWqd Lj3Hy6uY3mPsZHFII5SfVKwGLLVtA0qaUPyJ//Qp72mwuWlQY1+OIZKu1GxBOw9p+bN5 KPbDhX8llg+T+sbe3z1BgZmpr2kV6B2qBR02OS0sTNuLxCTqAOcpJaOlNrkwcS1Z/B0y 3PB2DfQSRD/xj3aYb6JtYNbA/yL6kek2GzqN2YEeV6f40TlZV3Gnwb2tbeyABj7ZYtMh j+0Hyjx8Kp4umR0RDEiqys/AjvTANf2rEAC7iiUe2wrjQxNnJHE5iosxPqbR5AfdYU3i AXgQ== X-Gm-Message-State: AOJu0YxWP+LOk0T6GVy9wjV47sNGuZPlZ5PH1ZmDI3Kd+8cilrwvdxeu XAluxNGa213HhUozN/EeOQeQiA== X-Google-Smtp-Source: AGHT+IH+ssk4EbOp8vSgZen/OElcpPHfwMVCJP0+M/6mrBqydeBIQBk7E0Gi56kUk+RCd4jQuTRBBQ== X-Received: by 2002:a05:600c:22c3:b0:40d:284a:6b6e with SMTP id 3-20020a05600c22c300b0040d284a6b6emr556980wmg.153.1703172255409; Thu, 21 Dec 2023 07:24:15 -0800 (PST) Received: from vingu-book.. ([2a01:e0a:f:6020:2db4:9d2a:db65:42d6]) by smtp.gmail.com with ESMTPSA id t3-20020a05600c450300b0040c4acaa4bfsm11466974wmo.19.2023.12.21.07.24.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 07:24:14 -0800 (PST) From: Vincent Guittot To: catalin.marinas@arm.com, will@kernel.org, sudeep.holla@arm.com, rafael@kernel.org, viresh.kumar@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, lukasz.luba@arm.com, rui.zhang@intel.com, mhiramat@kernel.org, daniel.lezcano@linaro.org, amit.kachhap@gmail.com, linux@armlinux.org.uk, corbet@lwn.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Vincent Guittot Subject: [PATCH v2 3/5] thermal/cpufreq: Remove arch_update_thermal_pressure() Date: Thu, 21 Dec 2023 16:24:05 +0100 Message-Id: <20231221152407.436177-4-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231221152407.436177-1-vincent.guittot@linaro.org> References: <20231221152407.436177-1-vincent.guittot@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231221_072417_573232_88C4AC4F X-CRM114-Status: GOOD ( 10.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org arch_update_thermal_pressure() aims to update fast changing signal which should be averaged using PELT filtering before being provided to the scheduler which can't make smart use of fast changing signal. cpufreq now provides the maximum freq_qos pressure on the capacity to the scheduler, which includes cpufreq cooling device. Remove the call to arch_update_thermal_pressure() in cpufreq cooling device as this is handled by cpufreq_get_pressure(). Signed-off-by: Vincent Guittot Reviewed-by: Lukasz Luba Acked-by: Viresh Kumar --- drivers/thermal/cpufreq_cooling.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/thermal/cpufreq_cooling.c b/drivers/thermal/cpufreq_cooling.c index e2cc7bd30862..e77d3b44903e 100644 --- a/drivers/thermal/cpufreq_cooling.c +++ b/drivers/thermal/cpufreq_cooling.c @@ -448,7 +448,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, unsigned long state) { struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata; - struct cpumask *cpus; unsigned int frequency; int ret; @@ -465,8 +464,6 @@ static int cpufreq_set_cur_state(struct thermal_cooling_device *cdev, ret = freq_qos_update_request(&cpufreq_cdev->qos_req, frequency); if (ret >= 0) { cpufreq_cdev->cpufreq_state = state; - cpus = cpufreq_cdev->policy->related_cpus; - arch_update_thermal_pressure(cpus, frequency); ret = 0; }