From patchwork Sun Dec 24 15:44:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13504312 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6183C46CD4 for ; Sun, 24 Dec 2023 15:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bC+sIUelCZvpR1nHzivKSIiOMfl92u2Dtrvlzd0Dbtk=; b=lFl8PZiVsffnbx PJAUR2tL5Q8QvAwOufbR3dz/wLYxb32js5PT0R4zd5qGGCKoLF4MrLgEPtxLP5ILSlW5Jt+ytru7s iSQbFFzhVyR6I+LPXxT1GlPewVzwECeSQB5deLS9UE+DrlwDKcRvCBbinOHFjgZ1v6NIyvBDe5CaY Ho3gqwAovpg0sFmzMcVDZXLfGu5RJ+1a0mCHFjMCDfi7oRQRUoOqXjUJZvwZzRd++A2G6g3U+DujN LZMyvmAqLrbJDIjgdFP+igd6MfEfJSGadGOhnv4TvAwVkZ+/KazonhQUNRfJywB/5qYUJbmWLEjBv +mwNsQe7SsQ2y+dED7Mg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rHQeh-009YJC-0K; Sun, 24 Dec 2023 15:44:43 +0000 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rHQeX-009YCv-1P for linux-arm-kernel@lists.infradead.org; Sun, 24 Dec 2023 15:44:34 +0000 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-55361b7f38eso3828821a12.0 for ; Sun, 24 Dec 2023 07:44:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703432671; x=1704037471; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Onwp4Wr1mUGcp5LZpvd0xonQACtJfZwXbS/++yMm9d8=; b=iGORMLAVtbu6ZTVWj4q6BVPo6hoZV1tx7qteGRfEVF6AKe2kF+1A7y6pKrKs6gh+Te cKVy2ND25pL5xG1xrxrE1OtUmOHDX/cfy/gMnvJaRG6jeaDqmdPAoWgUSp/04RLw6rmp 9YhAgUkzhOP9GPDqFVTRdX6TekFvC9YtXrKvukI0eFDx3X84xMaqogaTYnLrF1GQ66oQ XbiiFa2oaaJ7EorQae2Pl2C2DJxR4XBR1y4u4B+9MwZLJVKT/OJ3o14LUQFQ4w1LCQGC kxNX1Sl0aQ1EYnOt5N1Co+B097r/eldhdb0/Ptp8OcQH2ze4/wdwU4uMJnrP+ji7+tDe K3Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703432671; x=1704037471; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Onwp4Wr1mUGcp5LZpvd0xonQACtJfZwXbS/++yMm9d8=; b=T8WITbJxcwE/w18CvEy13XwNwKs2WbiQiA94IsX93T6La7euH0DEHt07nA5qaQIqFV siMwkij9/l4hpwXQ3vhxNAe7VrB9ELmadrp0r1V/mbYRnGtGiBPdYIGlKFZz8cfSn5Np CXlnXVMNfOMvhFs5StyIY3oDqf6H9D5nRVaLzzFQnCowgx16R6HMoNW84ivHChjDFnJL +b48whaYaGeuXCCk9vqSn/fDVEI1wD2McacEEUi7eK4AsKvNVuuKeqIZOenrxPQQ5D3V qhrlptr426idVKyYDZfSt/31GBHm0k0VVTXKO7KwxZzTSNip7usnb/Jl1KRnup5bkTq6 sUTg== X-Gm-Message-State: AOJu0Yzw8qa5gr+WvE36T9B69RdEKTMV668o1xCFmvvmZEvRXcgSi+aC 7fvjfR4GodmMwz2lotKPsR2kGPhFLLdj0Q== X-Google-Smtp-Source: AGHT+IESUFUOS1uBJFg3d1DW1wsZmKy7QL9mSj2CDo1xn0OLo+tYjRvyt6wulJLJVaRh5xueH8Xlow== X-Received: by 2002:a50:9316:0:b0:554:262:3115 with SMTP id m22-20020a509316000000b0055402623115mr2237467eda.61.1703432671722; Sun, 24 Dec 2023 07:44:31 -0800 (PST) Received: from [127.0.1.1] ([78.10.206.178]) by smtp.gmail.com with ESMTPSA id ge12-20020a170907908c00b00a26ac403032sm3325901ejb.65.2023.12.24.07.44.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Dec 2023 07:44:31 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 24 Dec 2023 16:44:01 +0100 Subject: [PATCH 02/15] media: s5p-mfc: drop unused static s5p_mfc_ops MIME-Version: 1.0 Message-Id: <20231224-n-s5p-mfc-const-v1-2-a3b246470fe4@linaro.org> References: <20231224-n-s5p-mfc-const-v1-0-a3b246470fe4@linaro.org> In-Reply-To: <20231224-n-s5p-mfc-const-v1-0-a3b246470fe4@linaro.org> To: Marek Szyprowski , Andrzej Hajda , Mauro Carvalho Chehab Cc: Aakarsh Jain , linux-fsd@tesla.coma, linux-samsung-soc@vger.kernel.org, Smitha T Murthy , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1204; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=SGfvZrymg/GAF5fJD7rUJGwMU1wlhVHljcM4HZIJOUU=; b=owEBfgKB/ZANAwAKAcE3ZuaGi4PXAcsmYgBliFHPINUgnCaukbsTkqOz02P9rYU/IEHonJNio Yt89shzGsOJAkQEAAEKAC4WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZYhRzxAca3J6a0BrZXJu ZWwub3JnAAoJEME3ZuaGi4PX1e8P/R/7U5mMUd1VtV+BK7C5r2nay0DcsfSLWuO0T9OwRSvrFnp ySYSEO0r4IHt0nsjgFrw6/CRQwTc+zs7UZ+k34p+vJ87Nt0wK2DSoJ1hFnIqYnS7+0Jr+9URJIH mLrWZLfQXKPPWGaM/qHBcWfXHntXz1iziCqFQSD22V4huu14mE3MbZYDXwV0U0VMOE7gSwqlbXW Lps6BgTmwDEwQsohTjA1al47R4MtX+OaiPlO+TUmYvAIfR/i3sH9k5NptQis8n6OtVI9NnOnuge zUGacpiZR40eBdBXtgry7XADd5/PebvdBuUp42fI7clXcs9kPZo8cpX0nM2GWW9t0jjtFXXxiPY ygGJGIV/VPrXwent8N5Dj5lcvG7cVsVLyqOdReVUQcaMUrFrnIcB/ZegJkE1qp7wfzRmesuA2Ml oKQH725AMGNb/rrPYqFMTbJSLXzvCCvSfoG9hnZqi4FWAPHn/paZyqsYONVlXlS+oXz7PRM5RRY haKUpwYUI48ayV4rZ0rux4k7JjD79yFOn/qMBPhh8eu/tvkJnv9MS00IR8PCLX04zpK5HqdNXZO FVFK9DI1doPrAu5tNbtS0FgI2ZfqN6TRHZKesgTv5TsSCnhADIsUCkoepVr2MV/pOOhErGEqMG8 0D2YzNvIOmNKKb0ej3JeFXE9CzW4rE3NUINKd X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231224_074433_473509_C4267315 X-CRM114-Status: UNSURE ( 9.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org File-scope static variable "s5p_mfc_ops" is not read after assignment, thus it can be dropped entirely. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Aakarsh Jain --- drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c index 673962301173..5ba791fa3676 100644 --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c @@ -14,18 +14,15 @@ #include "s5p_mfc_opr_v5.h" #include "s5p_mfc_opr_v6.h" -static struct s5p_mfc_hw_ops *s5p_mfc_ops; - void s5p_mfc_init_hw_ops(struct s5p_mfc_dev *dev) { if (IS_MFCV6_PLUS(dev)) { - s5p_mfc_ops = s5p_mfc_init_hw_ops_v6(); + dev->mfc_ops = s5p_mfc_init_hw_ops_v6(); dev->warn_start = S5P_FIMV_ERR_WARNINGS_START_V6; } else { - s5p_mfc_ops = s5p_mfc_init_hw_ops_v5(); + dev->mfc_ops = s5p_mfc_init_hw_ops_v5(); dev->warn_start = S5P_FIMV_ERR_WARNINGS_START; } - dev->mfc_ops = s5p_mfc_ops; } void s5p_mfc_init_regs(struct s5p_mfc_dev *dev)